mm: Provide generic VDSO unmap and remap functions
Subsystems (22)
RFC v2 1/7 mm: Provide generic VDSO unmap and remap functions
When Address Space Layout Randomization (ASLR, randmaps) is enabled, the address of the VDSO fluctuates from one process to the next. If Checkpoint/Restore In Userspace (CRIU) is to fully replicate the memory map of a previous process, it must be able to remap the VDSO of a new process to the address used by the previous process. Historically this has been implemented in architecture-specific code for PowerPC and x86. In order to support 32-bit and 64-bit ARM without further duplication of code, copy Laurent Dufour's implementation for PowerPC with slight modifications to a generic location. This is hopefully the beginning of a long process of VDSO code de-duplication between architectures.
--- include/asm-generic/mm_hooks.h | 35 ++++++++++++++++++++++++++++++++--- 1 file changed, 32 insertions(+), 3 deletions(-)
include/asm-generic/mm_hooks.h +32 -3
@@ -1,7 +1,17 @@/* -* Define generic no-op hooks for arch_dup_mmap, arch_exit_mmap -* and arch_unmap to be included in asm-FOO/mmu_context.h for any -* arch FOO which doesn't need to hook these. +* Define generic hooks for arch_dup_mmap, arch_exit_mmap and arch_unmap to be +* included in asm-FOO/mmu_context.h for any arch FOO which doesn't need to +* specially hook these. +* +* arch_remap originally from include/linux-mm-arch-hooks.h +* arch_unmap originally from arch/powerpc/include/asm/mmu_context.h +* Copyright (C) 2015, IBM Corporation +* Author: Laurent Dufour <[email protected]> +* +* This program is free software; you can redistribute it and/or modify +* it under the terms of the GNU General Public License version 2 as +* published by the Free Software Foundation. +* */ #ifndef _ASM_GENERIC_MM_HOOKS_H#define _ASM_GENERIC_MM_HOOKS_H
@@ -19,6 +29,25 @@ static inline void arch_unmap(struct mm_struct *mm,struct vm_area_struct *vma, unsigned long start, unsigned long end) { +#ifdef CONFIG_GENERIC_VDSO + if (start <= mm->context.vdso && mm->context.vdso < end) + mm->context.vdso = 0; +#endif /* CONFIG_GENERIC_VDSO */ +} + +static inline void arch_remap (struct mm_struct *mm, +unsigned long old_start,unsigned long old_end, +unsigned long new_start,unsigned long new_end) +{ +#ifdef CONFIG_GENERIC_VDSO +/* +* mremap() doesn't allow moving multiple vmas so we can limit the +* check to old_addr == vdso. +*/ +if (old_addr == mm->context.vdso) + mm->context.vdso = new_addr; + +#endif /* CONFIG_GENERIC_VDSO */ } static inline void arch_bprm_mm_init(struct mm_struct *mm,
Signature · 9 lines
Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
RFC v2 2/7 arm: Use generic VDSO unmap and remap
Checkpoint/Restore In Userspace (CRIU) needs to be able to unmap and remap the VDSO to successfully checkpoint and restore applications in the face of changing VDSO addresses due to Address Space Layout Randomization (ASLR, randmaps). Previously, this was implemented in architecture-specific code for PowerPC and x86. However, a generic version based on Laurent Dufour's PowerPC implementation is now available, so begin using it on ARM.
--- arch/arm/mm/Kconfig | 1 + 1 file changed, 1 insertion(+)
arch/arm/mm/Kconfig +1 -0
@@ -845,6 +845,7 @@ config VDSO depends on AEABI && MMU && CPU_V7 default y if ARM_ARCH_TIMER select GENERIC_TIME_VSYSCALL + select GENERIC_VDSO help Place in the process address space an ELF shared object providing fast implementations of gettimeofday and
Signature · 3 lines
Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
Russell King - ARM Linux
maintainerRe: [RFC v2 2/7] arm: Use generic VDSO unmap and remap
You know, on its own, this patch is totally meaningless. Sorry, there's nothing more I can say about this.
Quoted 29 lines · Christopher Covington
Checkpoint/Restore In Userspace (CRIU) needs to be able to unmap and remap the VDSO to successfully checkpoint and restore applications in the face of changing VDSO addresses due to Address Space Layout Randomization (ASLR, randmaps). Previously, this was implemented in architecture-specific code for PowerPC and x86. However, a generic version based on Laurent Dufour's PowerPC implementation is now available, so begin using it on ARM.
Signed-off-by Christopher Covington <[email protected]>--- arch/arm/mm/Kconfig | 1 + 1 file changed, 1 insertion(+)arch/arm/mm/Kconfig +1
-0@@ -845,6 +845,7 @@ config VDSO depends on AEABI && MMU && CPU_V7 default y if ARM_ARCH_TIMER select GENERIC_TIME_VSYSCALL + select GENERIC_VDSO help Place in the process address space an ELF shared object providing fast implementations of gettimeofday andSignature · 3 lines
Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
Signature · 3 lines
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.
RFC v2 3/7 arm64: Use unsigned long for VDSO
In reply to Christopher CovingtonUse an unsigned long type for the base address of the VDSO in order to be compatible with the new generic VDSO remap and unmap functions originating from PowerPC and now also used by 32-bit ARM.
--- arch/arm64/include/asm/mmu.h | 2 +- arch/arm64/kernel/vdso.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-)
arch/arm64/include/asm/mmu.h +1 -1
@@ -18,7 +18,7 @@typedef struct {atomic64_t id; -void *vdso; +unsigned long vdso; }mm_context_t ;/*
arch/arm64/kernel/vdso.c +3 -3
@@ -97,7 +97,7 @@ int aarch32_setup_vectors_page(struct linux_binprm *bprm, int uses_interp)if (down_write_killable (&mm->mmap_sem))return -EINTR ; - current->mm->context.vdso = (void *)addr; + current->mm->context.vdso = addr;/* Map vectors page at the high address. */ ret = _install_special_mapping(mm, addr, PAGE_SIZE,
@@ -178,7 +178,7 @@ int arch_setup_additional_pages(struct linux_binprm *bprm, goto up_fail; vdso_base +=PAGE_SIZE ; - mm->context.vdso = (void *)vdso_base; + mm->context.vdso = vdso_base; ret = _install_special_mapping(mm, vdso_base, vdso_text_len, VM_READ|VM_EXEC| VM_MAYREAD|VM_MAYWRITE|VM_MAYEXEC,
@@ -191,7 +191,7 @@ int arch_setup_additional_pages(struct linux_binprm *bprm,return 0 ; up_fail: - mm->context.vdso =NULL ; + mm->context.vdso =0 ;up_write (&mm->mmap_sem);return PTR_ERR (ret); }
Signature · 3 lines
Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
RFC v2 4/7 arm64: Use generic VDSO unmap and remap functions
In reply to Christopher CovingtonCheckpoint/Restore In Userspace (CRIU) must be able to remap and unmap the Virtual Dynamic Shared Object (VDSO) to be able to handle the changing addresses that result from address space layout randomization. Now that generic support is available and arm64 has adopted unsigned long for the type of mm->context.vdso, opt-in to VDSO unmap and remap support.
--- arch/arm64/Kconfig | 1 + 1 file changed, 1 insertion(+)
arch/arm64/Kconfig +1 -0
@@ -50,6 +50,7 @@ config ARM64 select GENERIC_STRNCPY_FROM_USER select GENERIC_STRNLEN_USER select GENERIC_TIME_VSYSCALL + select GENERIC_VDSO select HANDLE_DOMAIN_IRQ select HARDIRQS_SW_RESEND select HAVE_ALIGNED_STRUCT_PAGE if SLUB
Signature · 3 lines
Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
RFC v2 5/7 powerpc: Rename context.vdso_base to context.vdso
In reply to Christopher CovingtonCheckpoint/Restore In Userspace (CRIU) needs to be able to unmap and remap the VDSO to successfully checkpoint and restore applications in the face of changing VDSO addresses due to Address Space Layout Randomization (ASLR, randmaps). x86 and PowerPC have had architecture-specific code to support this. In order to expand the architectures that support this without unnecessary duplication of code, a generic version based on the PowerPC code was created. It differs slightly, based on the results of an informal survey of all architectures that indicated
unsigned long vdso;
is popular (and it's also concise). Therefore, change the variable name in powerpc from mm->context.vdso_base to mm->context.vdso.
--- arch/powerpc/include/asm/book3s/32/mmu-hash.h | 2 +- arch/powerpc/include/asm/book3s/64/mmu.h | 2 +- arch/powerpc/include/asm/mm-arch-hooks.h | 6 +++--- arch/powerpc/include/asm/mmu-40x.h | 2 +- arch/powerpc/include/asm/mmu-44x.h | 2 +- arch/powerpc/include/asm/mmu-8xx.h | 2 +- arch/powerpc/include/asm/mmu-book3e.h | 2 +- arch/powerpc/include/asm/mmu_context.h | 4 ++-- arch/powerpc/include/asm/vdso.h | 2 +- arch/powerpc/include/uapi/asm/elf.h | 2 +- arch/powerpc/kernel/signal_32.c | 8 ++++---- arch/powerpc/kernel/signal_64.c | 4 ++-- arch/powerpc/kernel/vdso.c | 8 ++++---- arch/powerpc/perf/callchain.c | 12 ++++++------ 14 files changed, 29 insertions(+), 29 deletions(-)
arch/powerpc/include/asm/book3s/32/mmu-hash.h +1 -1
@@ -79,7 +79,7 @@ struct hash_pte {typedef struct {unsigned long id; -unsigned long vdso_base; +unsigned long vdso; }mm_context_t ;#endif /* !__ASSEMBLY__ */
arch/powerpc/include/asm/book3s/64/mmu.h +1 -1
@@ -72,7 +72,7 @@ typedef struct {#else u16 sllp;/* SLB page size encoding */ #endif -unsigned long vdso_base; +unsigned long vdso;#ifdef CONFIG_PPC_SUBPAGE_PROT struct subpage_prot_table spt;#endif /* CONFIG_PPC_SUBPAGE_PROT */
arch/powerpc/include/asm/mm-arch-hooks.h +3 -3
@@ -18,10 +18,10 @@ static inline void arch_remap(struct mm_struct *mm, {/* * mremap() doesn't allow moving multiple vmas so we can limit the -* check to old_start == vdso_base. +* check to old_start == vdso. */ -if (old_start == mm->context.vdso_base) - mm->context.vdso_base = new_start; +if (old_start == mm->context.vdso) + mm->context.vdso = new_start; }#define arch_remap arch_remap
arch/powerpc/include/asm/mmu-40x.h +1 -1
@@ -56,7 +56,7 @@typedef struct {unsigned int id;unsigned int active; -unsigned long vdso_base; +unsigned long vdso; }mm_context_t ;#endif /* !__ASSEMBLY__ */
arch/powerpc/include/asm/mmu-44x.h +1 -1
@@ -107,7 +107,7 @@ extern unsigned int tlb_44x_index;typedef struct {unsigned int id;unsigned int active; -unsigned long vdso_base; +unsigned long vdso; }mm_context_t ;#endif /* !__ASSEMBLY__ */
arch/powerpc/include/asm/mmu-8xx.h +1 -1
@@ -167,7 +167,7 @@typedef struct {unsigned int id;unsigned int active; -unsigned long vdso_base; +unsigned long vdso; }mm_context_t ;#define PHYS_IMMR_BASE (mfspr(SPRN_IMMR) & 0xfff80000)
arch/powerpc/include/asm/mmu-book3e.h +1 -1
@@ -228,7 +228,7 @@ extern unsigned int tlbcam_index; typedef struct { unsigned int id; unsigned int active; - unsigned long vdso_base; + unsigned long vdso; #ifdef CONFIG_PPC_MM_SLICES u64 low_slices_psize; /* SLB page size encodings */ u64 high_slices_psize; /* 4 bits per slice for now */
arch/powerpc/include/asm/mmu_context.h +2 -2
@@ -146,8 +146,8 @@ static inline void arch_unmap(struct mm_struct *mm,struct vm_area_struct *vma, unsigned long start, unsigned long end) { - if (start <= mm->context.vdso_base && mm->context.vdso_base < end) - mm->context.vdso_base = 0; + if (start <= mm->context.vdso && mm->context.vdso < end) + mm->context.vdso = 0; } static inline void arch_bprm_mm_init(struct mm_struct *mm,
arch/powerpc/include/asm/vdso.h +1 -1
@@ -17,7 +17,7 @@#ifndef __ASSEMBLY__ -/* Offsets relative to thread->vdso_base */ +/* Offsets relative to mm->context.vdso */ extern unsigned long vdso64_rt_sigtramp;extern unsigned long vdso32_sigtramp;extern unsigned long vdso32_rt_sigtramp;
arch/powerpc/include/uapi/asm/elf.h +1 -1
@@ -182,7 +182,7 @@ do { \NEW_AUX_ENT (AT_DCACHEBSIZE , dcache_bsize); \NEW_AUX_ENT (AT_ICACHEBSIZE , icache_bsize); \NEW_AUX_ENT (AT_UCACHEBSIZE , ucache_bsize); \ -VDSO_AUX_ENT (AT_SYSINFO_EHDR , current->mm->context.vdso_base); \ +VDSO_AUX_ENT (AT_SYSINFO_EHDR , current->mm->context.vdso); \ }while (0 )/* PowerPC64 relocations defined by the ABIs */
arch/powerpc/kernel/signal_32.c +4 -4
@@ -1006,9 +1006,9 @@ int handle_rt_signal32(struct ksignal *ksig, sigset_t *oldset,/* Save user registers on the stack */ frame = &rt_sf->uc.uc_mcontext; addr = frame; -if (vdso32_rt_sigtramp && tsk->mm->context.vdso_base) { +if (vdso32_rt_sigtramp && tsk->mm->context.vdso) { sigret =0 ; - tramp = tsk->mm->context.vdso_base + vdso32_rt_sigtramp; + tramp = tsk->mm->context.vdso + vdso32_rt_sigtramp; }else { sigret = __NR_rt_sigreturn; tramp = (unsigned long ) frame->tramp;
@@ -1449,9 +1449,9 @@ int handle_signal32(struct ksignal *ksig, sigset_t *oldset, || __put_user(ksig->sig, &sc->signal)) goto badframe; -if (vdso32_sigtramp && tsk->mm->context.vdso_base) { +if (vdso32_sigtramp && tsk->mm->context.vdso) { sigret =0 ; - tramp = tsk->mm->context.vdso_base + vdso32_sigtramp; + tramp = tsk->mm->context.vdso + vdso32_sigtramp; }else { sigret = __NR_sigreturn; tramp = (unsigned long ) frame->mctx.tramp;
arch/powerpc/kernel/signal_64.c +2 -2
@@ -791,8 +791,8 @@ int handle_rt_signal64(struct ksignal *ksig, sigset_t *set, tsk->thread.fp_state.fpscr =0 ;/* Set up to return from userspace. */ -if (vdso64_rt_sigtramp && tsk->mm->context.vdso_base) { - regs->link = tsk->mm->context.vdso_base + vdso64_rt_sigtramp; +if (vdso64_rt_sigtramp && tsk->mm->context.vdso) { + regs->link = tsk->mm->context.vdso + vdso64_rt_sigtramp; }else { err |=setup_trampoline (__NR_rt_sigreturn, &frame->tramp[0 ]);if (err)
arch/powerpc/kernel/vdso.c +4 -4
@@ -180,7 +180,7 @@ int arch_setup_additional_pages(struct linux_binprm *bprm, int uses_interp) vdso_base =VDSO32_MBASE ;#endif - current->mm->context.vdso_base =0 ; + current->mm->context.vdso =0 ;/* vDSO has a problem and was disabled, just don't "enable" it for the * process
@@ -215,7 +215,7 @@ int arch_setup_additional_pages(struct linux_binprm *bprm, int uses_interp)* install_special_mapping or the perf counter mmap tracking code * will fail to recognise it as a vDSO (since arch_vma_name fails). */ - current->mm->context.vdso_base = vdso_base; + current->mm->context.vdso = vdso_base;/* * our vma flags don't have VM_WRITE so by default, the process isn't
@@ -232,7 +232,7 @@ int arch_setup_additional_pages(struct linux_binprm *bprm, int uses_interp)VM_MAYREAD |VM_MAYWRITE |VM_MAYEXEC , vdso_pagelist);if (rc) { - current->mm->context.vdso_base =0 ; + current->mm->context.vdso =0 ; goto fail_mmapsem; }
@@ -246,7 +246,7 @@ int arch_setup_additional_pages(struct linux_binprm *bprm, int uses_interp)const char *arch_vma_name (struct vm_area_struct *vma) { -if (vma->vm_mm && vma->vm_start == vma->vm_mm->context.vdso_base) +if (vma->vm_mm && vma->vm_start == vma->vm_mm->context.vdso)return "[vdso]" ;return NULL ; }
arch/powerpc/perf/callchain.c +6 -6
@@ -209,8 +209,8 @@ static int is_sigreturn_64_address(unsigned long nip, unsigned long fp) {if (nip == fp + offsetof(struct signal_frame_64 , tramp))return 1 ; -if (vdso64_rt_sigtramp && current->mm->context.vdso_base && - nip == current->mm->context.vdso_base + vdso64_rt_sigtramp) +if (vdso64_rt_sigtramp && current->mm->context.vdso && + nip == current->mm->context.vdso + vdso64_rt_sigtramp)return 1 ;return 0 ; }
@@ -368,8 +368,8 @@ static int is_sigreturn_32_address(unsigned int nip, unsigned int fp) { if (nip == fp + offsetof(struct signal_frame_32, mctx.mc_pad))return 1 ; -if (vdso32_sigtramp && current->mm->context.vdso_base && - nip == current->mm->context.vdso_base + vdso32_sigtramp) +if (vdso32_sigtramp && current->mm->context.vdso && + nip == current->mm->context.vdso + vdso32_sigtramp)return 1 ;return 0 ; }
@@ -379,8 +379,8 @@ static int is_rt_sigreturn_32_address(unsigned int nip, unsigned int fp)if (nip == fp + offsetof(struct rt_signal_frame_32 , uc.uc_mcontext.mc_pad))return 1 ; -if (vdso32_rt_sigtramp && current->mm->context.vdso_base && - nip == current->mm->context.vdso_base + vdso32_rt_sigtramp) +if (vdso32_rt_sigtramp && current->mm->context.vdso && + nip == current->mm->context.vdso + vdso32_rt_sigtramp)return 1 ;return 0 ; }
Signature · 9 lines
Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [RFC v2 5/7] powerpc: Rename context.vdso_base to context.vdso
Quoted 15 lines · Christopher Covington
Checkpoint/Restore In Userspace (CRIU) needs to be able to unmap and remap the VDSO to successfully checkpoint and restore applications in the face of changing VDSO addresses due to Address Space Layout Randomization (ASLR, randmaps). x86 and PowerPC have had architecture-specific code to support this. In order to expand the architectures that support this without unnecessary duplication of code, a generic version based on the PowerPC code was created. It differs slightly, based on the results of an informal survey of all architectures that indicated
unsigned long vdso;is popular (and it's also concise). Therefore, change the variable name in powerpc from
mm->context.vdso_basetomm->context.vdso.Signed-off-by Christopher Covington <[email protected]>
Quoted 16 lines
--- arch/powerpc/include/asm/book3s/32/mmu-hash.h | 2 +- arch/powerpc/include/asm/book3s/64/mmu.h | 2 +- arch/powerpc/include/asm/mm-arch-hooks.h | 6 +++--- arch/powerpc/include/asm/mmu-40x.h | 2 +- arch/powerpc/include/asm/mmu-44x.h | 2 +- arch/powerpc/include/asm/mmu-8xx.h | 2 +- arch/powerpc/include/asm/mmu-book3e.h | 2 +- arch/powerpc/include/asm/mmu_context.h | 4 ++-- arch/powerpc/include/asm/vdso.h | 2 +- arch/powerpc/include/uapi/asm/elf.h | 2 +- arch/powerpc/kernel/signal_32.c | 8 ++++---- arch/powerpc/kernel/signal_64.c | 4 ++-- arch/powerpc/kernel/vdso.c | 8 ++++---- arch/powerpc/perf/callchain.c | 12 ++++++------ 14 files changed, 29 insertions(+), 29 deletions(-)
This is kind of annoying, but I guess it's worth doing.
It's going to conflict like hell though. Who were you thinking would merge this series? I think it should go via Andrew Morton's tree, as that way if we get bad conflicts we can pull it out and redo it.
Assuming we agree on that I'm happy to ack it:
cheers
Re: [RFC v2 5/7] powerpc: Rename context.vdso_base to context.vdso
[fixing akpm's email address]
Quoted 34 lines · Michael Ellerman
Quoted 15 lines · Christopher Covington
Checkpoint/Restore In Userspace (CRIU) needs to be able to unmap and remap the VDSO to successfully checkpoint and restore applications in the face of changing VDSO addresses due to Address Space Layout Randomization (ASLR, randmaps). x86 and PowerPC have had architecture-specific code to support this. In order to expand the architectures that support this without unnecessary duplication of code, a generic version based on the PowerPC code was created. It differs slightly, based on the results of an informal survey of all architectures that indicated
unsigned long vdso;is popular (and it's also concise). Therefore, change the variable name in powerpc from
mm->context.vdso_basetomm->context.vdso.Signed-off-by Christopher Covington <[email protected]>Quoted 16 lines
--- arch/powerpc/include/asm/book3s/32/mmu-hash.h | 2 +- arch/powerpc/include/asm/book3s/64/mmu.h | 2 +- arch/powerpc/include/asm/mm-arch-hooks.h | 6 +++--- arch/powerpc/include/asm/mmu-40x.h | 2 +- arch/powerpc/include/asm/mmu-44x.h | 2 +- arch/powerpc/include/asm/mmu-8xx.h | 2 +- arch/powerpc/include/asm/mmu-book3e.h | 2 +- arch/powerpc/include/asm/mmu_context.h | 4 ++-- arch/powerpc/include/asm/vdso.h | 2 +- arch/powerpc/include/uapi/asm/elf.h | 2 +- arch/powerpc/kernel/signal_32.c | 8 ++++---- arch/powerpc/kernel/signal_64.c | 4 ++-- arch/powerpc/kernel/vdso.c | 8 ++++---- arch/powerpc/perf/callchain.c | 12 ++++++------ 14 files changed, 29 insertions(+), 29 deletions(-)
Quoted 5 lines
This is kind of annoying, but I guess it's worth doing.
It's going to conflict like hell though. Who were you thinking would merge this series? I think it should go via Andrew Morton's tree, as that way if we get bad conflicts we can pull it out and redo it.
The other thing you can do is generate the patch towards the end of the merge window and send it as a separate pull request. The disadvantage of that is that it can't spend any time in -next, but that might be ok for a mechanical rename.
Will
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Michael Ellerman
reviewerRe: [RFC v2 5/7] powerpc: Rename context.vdso_base to context.vdso
Quoted 20 lines · Will Deacon
Quoted 19 lines · Michael Ellerman
Quoted 7 lines · Christopher Covington
arch/powerpc/include/asm/book3s/32/mmu-hash.h | 2 +- arch/powerpc/include/asm/book3s/64/mmu.h | 2 +- arch/powerpc/include/asm/mm-arch-hooks.h | 6 +++--- arch/powerpc/include/asm/mmu-40x.h | 2 +- arch/powerpc/include/asm/mmu-44x.h | 2 +- arch/powerpc/include/asm/mmu-8xx.h | 2 +- arch/powerpc/include/asm/mmu-book3e.h | 2 +-Quoted 8 lines
arch/powerpc/include/asm/mmu_context.h | 4 ++-- arch/powerpc/include/asm/vdso.h | 2 +- arch/powerpc/include/uapi/asm/elf.h | 2 +- arch/powerpc/kernel/signal_32.c | 8 ++++---- arch/powerpc/kernel/signal_64.c | 4 ++-- arch/powerpc/kernel/vdso.c | 8 ++++---- arch/powerpc/perf/callchain.c | 12 ++++++------ 14 files changed, 29 insertions(+), 29 deletions(-)This is kind of annoying, but I guess it's worth doing.
Quoted 8 lines
Quoted 3 lines
It's going to conflict like hell though. Who were you thinking would merge this series? I think it should go via Andrew Morton's tree, as that way if we get bad conflicts we can pull it out and redo it.
The other thing you can do is generate the patch towards the end of the merge window and send it as a separate pull request. The disadvantage of that is that it can't spend any time in -next, but that might be ok for a mechanical rename.
True. Though in this case it's a mechanical rename that then allows us to use the generic code, so I'd prefer we had some -next coverage on the latter.
The other other option would be to wrap all uses of the arch value in a macro (or actually two probably, one a getter one a setter). That would then allow arches to use the generic code regardless of the name and type of their mm->context.vdso_whatever.
That would allow the basic series to go in, and then each arch could do a series later that switches it to the "standard" name and type.
cheers
RFC v2 6/7 mm/powerpc: Use generic VDSO remap and unmap functions
In reply to Christopher CovingtonThe PowerPC VDSO remap and unmap code was copied to a generic location, only modifying the variable name expected in mm->context (vdso instead of vdso_base) to match most other architectures. Having adopted this generic naming, drop the code in arch/powerpc and use the generic version.
--- arch/powerpc/Kconfig | 1 + arch/powerpc/include/asm/Kbuild | 1 + arch/powerpc/include/asm/mm-arch-hooks.h | 28 ------------------------- arch/powerpc/include/asm/mmu_context.h | 35 +------------------------------- 4 files changed, 3 insertions(+), 62 deletions(-) delete mode 100644 arch/powerpc/include/asm/mm-arch-hooks.h
arch/powerpc/Kconfig +1 -0
@@ -134,6 +134,7 @@ config PPC select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST select GENERIC_STRNCPY_FROM_USER select GENERIC_STRNLEN_USER + select GENERIC_VDSO select HAVE_MOD_ARCH_SPECIFIC select MODULES_USE_ELF_RELA select CLONE_BACKWARDS
arch/powerpc/include/asm/Kbuild +1 -0
@@ -8,3 +8,4 @@ generic-y += mcs_spinlock.h generic-y += preempt.h generic-y += rwsem.h generic-y += vtime.h +generic-y += mm-arch-hooks.h
arch/powerpc/include/asm/mm-arch-hooks.h deleted +0 -28
@@ -1,28 +0,0 @@ -/* -* Architecture specific mm hooks -* -* Copyright (C) 2015, IBM Corporation -* Author: Laurent Dufour <[email protected]> -* -* This program is free software; you can redistribute it and/or modify -* it under the terms of the GNU General Public License version 2 as -* published by the Free Software Foundation. -*/ - -#ifndef _ASM_POWERPC_MM_ARCH_HOOKS_H -#define _ASM_POWERPC_MM_ARCH_HOOKS_H - -static inline void arch_remap (struct mm_struct *mm, -unsigned long old_start,unsigned long old_end, -unsigned long new_start,unsigned long new_end) -{ -/* -* mremap() doesn't allow moving multiple vmas so we can limit the -* check to old_start == vdso. -*/ -if (old_start == mm->context.vdso) - mm->context.vdso = new_start; -} -#define arch_remap arch_remap - -#endif /* _ASM_POWERPC_MM_ARCH_HOOKS_H */
arch/powerpc/include/asm/mmu_context.h +1 -34
@@ -8,6 +8,7 @@#include <linux/spinlock.h> #include <asm/mmu.h> #include <asm/cputable.h> +#include <asm-generic/mm_hooks.h> #include <asm/cputhreads.h> /*
@@ -133,39 +134,5 @@ static inline void enter_lazy_tlb(struct mm_struct *mm,#endif } -static inline void arch_dup_mmap (struct mm_struct *oldmm, -struct mm_struct *mm) -{ -} - -static inline void arch_exit_mmap (struct mm_struct *mm) -{ -} - -static inline void arch_unmap (struct mm_struct *mm, -struct vm_area_struct *vma, -unsigned long start,unsigned long end) -{ -if (start <= mm->context.vdso && mm->context.vdso < end) - mm->context.vdso =0 ; -} - -static inline void arch_bprm_mm_init (struct mm_struct *mm, -struct vm_area_struct *vma) -{ -} - -static inline bool arch_vma_access_permitted (struct vm_area_struct *vma, -bool write,bool execute,bool foreign) -{ -/* by default, allow everything */ -return true; -} - -static inline bool arch_pte_access_permitted (pte_t pte,bool write) -{ -/* by default, allow everything */ -return true; -}#endif /* __KERNEL__ */ #endif /* __ASM_POWERPC_MMU_CONTEXT_H */
Signature · 9 lines
Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Michael Ellerman
reviewerRe: [RFC v2 6/7] mm/powerpc: Use generic VDSO remap and unmap functions
Quoted 5 lines · Christopher Covington
The PowerPC VDSO remap and unmap code was copied to a generic location, only modifying the variable name expected in
mm->context(vdso instead ofvdso_base) to match most other architectures. Having adopted this generic naming, drop the code inarch/powerpcand use the generic version.
Quoted 8 lines
Signed-off-by Christopher Covington <[email protected]>--- arch/powerpc/Kconfig | 1 + arch/powerpc/include/asm/Kbuild | 1 + arch/powerpc/include/asm/mm-arch-hooks.h | 28 ------------------------- arch/powerpc/include/asm/mmu_context.h | 35 +------------------------------- 4 files changed, 3 insertions(+), 62 deletions(-) delete mode 100644 arch/powerpc/include/asm/mm-arch-hooks.h
This looks OK.
Have you tested it on powerpc? I could but I don't know how to actually trigger these paths, I assume I need a CRIU setup?
Can you flip the subject to "powerpc/mm: ...".
cheers
Re: [RFC v2 6/7] mm/powerpc: Use generic VDSO remap and unmap functions
Quoted 16 lines · Michael Ellerman
Quoted 5 lines · Christopher Covington
The PowerPC VDSO remap and unmap code was copied to a generic location, only modifying the variable name expected in
mm->context(vdso instead ofvdso_base) to match most other architectures. Having adopted this generic naming, drop the code inarch/powerpcand use the generic version.Quoted 8 lines
Signed-off-by Christopher Covington <[email protected]>--- arch/powerpc/Kconfig | 1 + arch/powerpc/include/asm/Kbuild | 1 + arch/powerpc/include/asm/mm-arch-hooks.h | 28 ------------------------- arch/powerpc/include/asm/mmu_context.h | 35 +------------------------------- 4 files changed, 3 insertions(+), 62 deletions(-) delete mode 100644 arch/powerpc/include/asm/mm-arch-hooks.h
Quoted 4 lines
This looks OK.
Have you tested it on powerpc? I could but I don't know how to actually trigger these paths, I assume I need a CRIU setup?
FWIW, tested on ppc64le using a sample test process moving its VDSO and then catching a signal on 4.9-rc4 and using CRIU on top of 4.8 with sightly changes to due minor upstream changes.
Re: [RFC v2 6/7] mm/powerpc: Use generic VDSO remap and unmap functions
Quoted 22 lines · Laurent Dufour
Quoted 16 lines · Michael Ellerman
Quoted 5 lines · Christopher Covington
The PowerPC VDSO remap and unmap code was copied to a generic location, only modifying the variable name expected in
mm->context(vdso instead ofvdso_base) to match most other architectures. Having adopted this generic naming, drop the code inarch/powerpcand use the generic version.Quoted 8 lines
Signed-off-by Christopher Covington <[email protected]>--- arch/powerpc/Kconfig | 1 + arch/powerpc/include/asm/Kbuild | 1 + arch/powerpc/include/asm/mm-arch-hooks.h | 28 ------------------------- arch/powerpc/include/asm/mmu_context.h | 35 +------------------------------- 4 files changed, 3 insertions(+), 62 deletions(-) delete mode 100644 arch/powerpc/include/asm/mm-arch-hooks.hQuoted 4 lines
This looks OK.
Have you tested it on powerpc? I could but I don't know how to actually trigger these paths, I assume I need a CRIU setup?
Quoted 6 lines
FWIW, tested on ppc64le using a sample test process moving its VDSO and then catching a signal on 4.9-rc4 and using CRIU on top of 4.8 with sightly changes to due minor upstream changes.
Reviewed-by Laurent Dufour <[email protected]>Tested-by Laurent Dufour <[email protected]>
Thanks, in that case:
cheers
RFC v2 7/7 mm: Remove mm-arch-hooks.h
In reply to Christopher CovingtonThe only use case, VDSO remap support for PowerPC, has been made generic instead of architecture-specific. Since the infrastructure is no longer needed, remove it.
--- arch/alpha/include/asm/Kbuild | 1 - arch/arc/include/asm/Kbuild | 1 - arch/arm/include/asm/Kbuild | 1 - arch/arm64/include/asm/Kbuild | 1 - arch/avr32/include/asm/Kbuild | 1 - arch/blackfin/include/asm/Kbuild | 1 - arch/c6x/include/asm/Kbuild | 1 - arch/cris/include/asm/Kbuild | 1 - arch/frv/include/asm/Kbuild | 1 - arch/h8300/include/asm/Kbuild | 1 - arch/hexagon/include/asm/Kbuild | 1 - arch/ia64/include/asm/Kbuild | 1 - arch/m32r/include/asm/Kbuild | 1 - arch/m68k/include/asm/Kbuild | 1 - arch/metag/include/asm/Kbuild | 1 - arch/microblaze/include/asm/Kbuild | 1 - arch/mips/include/asm/Kbuild | 1 - arch/mn10300/include/asm/Kbuild | 1 - arch/nios2/include/asm/Kbuild | 1 - arch/openrisc/include/asm/Kbuild | 1 - arch/parisc/include/asm/Kbuild | 1 - arch/s390/include/asm/Kbuild | 1 - arch/score/include/asm/Kbuild | 1 - arch/sh/include/asm/Kbuild | 1 - arch/sparc/include/asm/Kbuild | 1 - arch/tile/include/asm/Kbuild | 1 - arch/um/include/asm/Kbuild | 1 - arch/unicore32/include/asm/Kbuild | 1 - arch/x86/include/asm/Kbuild | 1 - arch/xtensa/include/asm/Kbuild | 1 - include/asm-generic/mm_hooks.h | 16 ---------------- mm/mremap.c | 20 +++++++++++++++++--- 32 files changed, 17 insertions(+), 49 deletions(-)
arch/alpha/include/asm/Kbuild +0 -1
@@ -6,7 +6,6 @@ generic-y += exec.h generic-y += export.h generic-y += irq_work.h generic-y += mcs_spinlock.h -generic-y += mm-arch-hooks.h generic-y += preempt.h generic-y += sections.h generic-y += trace_clock.h
arch/arc/include/asm/Kbuild +0 -1
@@ -22,7 +22,6 @@ generic-y += kvm_para.h generic-y += local.h generic-y += local64.h generic-y += mcs_spinlock.h -generic-y += mm-arch-hooks.h generic-y += mman.h generic-y += msgbuf.h generic-y += msi.h
arch/arm/include/asm/Kbuild +0 -1
@@ -15,7 +15,6 @@ generic-y += irq_regs.h generic-y += kdebug.h generic-y += local.h generic-y += local64.h -generic-y += mm-arch-hooks.h generic-y += msgbuf.h generic-y += msi.h generic-y += param.h
arch/arm64/include/asm/Kbuild +0 -1
@@ -20,7 +20,6 @@ generic-y += kvm_para.h generic-y += local.h generic-y += local64.h generic-y += mcs_spinlock.h -generic-y += mm-arch-hooks.h generic-y += mman.h generic-y += msgbuf.h generic-y += msi.h
arch/avr32/include/asm/Kbuild +0 -1
@@ -12,7 +12,6 @@ generic-y += irq_work.h generic-y += local.h generic-y += local64.h generic-y += mcs_spinlock.h -generic-y += mm-arch-hooks.h generic-y += param.h generic-y += percpu.h generic-y += preempt.h
arch/blackfin/include/asm/Kbuild +0 -1
@@ -21,7 +21,6 @@ generic-y += kvm_para.h generic-y += local.h generic-y += local64.h generic-y += mcs_spinlock.h -generic-y += mm-arch-hooks.h generic-y += mman.h generic-y += msgbuf.h generic-y += mutex.h
arch/c6x/include/asm/Kbuild +0 -1
@@ -27,7 +27,6 @@ generic-y += kdebug.h generic-y += kmap_types.h generic-y += local.h generic-y += mcs_spinlock.h -generic-y += mm-arch-hooks.h generic-y += mman.h generic-y += mmu.h generic-y += mmu_context.h
arch/cris/include/asm/Kbuild +0 -1
@@ -24,7 +24,6 @@ generic-y += linkage.h generic-y += local.h generic-y += local64.h generic-y += mcs_spinlock.h -generic-y += mm-arch-hooks.h generic-y += mman.h generic-y += module.h generic-y += msgbuf.h
arch/frv/include/asm/Kbuild +0 -1
@@ -4,7 +4,6 @@ generic-y += cputime.h generic-y += exec.h generic-y += irq_work.h generic-y += mcs_spinlock.h -generic-y += mm-arch-hooks.h generic-y += preempt.h generic-y += trace_clock.h generic-y += word-at-a-time.h
arch/h8300/include/asm/Kbuild +0 -1
@@ -33,7 +33,6 @@ generic-y += linkage.h generic-y += local.h generic-y += local64.h generic-y += mcs_spinlock.h -generic-y += mm-arch-hooks.h generic-y += mman.h generic-y += mmu.h generic-y += mmu_context.h
arch/hexagon/include/asm/Kbuild +0 -1
@@ -28,7 +28,6 @@ generic-y += kmap_types.h generic-y += local.h generic-y += local64.h generic-y += mcs_spinlock.h -generic-y += mm-arch-hooks.h generic-y += mman.h generic-y += msgbuf.h generic-y += pci.h
arch/ia64/include/asm/Kbuild +0 -1
@@ -4,7 +4,6 @@ generic-y += exec.h generic-y += irq_work.h generic-y += kvm_para.h generic-y += mcs_spinlock.h -generic-y += mm-arch-hooks.h generic-y += preempt.h generic-y += trace_clock.h generic-y += vtime.h
arch/m32r/include/asm/Kbuild +0 -1
@@ -5,7 +5,6 @@ generic-y += exec.h generic-y += irq_work.h generic-y += kvm_para.h generic-y += mcs_spinlock.h -generic-y += mm-arch-hooks.h generic-y += module.h generic-y += preempt.h generic-y += sections.h
arch/m68k/include/asm/Kbuild +0 -1
@@ -18,7 +18,6 @@ generic-y += kvm_para.h generic-y += local.h generic-y += local64.h generic-y += mcs_spinlock.h -generic-y += mm-arch-hooks.h generic-y += mman.h generic-y += mutex.h generic-y += percpu.h
arch/metag/include/asm/Kbuild +0 -1
@@ -25,7 +25,6 @@ generic-y += kvm_para.h generic-y += local.h generic-y += local64.h generic-y += mcs_spinlock.h -generic-y += mm-arch-hooks.h generic-y += msgbuf.h generic-y += mutex.h generic-y += param.h
arch/microblaze/include/asm/Kbuild +0 -1
@@ -6,7 +6,6 @@ generic-y += device.h generic-y += exec.h generic-y += irq_work.h generic-y += mcs_spinlock.h -generic-y += mm-arch-hooks.h generic-y += preempt.h generic-y += syscalls.h generic-y += trace_clock.h
arch/mips/include/asm/Kbuild +0 -1
@@ -8,7 +8,6 @@ generic-y += emergency-restart.h generic-y += irq_work.h generic-y += local64.h generic-y += mcs_spinlock.h -generic-y += mm-arch-hooks.h generic-y += mutex.h generic-y += parport.h generic-y += percpu.h
arch/mn10300/include/asm/Kbuild +0 -1
@@ -5,7 +5,6 @@ generic-y += cputime.h generic-y += exec.h generic-y += irq_work.h generic-y += mcs_spinlock.h -generic-y += mm-arch-hooks.h generic-y += preempt.h generic-y += sections.h generic-y += trace_clock.h
arch/nios2/include/asm/Kbuild +0 -1
@@ -30,7 +30,6 @@ generic-y += kmap_types.h generic-y += kvm_para.h generic-y += local.h generic-y += mcs_spinlock.h -generic-y += mm-arch-hooks.h generic-y += mman.h generic-y += module.h generic-y += msgbuf.h
arch/openrisc/include/asm/Kbuild +0 -1
@@ -36,7 +36,6 @@ generic-y += kmap_types.h generic-y += kvm_para.h generic-y += local.h generic-y += mcs_spinlock.h -generic-y += mm-arch-hooks.h generic-y += mman.h generic-y += module.h generic-y += msgbuf.h
arch/parisc/include/asm/Kbuild +0 -1
@@ -15,7 +15,6 @@ generic-y += kvm_para.h generic-y += local.h generic-y += local64.h generic-y += mcs_spinlock.h -generic-y += mm-arch-hooks.h generic-y += mutex.h generic-y += param.h generic-y += percpu.h
arch/s390/include/asm/Kbuild +0 -1
@@ -4,7 +4,6 @@ generic-y += clkdev.h generic-y += export.h generic-y += irq_work.h generic-y += mcs_spinlock.h -generic-y += mm-arch-hooks.h generic-y += preempt.h generic-y += trace_clock.h generic-y += word-at-a-time.h
arch/score/include/asm/Kbuild +0 -1
@@ -7,7 +7,6 @@ generic-y += clkdev.h generic-y += cputime.h generic-y += irq_work.h generic-y += mcs_spinlock.h -generic-y += mm-arch-hooks.h generic-y += preempt.h generic-y += sections.h generic-y += trace_clock.h
arch/sh/include/asm/Kbuild +0 -1
@@ -17,7 +17,6 @@ generic-y += kvm_para.h generic-y += local.h generic-y += local64.h generic-y += mcs_spinlock.h -generic-y += mm-arch-hooks.h generic-y += mman.h generic-y += msgbuf.h generic-y += param.h
arch/sparc/include/asm/Kbuild +0 -1
@@ -13,7 +13,6 @@ generic-y += linkage.h generic-y += local.h generic-y += local64.h generic-y += mcs_spinlock.h -generic-y += mm-arch-hooks.h generic-y += module.h generic-y += mutex.h generic-y += preempt.h
arch/tile/include/asm/Kbuild +0 -1
@@ -19,7 +19,6 @@ generic-y += irq_regs.h generic-y += local.h generic-y += local64.h generic-y += mcs_spinlock.h -generic-y += mm-arch-hooks.h generic-y += msgbuf.h generic-y += mutex.h generic-y += param.h
arch/um/include/asm/Kbuild +0 -1
@@ -16,7 +16,6 @@ generic-y += irq_regs.h generic-y += irq_work.h generic-y += kdebug.h generic-y += mcs_spinlock.h -generic-y += mm-arch-hooks.h generic-y += mutex.h generic-y += param.h generic-y += pci.h
arch/unicore32/include/asm/Kbuild +0 -1
@@ -26,7 +26,6 @@ generic-y += kdebug.h generic-y += kmap_types.h generic-y += local.h generic-y += mcs_spinlock.h -generic-y += mm-arch-hooks.h generic-y += mman.h generic-y += module.h generic-y += msgbuf.h
arch/x86/include/asm/Kbuild +0 -1
@@ -15,4 +15,3 @@ generic-y += cputime.h generic-y += dma-contiguous.h generic-y += early_ioremap.h generic-y += mcs_spinlock.h -generic-y += mm-arch-hooks.h
arch/xtensa/include/asm/Kbuild +0 -1
@@ -18,7 +18,6 @@ generic-y += linkage.h generic-y += local.h generic-y += local64.h generic-y += mcs_spinlock.h -generic-y += mm-arch-hooks.h generic-y += percpu.h generic-y += preempt.h generic-y += resource.h
include/asm-generic/mm_hooks.h +0 -16
@@ -3,7 +3,6 @@* included in asm-FOO/mmu_context.h for any arch FOO which doesn't need to * specially hook these. * -* arch_remap originally from include/linux-mm-arch-hooks.h * arch_unmap originally from arch/powerpc/include/asm/mmu_context.h * Copyright (C) 2015, IBM Corporation * Author: Laurent Dufour <[email protected]>
@@ -35,21 +34,6 @@ static inline void arch_unmap(struct mm_struct *mm,#endif /* CONFIG_GENERIC_VDSO */ } -static inline void arch_remap (struct mm_struct *mm, -unsigned long old_start,unsigned long old_end, -unsigned long new_start,unsigned long new_end) -{ -#ifdef CONFIG_GENERIC_VDSO -/* -* mremap() doesn't allow moving multiple vmas so we can limit the -* check to old_addr == vdso. -*/ -if (old_addr == mm->context.vdso) - mm->context.vdso = new_addr; - -#endif /* CONFIG_GENERIC_VDSO */ -} -static inline void arch_bprm_mm_init (struct mm_struct *mm,struct vm_area_struct *vma) {
mm/mremap.c +17 -3
@@ -5,6 +5,14 @@* * Address space accounting code <[email protected]> * (C) Copyright 2002 Red Hat Inc, All Rights Reserved +* +* arch_remap originally from include/linux-mm-arch-hooks.h +* Copyright (C) 2015, IBM Corporation +* Author: Laurent Dufour <[email protected]> +* +* This program is free software; you can redistribute it and/or modify +* it under the terms of the GNU General Public License version 2 as +* published by the Free Software Foundation. */ #include <linux/mm.h>
@@ -21,7 +29,6 @@#include <linux/syscalls.h> #include <linux/mmu_notifier.h> #include <linux/uaccess.h> -#include <linux/mm-arch-hooks.h> #include <asm/cacheflush.h> #include <asm/tlbflush.h>
@@ -293,8 +300,15 @@ static unsigned long move_vma(struct vm_area_struct *vma, old_addr = new_addr; new_addr = err; }else { -arch_remap (mm, old_addr, old_addr + old_len, - new_addr, new_addr + new_len); +#ifdef CONFIG_GENERIC_VDSO +/* +* mremap() doesn't allow moving multiple vmas so we can limit +* the check to old_addr == vdso. +*/ +if (old_addr == mm->context.vdso) + mm->context.vdso = new_addr; + +#endif /* CONFIG_GENERIC_VDSO */ }/* Conceal VM_ACCOUNT so old reservation is not undone */
Signature · 9 lines
Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Hi Christopher,
by this moment I got another patch for this. I hope, you don't mind
if I send it concurrently. I haven't sent it yet as I was testing it in qemu.
Thanks,
Dmitry
Quoted 5 lines · Dmitry Safonov
Hi Christopher,
by this moment I got another patch for this. I hope, you don't mind
if I send it concurrently. I haven't sent it yet as I was testing it in qemu.
Please do, that'd be great.
Thanks,
Cov
Signature · 4 lines
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. Sent from my Snapdragon powered Android device with K-9 Mail. Please excuse my brevity.