Skip to contentSkip to conversation

dmaengine: mmp_tdma: Select GENERIC_ALLOCATOR

PATCH In review Borislav Petkov 2 participants 2 messages Nov 3, 2016 – Nov 14, 2016 dmaengine

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dmaengine: mmp_tdma: Select GENERIC_ALLOCATOR

From: Borislav Petkov <[email protected]>

as the driver needs it. Build error caught with a randconfig build:

drivers/built-in.o: In function `mmp_tdma_prep_dma_cyclic':
mmp_tdma.c:(.text+0x1612d9): undefined reference to gen_pool_dma_alloc' drivers/built-in.o: In function mmp_tdma_free_chan_resources':
mmp_tdma.c:(.text+0x161444): undefined reference to gen_pool_free' drivers/built-in.o: In function mmp_tdma_probe':
mmp_tdma.c:(.text+0x1616ac): undefined reference to `of_gen_pool_get'
make: *** [vmlinux] Error 1

---
 drivers/dma/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/dma/Kconfig +1 -0
index af63a6bcf564..e88a6ef03dcf 100644
@@ -304,6 +304,7 @@ config MMP_PDMA
 config MMP_TDMA
 	bool "MMP Two-Channel DMA support"
 	depends on ARCH_MMP || COMPILE_TEST
+	select GENERIC_ALLOCATOR
 	select DMA_ENGINE
 	select MMP_SRAM if ARCH_MMP
 	help
Signature · 1 line
2.10.0
#1 lore raw
Quoted 3 lines · Borislav Petkov

From: Borislav Petkov <[email protected]>

as the driver needs it. Build error caught with a randconfig build:

Already fixed by commit d6619761068cf573cae406f176d00b82a39a37fc :(dmaengine: mmp_tdma: add missing select GENERIC_ALLOCATOR in Kconfig)

You should see this in linux-next

Signature · 1 line
~Vinod