Skip to contentSkip to conversation

gstreamer1.0-plugins-bad_%.bbappend: Set PACKAGECONFIG_GL for RPi

PATCH Applied Khem Raj 3 participants 6 messages Nov 3, 2016 – Nov 8, 2016

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH v2 1/1 gstreamer1.0-plugins-bad_%.bbappend: Set PACKAGECONFIG_GL for RPi

Enable dispmanx support if using bcm driver

---
Changes from V1->V2:
- Remove spurious "
- Rearrange code
- Remove duplicate packageconfig for dispmanx

 .../gstreamer/gstreamer1.0-plugins-bad_%.bbappend          | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)
recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend +12 -2
index ab0280e..7292f90 100644
@@ -1,2 +1,12 @@
-EXTRA_OECONF_append_rpi = " CPPFLAGS='-I${STAGING_DIR_TARGET}/usr/include/interface/vcos/pthreads \
-                                   -I${STAGING_DIR_TARGET}/usr/include/interface/vmcs_host/linux'"
+EXTRA_OECONF_append_rpi = " CPPFLAGS='-I${STAGING_INCDIR}/interface/vcos/pthreads \
+                                   -I${STAGING_INCDIR}/interface/vmcs_host/linux'"
+
+# if using bcm driver enable dispmanx not when using VC4 driver
+
+PACKAGECONFIG_append_rpi = "${@bb.utils.contains('MACHINE_FEATURES', 'vc4graphics', '', ' dispmanx', d)}"
+
+PACKAGECONFIG_GL_rpi = "egl gles2"
+
+PACKAGECONFIG_append_rpi = " hls libmms faad"
+
+PACKAGECONFIG[dispmanx] = "--enable-dispmanx,--disable-dispmanx,userland"
Signature · 1 line
2.10.2
#1 lore raw

Hi Khem,

I just tried to rebuild gstreamer1.0-plugins-bad from a clean checkout with your patch.

At first glance, it's working.

"bitbake gstreamer1.0-plugins-bad" succeeded but with a QA Warning:

gstreamer1.0-plugins-bad-1.8.3-r0 do_configure: QA Issue: gstreamer1.0-plugins-bad: invalid PACKAGECONFIG: "dispmanx [invalid-packageconfig]

Karim

________________________________
De : [email protected] <[email protected]> de la part de Khem Raj <[email protected]> Envoyé : jeudi 3 novembre 2016 21:57
À : [email protected]
Objet : [yocto] [meta-raspberrypi][PATCH V2] gstreamer1.0-plugins-bad_%.bbappend: Set PACKAGECONFIG_GL for RPi

Enable dispmanx support if using bcm driver

---
Changes from V1->V2:
- Remove spurious "
- Rearrange code
- Remove duplicate packageconfig for dispmanx

 .../gstreamer/gstreamer1.0-plugins-bad_%.bbappend          | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)
recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend +12 -2
index ab0280e..7292f90 100644
@@ -1,2 +1,12 @@
-EXTRA_OECONF_append_rpi = " CPPFLAGS='-I${STAGING_DIR_TARGET}/usr/include/interface/vcos/pthreads \
-                                   -I${STAGING_DIR_TARGET}/usr/include/interface/vmcs_host/linux'"
+EXTRA_OECONF_append_rpi = " CPPFLAGS='-I${STAGING_INCDIR}/interface/vcos/pthreads \
+                                   -I${STAGING_INCDIR}/interface/vmcs_host/linux'"
+
+# if using bcm driver enable dispmanx not when using VC4 driver
+
+PACKAGECONFIG_append_rpi = "${@bb.utils.contains('MACHINE_FEATURES', 'vc4graphics', '', ' dispmanx', d)}"
+
+PACKAGECONFIG_GL_rpi = "egl gles2"
+
+PACKAGECONFIG_append_rpi = " hls libmms faad"
+
+PACKAGECONFIG[dispmanx] = "--enable-dispmanx,--disable-dispmanx,userland"

--
2.10.2

--
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto
yocto Info Page<https://lists.yoctoproject.org/listinfo/yocto>
lists.yoctoproject.org
Discussion of all things about the Yocto Project. Read our Community Guidelines or learn more about how to participate in other community discussions.

author
#2 lore raw

here is reworked patch
https://github.com/kraj/meta-raspberrypi/commit/468e28084a4d41e71fc0fde53b43033cd19ef9d5.patch <https://github.com/kraj/meta-raspberrypi/commit/468e28084a4d41e71fc0fde53b43033cd19ef9d5.patch>

try it again

Quoted 62 lines · Karim ATIKI

Hi Khem,

I just tried to rebuild gstreamer1.0-plugins-bad from a clean checkout with your patch. At first glance, it's working.

"bitbake gstreamer1.0-plugins-bad" succeeded but with a QA Warning:

gstreamer1.0-plugins-bad-1.8.3-r0 do_configure: QA Issue: gstreamer1.0-plugins-bad: invalid PACKAGECONFIG: "dispmanx [invalid-packageconfig]

Karim

De : [email protected] <mailto:[email protected]> <[email protected] <mailto:[email protected]>> de la part de Khem Raj <[email protected] <mailto:[email protected]>> Envoyé : jeudi 3 novembre 2016 21:57
À : [email protected] <mailto:[email protected]>
Objet : [yocto] [meta-raspberrypi][PATCH V2] gstreamer1.0-plugins-bad_%.bbappend: Set PACKAGECONFIG_GL for RPi

Enable dispmanx support if using bcm driver

Signed-off-by Khem Raj <[email protected] <mailto:[email protected]>>

---
Changes from V1->V2:
- Remove spurious "
- Rearrange code
- Remove duplicate packageconfig for dispmanx

 .../gstreamer/gstreamer1.0-plugins-bad_%.bbappend          | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)
recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend +12 -3
index ab0280e..7292f90 100644
@@ -1,2 +1,12 @@
-EXTRA_OECONF_append_rpi = " CPPFLAGS='-I${STAGING_DIR_TARGET}/usr/include/interface/vcos/pthreads \
-                                   -I${STAGING_DIR_TARGET}/usr/include/interface/vmcs_host/linux'"
+EXTRA_OECONF_append_rpi = " CPPFLAGS='-I${STAGING_INCDIR}/interface/vcos/pthreads \
+                                   -I${STAGING_INCDIR}/interface/vmcs_host/linux'"
+
+# if using bcm driver enable dispmanx not when using VC4 driver
+
+PACKAGECONFIG_append_rpi = "${@bb.utils.contains('MACHINE_FEATURES', 'vc4graphics', '', ' dispmanx', d)}"
+
+PACKAGECONFIG_GL_rpi = "egl gles2"
+
+PACKAGECONFIG_append_rpi = " hls libmms faad"
+
+PACKAGECONFIG[dispmanx] = "--enable-dispmanx,--disable-dispmanx,userland"
--

2.10.2

--
_______________________________________________
yocto mailing list
[email protected] <mailto:[email protected]>
https://lists.yoctoproject.org/listinfo/yocto <https://lists.yoctoproject.org/listinfo/yocto>
yocto Info Page <https://lists.yoctoproject.org/listinfo/yocto>
lists.yoctoproject.org <http://lists.yoctoproject.org/>
Discussion of all things about the Yocto Project. Read our Community Guidelines or learn more about how to participate in other community discussions.

#3 lore raw

Khem,

It worked successfuly.

No errors, no warnings.

Cheers,

Karim

________________________________
De : Khem Raj <[email protected]>
Envoyé : jeudi 3 novembre 2016 22:44
À : Karim ATIKI
Cc : [email protected]
Objet : Re: [yocto] [meta-raspberrypi][PATCH V2] gstreamer1.0-plugins-bad_%.bbappend: Set PACKAGECONFIG_GL for RPi

here is reworked patch
https://github.com/kraj/meta-raspberrypi/commit/468e28084a4d41e71fc0fde53b43033cd19ef9d5.patch

try it again

On Nov 3, 2016, at 2:27 PM, Karim ATIKI <[email protected]<mailto:[email protected]>> wrote:

Hi Khem,

I just tried to rebuild gstreamer1.0-plugins-bad from a clean checkout with your patch. At first glance, it's working.

"bitbake gstreamer1.0-plugins-bad" succeeded but with a QA Warning:

gstreamer1.0-plugins-bad-1.8.3-r0 do_configure: QA Issue: gstreamer1.0-plugins-bad: invalid PACKAGECONFIG: "dispmanx [invalid-packageconfig]

Karim

________________________________
De : [email protected]<mailto:[email protected]> <[email protected]<mailto:[email protected]>> de la part de Khem Raj <[email protected]<mailto:[email protected]>> Envoyé : jeudi 3 novembre 2016 21:57
À : [email protected]<mailto:[email protected]>
Objet : [yocto] [meta-raspberrypi][PATCH V2] gstreamer1.0-plugins-bad_%.bbappend: Set PACKAGECONFIG_GL for RPi

Enable dispmanx support if using bcm driver

---
Changes from V1->V2:
- Remove spurious "
- Rearrange code
- Remove duplicate packageconfig for dispmanx

 .../gstreamer/gstreamer1.0-plugins-bad_%.bbappend          | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)
recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend +12 -2
index ab0280e..7292f90 100644
@@ -1,2 +1,12 @@
-EXTRA_OECONF_append_rpi = " CPPFLAGS='-I${STAGING_DIR_TARGET}/usr/include/interface/vcos/pthreads \
-                                   -I${STAGING_DIR_TARGET}/usr/include/interface/vmcs_host/linux'"
+EXTRA_OECONF_append_rpi = " CPPFLAGS='-I${STAGING_INCDIR}/interface/vcos/pthreads \
+                                   -I${STAGING_INCDIR}/interface/vmcs_host/linux'"
+
+# if using bcm driver enable dispmanx not when using VC4 driver
+
+PACKAGECONFIG_append_rpi = "${@bb.utils.contains('MACHINE_FEATURES', 'vc4graphics', '', ' dispmanx', d)}"
+
+PACKAGECONFIG_GL_rpi = "egl gles2"
+
+PACKAGECONFIG_append_rpi = " hls libmms faad"
+
+PACKAGECONFIG[dispmanx] = "--enable-dispmanx,--disable-dispmanx,userland"

--
2.10.2

--
_______________________________________________
yocto mailing list
[email protected]<mailto:[email protected]>
https://lists.yoctoproject.org/listinfo/yocto
yocto Info Page<https://lists.yoctoproject.org/listinfo/yocto>
lists.yoctoproject.org<http://lists.yoctoproject.org/>
Discussion of all things about the Yocto Project. Read our Community Guidelines or learn more about how to participate in other community discussions.

author
#4 lore raw

thx

Quoted 105 lines · Karim ATIKI

Khem,

It worked successfuly.

No errors, no warnings.

Cheers,

Karim

------------------------------
*De :* Khem Raj <[email protected]>
*Envoyé :* jeudi 3 novembre 2016 22:44
*À :* Karim ATIKI
*Cc :* [email protected]
*Objet :* Re: [yocto] [meta-raspberrypi][PATCH V2] gstreamer1.0-plugins-bad_%.bbappend: Set PACKAGECONFIG_GL for RPi

here is reworked patch
https://github.com/kraj/meta-raspberrypi/commit/
468e28084a4d41e71fc0fde53b43033cd19ef9d5.patch

try it again

On Nov 3, 2016, at 2:27 PM, Karim ATIKI <[email protected]> wrote:

Hi Khem,

I just tried to rebuild gstreamer1.0-plugins-bad from a clean checkout with your patch.
At first glance, it's working.

"bitbake gstreamer1.0-plugins-bad" succeeded but with a QA Warning:

gstreamer1.0-plugins-bad-1.8.3-r0 do_configure: QA Issue:
gstreamer1.0-plugins-bad: invalid PACKAGECONFIG: "dispmanx [invalid-packageconfig]

Karim

------------------------------
*De :* [email protected] <[email protected]> de la part de Khem Raj <[email protected]>
*Envoyé :* jeudi 3 novembre 2016 21:57
*À :* [email protected]
*Objet :* [yocto] [meta-raspberrypi][PATCH V2] gstreamer1.0-plugins-bad_%.bbappend:
Set PACKAGECONFIG_GL for RPi

Enable dispmanx support if using bcm driver

---
Changes from V1->V2:
- Remove spurious "
- Rearrange code
- Remove duplicate packageconfig for dispmanx

 .../gstreamer/gstreamer1.0-plugins-bad_%.bbappend          | 14
++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)
recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend +0 -2
index ab0280e..7292f90 100644
@@ -1,2 +1,12 @@
-EXTRA_OECONF_append_rpi = " CPPFLAGS='-I${STAGING_DIR_
 TARGET}/usr/include/interface/vcos/pthreads \
-                                   -I${STAGING_DIR_TARGET}/usr/

include/interface/vmcs_host/linux'"
+EXTRA_OECONF_append_rpi = " CPPFLAGS='-I${STAGING_INCDIR}/interface/vcos/pthreads \
+ -I${STAGING_INCDIR}/interface/
vmcs_host/linux'"

recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend +4 -0
+
+# if using bcm driver enable dispmanx not when using VC4 driver
+
+PACKAGECONFIG_append_rpi = "${@bb.utils.contains('MACHINE_FEATURES',

'vc4graphics', '', ' dispmanx', d)}"

recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend +6 -1
+
+PACKAGECONFIG_GL_rpi = "egl gles2"
+
+PACKAGECONFIG_append_rpi = " hls libmms faad"
+
+PACKAGECONFIG[dispmanx] = "--enable-dispmanx,--disable-dispmanx,userland"
--

2.10.2

--
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto
yocto Info Page <https://lists.yoctoproject.org/listinfo/yocto>
lists.yoctoproject.org
Discussion of all things about the Yocto Project. Read our Community Guidelines or learn more about how to participate in other community discussions.

#5 lore raw
In reply to Khem Raj
Quoted 34 lines · Khem Raj

Enable dispmanx support if using bcm driver

---
Changes from V1->V2:
- Remove spurious "
- Rearrange code
- Remove duplicate packageconfig for dispmanx

 .../gstreamer/gstreamer1.0-plugins-bad_%.bbappend          | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)
recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend +12 -3
index ab0280e..7292f90 100644
@@ -1,2 +1,12 @@
-EXTRA_OECONF_append_rpi = " CPPFLAGS='-I${STAGING_DIR_TARGET}/usr/include/interface/vcos/pthreads \
-                                   -I${STAGING_DIR_TARGET}/usr/include/interface/vmcs_host/linux'"
+EXTRA_OECONF_append_rpi = " CPPFLAGS='-I${STAGING_INCDIR}/interface/vcos/pthreads \
+                                   -I${STAGING_INCDIR}/interface/vmcs_host/linux'"
+
+# if using bcm driver enable dispmanx not when using VC4 driver
+
+PACKAGECONFIG_append_rpi = "${@bb.utils.contains('MACHINE_FEATURES', 'vc4graphics', '', ' dispmanx', d)}"
+
+PACKAGECONFIG_GL_rpi = "egl gles2"
+
+PACKAGECONFIG_append_rpi = " hls libmms faad"
+
+PACKAGECONFIG[dispmanx] = "--enable-dispmanx,--disable-dispmanx,userland"
--

2.10.2

Quoted 5 lines

--
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto

Merged to master. Thanks.

--
Andrei Gherzan