kodi: allow enablement of libamcodec as codec if selected
PATCH v6 1/1 kodi: allow enablement of libamcodec as codec if selected
allow usage of amcodec if kodi is built and libamcodec is selected
---
v5 -> v6:
- simplify patch so it will fit kodi 17 too (Thomas Petazzoni)
- allow multiple codecs enabled.
v4 -> v5:
- add description and signed off to the kodi patch. (Thomas Petazzoni).
v3 -> v4:
- properly define the includes for amcodec when cross compiling.
v2 -> v3:
- fix change after kodi.mk was changed.
v1 -> v2:
- fixed mail title and comment
package/kodi/kodi.mk | 6 ++++++ 1 file changed, 6 insertions(+)
package/kodi/kodi.mk +6 -0
@@ -113,6 +113,12 @@ KODI_DEPENDENCIES += imx-vpuwrap KODI_CONF_OPTS += --enable-codec=imxvpu endif +ifeq ($(BR2_PACKAGE_LIBAMCODEC),y) +KODI_DEPENDENCIES += libamcodec +KODI_CONF_OPTS += --enable-codec=amcodec +KODI_CONF_ENV += INCLUDES="-I$(STAGING_DIR)/usr/include/amcodec" +endif + ifeq ($(BR2_PACKAGE_LIBCAP),y) KODI_CONF_OPTS += --enable-libcap KODI_DEPENDENCIES += libcap
Signature · 1 line
2.10.2
PATCH v6 1/1 kodi: allow enablement of libamcodec as codec if selected
Hello,
package/kodi/kodi.mk KODI_DEPENDENCIES += imx-vpuwrap · line 120
Quoted 13 lines · Dagg Stompler
package/kodi/kodi.mk +5
-0@@ -113,6 +113,12 @@ KODI_DEPENDENCIES += imx-vpuwrap KODI_CONF_OPTS += --enable-codec=imxvpu endif +ifeq ($(BR2_PACKAGE_LIBAMCODEC),y) +KODI_DEPENDENCIES += libamcodec +KODI_CONF_OPTS += --enable-codec=amcodec +KODI_CONF_ENV += INCLUDES="-I$(STAGING_DIR)/usr/include/amcodec" +endif
This is not good for two reasons:
1. Because the Kodi Makefile for amcodec currently does -I$(prefix)/include, which will be detected by our paranoid wrapper as a bogus path because -I/usr/include is incorrect when cross-compiling.
2. Because there are now two conditions that pass a INCLUDES= value in KODI_CONF_ENV, overwriting each other. Even if in practice they are mutually exclusive (you won't build amcodec support and RPi support in the same build), it is still dangerous.
Both of those problems were fixed by my proposal in your reply to your PATCHv5, but for some reason you decided to not follow this proposal.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH v6 1/1 kodi: allow enablement of libamcodec as codec if selected
Greetings,
Quoted 31 lines
Sent: Saturday, November 05, 2016 at 6:12 PM
From: "Thomas Petazzoni" <[email protected]>
To: "Dagg Stompler" <[email protected]>
Cc: buildroot at buildroot.org
Subject: Re: [Buildroot] [PATCH v6] kodi: allow enablement of libamcodec as codec if selectedHello,
package/kodi/kodi.mk KODI_DEPENDENCIES += imx-vpuwrap · line 120
Quoted 13 lines · Dagg Stompler
package/kodi/kodi.mk +5
-0@@ -113,6 +113,12 @@ KODI_DEPENDENCIES += imx-vpuwrap KODI_CONF_OPTS += --enable-codec=imxvpu endif +ifeq ($(BR2_PACKAGE_LIBAMCODEC),y) +KODI_DEPENDENCIES += libamcodec +KODI_CONF_OPTS += --enable-codec=amcodec +KODI_CONF_ENV += INCLUDES="-I$(STAGING_DIR)/usr/include/amcodec" +endifThis is not good for two reasons:
1. Because the Kodi
Makefilefor amcodec currently does -I$(prefix)/include, which will be detected by our paranoid wrapper as a bogus path because -I/usr/include is incorrect when cross-compiling.
Quoted 7 lines
2. Because there are now two conditions that pass a INCLUDES= value in
KODI_CONF_ENV, overwriting each other. Even if in practice they are mutually exclusive (you won't build amcodec support and RPi support in the same build), it is still dangerous.Both of those problems were fixed by my proposal in your reply to your PATCHv5, but for some reason you decided to not follow this proposal.
I've misread your comments, will reevaluate.
Quoted 13 lines
Best regards,
Thomas
Signature · 7 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot