ARM: DTS: r8a7794: alt: Fix PCF names for DU

PATCH Superseded Jacopo Mondi 3 participants 6 messages Nov 3, 2016 – Nov 7, 2016 Device tree bindings

lore

Share & tools

lore

Jacopo Mondi

author

2016-11-03 13:42 UTC #0 lore raw

PATCH 1/1 ARM: DTS: r8a7794: alt: Fix PCF names for DU

Update the PCF pin groups and function names of DU interface for r8a7794 ALT board.

The currently specified pin groups and function names prevented PCF and DU interfaces from being correctly configured:

sh-pfc e6060000.pin-controller: function 'du' not supported sh-pfc e6060000.pin-controller: invalid function du in map table sh-pfc e6060000.pin-controller: function 'du' not supported sh-pfc e6060000.pin-controller: invalid function du in map table sh-pfc e6060000.pin-controller: function 'du' not supported sh-pfc e6060000.pin-controller: invalid function du in map table sh-pfc e6060000.pin-controller: function 'du' not supported sh-pfc e6060000.pin-controller: invalid function du in map table
rcar-du: probe of feb00000.display failed with error -22

Signed-off-by Jacopo Mondi <[email protected]>

---

Patch applied against Simon Horman's renesas/master branch.
The PCF pin groups and function renaming was introduced by commit 56ed4bb9 and DTS for ALT board has never been update accordingly.
Tested displaying frames on VGA interface: the rcar-du driver loads correctly.

 arch/arm/boot/dts/r8a7794-alt.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

arch/arm/boot/dts/r8a7794-alt.dts +2 -2

index 8d1b35a..9d65fb3 100644
@@ -165,8 +165,8 @@
 	pinctrl-names = "default";
 
 	du_pins: du {
-		groups = "du1_rgb666", "du1_sync", "du1_disp", "du1_dotclkout0";
-		function = "du";
+		groups = "du1_rgb666", "du1_sync", "du1_disp", "du1_clk0_out";
+		function = "du1";
 	};
 
 	scif2_pins: scif2 {

Signature · 1 line

2.7.4

Sergei Shtylyov

2016-11-03 16:57 UTC #1 lore raw

PATCH 1/1 ARM: DTS: r8a7794: alt: Fix PCF names for DU

Hello.

Quoted 1 line · Jacopo Mondi

Update the PCF pin groups and function names of DU interface for

PFC maybe?

Quoted 15 lines

r8a7794 ALT board.
The currently specified pin groups and function names prevented PCF and DU interfaces from being correctly configured:
sh-pfc e6060000.pin-controller: function 'du' not supported sh-pfc e6060000.pin-controller: invalid function du in map table sh-pfc e6060000.pin-controller: function 'du' not supported sh-pfc e6060000.pin-controller: invalid function du in map table sh-pfc e6060000.pin-controller: function 'du' not supported sh-pfc e6060000.pin-controller: invalid function du in map table sh-pfc e6060000.pin-controller: function 'du' not supported sh-pfc e6060000.pin-controller: invalid function du in map table
rcar-du: probe of feb00000.display failed with error -22

Quoted 6 lines

Signed-off-by Jacopo Mondi <[email protected]>
---
Patch applied against Simon Horman's renesas/master branch.
The PCF pin groups and function renaming was introduced by commit 56ed4bb9 and DTS for ALT board has never been update accordingly.

We didn't care about Alt at the time, the patch was done in the interests
of the SILK board. I didn't realize the DU pin groups were used for Alt before the actual support was added for them. Thank you for finally fixing this!

Quoted 1 line

Tested displaying frames on VGA interface: the rcar-du driver loads correctly.

MBR, Sergei

Jacopo Mondi

author

2016-11-03 19:34 UTC #2 lore raw

PATCH v2 1/1 ARM: DTS: r8a7794: alt: Fix PFC names for DU

In reply to Jacopo Mondi

Update the PFC pin groups and function names of DU interface for r8a7794 ALT board.

The currently specified pin groups and function names prevented PFC and DU interfaces from being correctly configured:

Signed-off-by Jacopo Mondi <[email protected]>

---

v1->v2:
- s/PCF/PFC/ in commit message according to Sergei Shtylyov's comment

 arch/arm/boot/dts/r8a7794-alt.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

arch/arm/boot/dts/r8a7794-alt.dts +2 -2

index 8d1b35a..9d65fb3 100644
@@ -165,8 +165,8 @@
 	pinctrl-names = "default";
 
 	du_pins: du {
-		groups = "du1_rgb666", "du1_sync", "du1_disp", "du1_dotclkout0";
-		function = "du";
+		groups = "du1_rgb666", "du1_sync", "du1_disp", "du1_clk0_out";
+		function = "du1";
 	};
 
 	scif2_pins: scif2 {

Signature · 1 line

2.7.4

Simon Horman

2016-11-04 09:02 UTC #3 lore raw

PATCH v2 1/1 ARM: DTS: r8a7794: alt: Fix PFC names for DU

Hi,

Quoted 19 lines · Jacopo Mondi

Update the PFC pin groups and function names of DU interface for r8a7794 ALT board.
The currently specified pin groups and function names prevented PFC and DU interfaces from being correctly configured:
sh-pfc e6060000.pin-controller: function 'du' not supported sh-pfc e6060000.pin-controller: invalid function du in map table sh-pfc e6060000.pin-controller: function 'du' not supported sh-pfc e6060000.pin-controller: invalid function du in map table sh-pfc e6060000.pin-controller: function 'du' not supported sh-pfc e6060000.pin-controller: invalid function du in map table sh-pfc e6060000.pin-controller: function 'du' not supported sh-pfc e6060000.pin-controller: invalid function du in map table
rcar-du: probe of feb00000.display failed with error -22
Signed-off-by Jacopo Mondi <[email protected]>
---

Quoted 7 lines

v1->v2:
- s/PCF/PFC/ in commit message according to Sergei Shtylyov's comment
Patch applied against Simon Horman's renesas/master branch.
The PCF pin groups and function renaming was introduced by commit 56ed4bb9 and DTS for ALT board has never been update accordingly.
Tested displaying frames on VGA interface: the rcar-du driver loads correctly.

Thanks for noticing this.

There is no need to repost to update the subject, but for reference I would prefer the prefix to be "ARM: dts: alt:". Assuming there are no other changes I can fix that up when queuing up this change.

I am wondering if this should be queued up as a fix for v4.9 and in turn v4.8-stable. Or if it should just be queued up for v4.10.

In the case of the former I'd advocate adding the following tag (again no need to repost just to update this):

Fixes 56ed4bb984ac ("pinctrl: sh-pfc: r8a7794: Add DU pin groups")

Quoted 27 lines

 arch/arm/boot/dts/r8a7794-alt.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

arch/arm/boot/dts/r8a7794-alt.dts +2 -2

index 8d1b35a..9d65fb3 100644
@@ -165,8 +165,8 @@
 	pinctrl-names = "default";
 
 	du_pins: du {
-		groups = "du1_rgb666", "du1_sync", "du1_disp", "du1_dotclkout0";
-		function = "du";
+		groups = "du1_rgb666", "du1_sync", "du1_disp", "du1_clk0_out";
+		function = "du1";
 	};
 
 	scif2_pins: scif2 {

Signature · 7 lines

2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Sergei Shtylyov

2016-11-04 11:43 UTC #4 lore raw

PATCH v2 1/1 ARM: DTS: r8a7794: alt: Fix PFC names for DU

In reply to Jacopo Mondi

Hello.

Quoted 16 lines · Jacopo Mondi

Update the PFC pin groups and function names of DU interface for r8a7794 ALT board.
The currently specified pin groups and function names prevented PFC and DU interfaces from being correctly configured:
sh-pfc e6060000.pin-controller: function 'du' not supported sh-pfc e6060000.pin-controller: invalid function du in map table sh-pfc e6060000.pin-controller: function 'du' not supported sh-pfc e6060000.pin-controller: invalid function du in map table sh-pfc e6060000.pin-controller: function 'du' not supported sh-pfc e6060000.pin-controller: invalid function du in map table sh-pfc e6060000.pin-controller: function 'du' not supported sh-pfc e6060000.pin-controller: invalid function du in map table
rcar-du: probe of feb00000.display failed with error -22

Quoted 1 line

Signed-off-by Jacopo Mondi <[email protected]>

Acked-by Sergei Shtylyov <[email protected]>

MBR, Sergei

Simon Horman

2016-11-07 12:40 UTC #5 lore raw

PATCH v2 1/1 ARM: DTS: r8a7794: alt: Fix PFC names for DU

Quoted 20 lines · Sergei Shtylyov

Hello.
Quoted 16 lines · Jacopo Mondi
Update the PFC pin groups and function names of DU interface for r8a7794 ALT board.
The currently specified pin groups and function names prevented PFC and DU interfaces from being correctly configured:
sh-pfc e6060000.pin-controller: function 'du' not supported sh-pfc e6060000.pin-controller: invalid function du in map table sh-pfc e6060000.pin-controller: function 'du' not supported sh-pfc e6060000.pin-controller: invalid function du in map table sh-pfc e6060000.pin-controller: function 'du' not supported sh-pfc e6060000.pin-controller: invalid function du in map table sh-pfc e6060000.pin-controller: function 'du' not supported sh-pfc e6060000.pin-controller: invalid function du in map table
rcar-du: probe of feb00000.display failed with error -22

Quoted 3 lines

Quoted 1 line
Signed-off-by Jacopo Mondi <[email protected]>
Acked-by Sergei Shtylyov <[email protected]>

Thanks, I have queued this up.