Skip to contentSkip to conversation

soc/tegra: pmc: Use consistent naming for PM domains

PATCH In review Thierry Reding 2 participants 3 messages Nov 8, 2016 1 message not in the archive Tegra architecture support

lore
Share & tools
lore

Thierry Reding

author
#0 lore raw

PATCH 1/1 soc/tegra: pmc: Use consistent naming for PM domains

From: Thierry Reding <[email protected]>

The various error messages refer to the PM domains as "power domain", "genpd" and "PM domain". That's confusing, so convert all error messages to use the most prominent: "PM domain".

Signed-off-by Thierry Reding <[email protected]>
---
 drivers/soc/tegra/pmc.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/soc/tegra/pmc.c +4 -4
index 84d1623d8d79..933b06abe8a2 100644
@@ -867,19 +867,19 @@ static void tegra_powergate_add(struct tegra_pmc *pmc, struct device_node *np)
 
 	err = pm_genpd_init(&pg->genpd, NULL, off);
 	if (err < 0) {
-		pr_err("failed to initialise power domain %s: %d\n", np->name,
+		pr_err("failed to initialise PM domain %s: %d\n", np->name,
 		       err);
 		goto remove_resets;
 	}
 
 	err = of_genpd_add_provider_simple(np, &pg->genpd);
 	if (err < 0) {
-		pr_err("failed to add genpd provider for %s: %d\n", np->name,
-		       err);
+		pr_err("failed to add PM domain provider for %s: %d\n",
+		       np->name, err);
 		goto remove_genpd;
 	}
 
-	pr_debug("added power domain %s\n", pg->genpd.name);
+	pr_debug("added PM domain %s\n", pg->genpd.name);
 
 	return;
Signature · 1 line
2.10.2

A message that is not in the archive (sent off-list or not yet received): 20161108100807.5114-1-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

Acked-by
#2 lore raw
Quoted 28 lines · Thierry Reding

From: Thierry Reding <[email protected]>

The various error messages refer to the PM domains as "power domain", "genpd" and "PM domain". That's confusing, so convert all error messages to use the most prominent: "PM domain".

Signed-off-by Thierry Reding <[email protected]>
---
 drivers/soc/tegra/pmc.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/soc/tegra/pmc.c +1 -2
index 84d1623d8d79..933b06abe8a2 100644
@@ -867,19 +867,19 @@ static void tegra_powergate_add(struct tegra_pmc *pmc, struct device_node *np)
 
 	err = pm_genpd_init(&pg->genpd, NULL, off);
 	if (err < 0) {
-		pr_err("failed to initialise power domain %s: %d\n", np->name,
+		pr_err("failed to initialise PM domain %s: %d\n", np->name,
 		       err);
 		goto remove_resets;
 	}
 
 	err = of_genpd_add_provider_simple(np, &pg->genpd);
 	if (err < 0) {
-		pr_err("failed to add genpd provider for %s: %d\n", np->name,

drivers/soc/tegra/pmc.c static void tegra_powergate_add(struct tegra_pmc *pmc, struct device_node *np) · line 884

Quoted 10 lines
drivers/soc/tegra/pmc.c +3 -2
-		       err);
+		pr_err("failed to add PM domain provider for %s: %d\n",
+		       np->name, err);
 		goto remove_genpd;
 	}
 
-	pr_debug("added power domain %s\n", pg->genpd.name);
+	pr_debug("added PM domain %s\n", pg->genpd.name);
 
 	return;
Acked-by Jon Hunter <[email protected]>

Cheers
Jon

Signature · 1 line
nvpublic
author Applied
#3 lore raw
In reply to a message not in the archive
Quoted 10 lines · Thierry Reding

From: Thierry Reding <[email protected]>

The various error messages refer to the PM domains as "power domain", "genpd" and "PM domain". That's confusing, so convert all error messages to use the most prominent: "PM domain".

Signed-off-by Thierry Reding <[email protected]>
---
 drivers/soc/tegra/pmc.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Applied.

Thierry