Skip to contentSkip to conversation

Reindent code in radeon_dri2_create_buffer2

PATCH In review Michel Dänzer 2 participants 2 messages Nov 9, 2016 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Reindent code in radeon_dri2_create_buffer2

From: Michel Dänzer <[email protected]>

Fixes warning about misleading indentation from recent versions of gcc:

../../src/radeon_dri2.c: In function ‘radeon_dri2_create_buffer2’:
../../src/radeon_dri2.c:224:2: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
if (flags & RADEON_CREATE_PIXMAP_TILING_MACRO)
^~
../../src/radeon_dri2.c:227:6: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘if’

      if (aligned_width == front_width)
      ^~

No functional change intended.

---
 src/radeon_dri2.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
src/radeon_dri2.c +8 -8
index 1206b2a..8112670 100644
@@ -224,14 +224,14 @@ radeon_dri2_create_buffer2(ScreenPtr pScreen,
 	if (flags & RADEON_CREATE_PIXMAP_TILING_MACRO)
 	    tiling |= RADEON_TILING_MACRO;
 
-	    if (aligned_width == front_width)
-		aligned_width = pScrn->virtualX;
-
-	    pixmap = (*pScreen->CreatePixmap)(pScreen,
-					      aligned_width,
-					      height,
-					      depth,
-					      flags | RADEON_CREATE_PIXMAP_DRI2);
+	if (aligned_width == front_width)
+	    aligned_width = pScrn->virtualX;
+
+	pixmap = (*pScreen->CreatePixmap)(pScreen,
+					  aligned_width,
+					  height,
+					  depth,
+					  flags | RADEON_CREATE_PIXMAP_DRI2);
     }
 
     buffers = calloc(1, sizeof *buffers);
Signature · 6 lines
2.10.2

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 20161109070454.23007-1-michel-otUistvHUpPR7s880joybQ@public.gmane.org

Reviewed-by Alex Deucher
#2 lore raw
Quoted 19 lines

-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Michel Dänzer
Sent: Wednesday, November 09, 2016 2:05 AM
To: [email protected]
Subject: [PATCH xf86-video-ati] Reindent code in radeon_dri2_create_buffer2

From: Michel Dänzer <[email protected]>

Fixes warning about misleading indentation from recent versions of gcc:

../../src/radeon_dri2.c: In function ‘radeon_dri2_create_buffer2’:
../../src/radeon_dri2.c:224:2: warning: this ‘if’ clause does not guard... [- Wmisleading-indentation]
if (flags & RADEON_CREATE_PIXMAP_TILING_MACRO)
^~
../../src/radeon_dri2.c:227:6: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘if’

Quoted 6 lines
      if (aligned_width == front_width)
      ^~

No functional change intended.

Quoted 32 lines
---
 src/radeon_dri2.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
src/radeon_dri2.c +8 -8
index 1206b2a..8112670 100644
@@ -224,14 +224,14 @@ radeon_dri2_create_buffer2(ScreenPtr pScreen,
 	if (flags & RADEON_CREATE_PIXMAP_TILING_MACRO)
 	    tiling |= RADEON_TILING_MACRO;
 
-	    if (aligned_width == front_width)
-		aligned_width = pScrn->virtualX;
-
-	    pixmap = (*pScreen->CreatePixmap)(pScreen,
-					      aligned_width,
-					      height,
-					      depth,
-					      flags |
 RADEON_CREATE_PIXMAP_DRI2);
+	if (aligned_width == front_width)
+	    aligned_width = pScrn->virtualX;
+
+	pixmap = (*pScreen->CreatePixmap)(pScreen,
+					  aligned_width,
+					  height,
+					  depth,
+					  flags |
 RADEON_CREATE_PIXMAP_DRI2);
     }
Quoted 8 lines
     buffers = calloc(1, sizeof *buffers);

--
2.10.2

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx