grub2: enable grub-mkfont host tool
PATCH 1/1 grub2: enable grub-mkfont host tool
Signed-off-by J?r?me Pouiller <[email protected]>
--- boot/grub2/grub2.mk | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
boot/grub2/grub2.mk +1 -2
@@ -9,7 +9,7 @@ GRUB2_SITE = $(BR2_GNU_MIRROR)/grub GRUB2_SOURCE = grub-$(GRUB2_VERSION).tar.xz GRUB2_LICENSE = GPLv3+ GRUB2_LICENSE_FILES = COPYING -GRUB2_DEPENDENCIES = host-bison host-flex +GRUB2_DEPENDENCIES = host-bison host-flex host-freetype GRUB2_BUILTIN_MODULES = $(call qstrip,$(BR2_TARGET_GRUB2_BUILTIN_MODULES)) GRUB2_BUILTIN_CONFIG = $(call qstrip,$(BR2_TARGET_GRUB2_BUILTIN_CONFIG))
@@ -63,7 +63,6 @@ GRUB2_CONF_ENV = \ GRUB2_CONF_OPTS = \ --target=$(GRUB2_TARGET) \ --with-platform=$(GRUB2_PLATFORM) \ - --disable-grub-mkfont \ --enable-efiemu=no \ ac_cv_lib_lzma_lzma_code=no \ --enable-device-mapper=no \
Signature · 1 line
2.9.3
PATCH 1/1 grub2: enable grub-mkfont host tool
Hello,
Quoted 1 line · J?r?me Pouiller
Signed-off-by J?r?me Pouiller <[email protected]>
Empty commit log: not good. It would have been nice to explain in which situations grub-mkfont is useful.
Quoted 9 lines
--- boot/grub2/grub2.mk | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)boot/grub2/grub2.mk +0
-0
boot/grub2/grub2.mk GRUB2_SITE = $(BR2_GNU_MIRROR)/grub · line 12
Quoted 5 lines
boot/grub2/grub2.mk +1
-1@@ -9,7 +9,7 @@ GRUB2_SITE = $(BR2_GNU_MIRROR)/grub GRUB2_SOURCE = grub-$(GRUB2_VERSION).tar.xz GRUB2_LICENSE = GPLv3+ GRUB2_LICENSE_FILES = COPYING -GRUB2_DEPENDENCIES = host-bison host-flex +GRUB2_DEPENDENCIES = host-bison host-flex host-freetype
I don't really like this additional dependency, that is only needed when one needs mkfont (pretty rare use case I believe).
Can we instead add a sub-option to the grub2 package to select (or not) the build of the mkfont utility?
Of course, don't forget to explicitly --enable/--disable the relevant option.
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com