Skip to contentSkip to conversation

php-fpm: remove config comments to fix startup

PATCH New Frank Hunleth 3 participants 3 messages Nov 8, 2016 – Nov 9, 2016

lore
Share & tools
lore

Frank Hunleth

author
#0 lore raw

PATCH 1/1 php-fpm: remove config comments to fix startup

The comments in the Buildroot-provided php-fpm.conf would produce the following error when starting php-fpm:

ERROR: [/etc/php-fpm.conf:2] value is NULL for a ZEND_INI_PARSER_ENTRY

Removing the comments fixes the problem.

Signed-off-by Frank Hunleth <[email protected]>
---
 package/php/php-fpm.conf | 3 ---
 1 file changed, 3 deletions(-)
package/php/php-fpm.conf +0 -3
index b75a58f..88014b8 100644
@@ -1,9 +1,6 @@
 [www]
-# Only start children when there are requests to be processed
 pm = ondemand
-# Terminate them again after there haven't been any for 2 minutes
 pm.process_idle_timeout = 120s
-# Maximum number of children processing PHP requests concurrently
 pm.max_children = 5
 
 listen = /var/run/php-fpm.sock
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 php-fpm: remove config comments to fix startup

Quoted 8 lines · Frank Hunleth

The comments in the Buildroot-provided php-fpm.conf would produce the following error when starting php-fpm:

ERROR: [/etc/php-fpm.conf:2] value is NULL for a ZEND_INI_PARSER_ENTRY

Removing the comments fixes the problem.

Signed-off-by Frank Hunleth <[email protected]>
Reviewed-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Regards,
Arnout

Quoted 19 lines
---
 package/php/php-fpm.conf | 3 ---
 1 file changed, 3 deletions(-)
package/php/php-fpm.conf +0 -3
index b75a58f..88014b8 100644
@@ -1,9 +1,6 @@
 [www]
-# Only start children when there are requests to be processed
 pm = ondemand
-# Terminate them again after there haven't been any for 2 minutes
 pm.process_idle_timeout = 120s
-# Maximum number of children processing PHP requests concurrently
 pm.max_children = 5
 
 listen = /var/run/php-fpm.sock
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
Applied
#2 lore raw

PATCH 1/1 php-fpm: remove config comments to fix startup

In reply to Frank Hunleth

Hello,

Quoted 11 lines · Frank Hunleth

The comments in the Buildroot-provided php-fpm.conf would produce the following error when starting php-fpm:

ERROR: [/etc/php-fpm.conf:2] value is NULL for a ZEND_INI_PARSER_ENTRY

Removing the comments fixes the problem.

Signed-off-by Frank Hunleth <[email protected]>
---
 package/php/php-fpm.conf | 3 ---
 1 file changed, 3 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com