Skip to contentSkip to conversation

PM / Domains: Fix a warning message

PATCH Applied Dan Carpenter 4 participants 4 messages Nov 10, 2016 – Nov 14, 2016

Subsystems (5)
Kernel janitors Driver core Suspend to RAM Hibernation +1 more subsystems
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 PM / Domains: Fix a warning message

The first argument of WARN() is the condition, followed by the message.

Signed-off-by Dan Carpenter <[email protected]>
drivers/base/power/domain.c +1 -1
index 661737c..7b4d41f 100644
@@ -1297,7 +1297,7 @@ static int genpd_add_subdomain(struct generic_pm_domain *genpd,
 	 * powered on/off in that context.
 	 */
 	if (!genpd_is_irq_safe(genpd) && genpd_is_irq_safe(subdomain)) {
-		WARN("Parent %s of subdomain %s must be IRQ safe\n",
+		WARN(1, "Parent %s of subdomain %s must be IRQ safe\n",
 				genpd->name, subdomain->name);
 		return -EINVAL;
 	}
Acked-by on v1 1/1
#2 lore raw
In reply to Dan Carpenter
Quoted 3 lines · Dan Carpenter

The first argument of WARN() is the condition, followed by the message.

Signed-off-by Dan Carpenter <[email protected]>
Acked-by Ulf Hansson <[email protected]>

Kind regards
Uffe

Quoted 14 lines
drivers/base/power/domain.c +1 -1
index 661737c..7b4d41f 100644
@@ -1297,7 +1297,7 @@ static int genpd_add_subdomain(struct generic_pm_domain *genpd,
         * powered on/off in that context.
         */
        if (!genpd_is_irq_safe(genpd) && genpd_is_irq_safe(subdomain)) {
-               WARN("Parent %s of subdomain %s must be IRQ safe\n",
+               WARN(1, "Parent %s of subdomain %s must be IRQ safe\n",
                                genpd->name, subdomain->name);
                return -EINVAL;
        }