Skip to contentSkip to conversation

Staging: fsl-mc: include: mc: Kernel type 's16' preferred over 'int16_t'

PATCH Superseded Shiva Kerdel 2 participants 4 messages Nov 10, 2016 Staging

v2 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 Staging: fsl-mc: include: mc: Kernel type 's16' preferred over 'int16_t'

Follow the kernel type preferrences of using 's16' over 'int16_t'.

---
Changes for v2:
- corrected an error in the log message, wrote 's32' instead of 's16'.
Changes for v3:
- added the missing annotate of v2.

---
 drivers/staging/fsl-mc/include/mc-bus.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/fsl-mc/include/mc-bus.h +2 -2
index e915574..c7cad87 100644
@@ -42,8 +42,8 @@ struct msi_domain_info;
  */
 struct fsl_mc_resource_pool {
 	enum fsl_mc_pool_type type;
-	int16_t max_count;
-	int16_t free_count;
+	s16 max_count;
+	s16 free_count;
 	struct mutex mutex;	/* serializes access to free_list */
 	struct list_head free_list;
 	struct fsl_mc_bus *mc_bus;
Signature · 1 line
2.10.2
#1 lore raw

PATCH v2 2/2 Staging: fsl-mc: include: mc: Kernel type 's32' preferred over 'int32_t'

Follow the kernel type preferrences of using 's32' over 'int32_t'.

---
 drivers/staging/fsl-mc/include/mc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/fsl-mc/include/mc.h +1 -1
index a781a36..1c46c0c 100644
@@ -81,7 +81,7 @@ enum fsl_mc_pool_type {
  */
 struct fsl_mc_resource {
 	enum fsl_mc_pool_type type;
-	int32_t id;
+	s32 id;
 	void *data;
 	struct fsl_mc_resource_pool *parent_pool;
 	struct list_head node;
Signature · 1 line
2.10.2
maintainer
#2 lore raw

Re: [PATCH v2 2/2] Staging: fsl-mc: include: mc: Kernel type 's32' preferred over 'int32_t'

Quoted 7 lines · Shiva Kerdel

Follow the kernel type preferrences of using 's32' over 'int32_t'.

---
 drivers/staging/fsl-mc/include/mc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

The changelog between v1, v2, and v3?

maintainer
#3 lore raw
In reply to Shiva Kerdel
Quoted 10 lines · Shiva Kerdel

Follow the kernel type preferrences of using 's16' over 'int16_t'.

---
Changes for v2:
- corrected an error in the log message, wrote 's32' instead of 's16'.
Changes for v3:
- added the missing annotate of v2.
---

But your patch subject says "v2" :(

And there is no need for another --- line, please don't have that.

thanks,

greg k-h