Skip to contentSkip to conversation

staging: lustre: lov: crash in error handling

PATCH In review Dan Carpenter 2 participants 2 messages Nov 10, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: lustre: lov: crash in error handling

We accidentally made this unsigned so now the error handling will loop until it crashes.

Fixes 55051039fdad ('staging: lustre: lov: remove LSM from struct lustre_md')
drivers/staging/lustre/lustre/lov/lov_ea.c +1 -1
index 53db170..2e2abed 100644
@@ -81,7 +81,7 @@ struct lov_stripe_md *lsm_alloc_plain(u16 stripe_count)
 	size_t oinfo_ptrs_size, lsm_size;
 	struct lov_stripe_md *lsm;
 	struct lov_oinfo     *loi;
-	unsigned int i;
+	int i;
 
 	LASSERT(stripe_count <= LOV_MAX_STRIPE_COUNT);
 
#1 lore raw
Quoted 6 lines

We accidentally made this unsigned so now the error handling will loop until it crashes.

Fixes 55051039fdad ('staging: lustre: lov: remove LSM from struct lustre_md')

Yep. I just sent a patch to fix that.

Quoted 14 lines
drivers/staging/lustre/lustre/lov/lov_ea.c +1 -1
index 53db170..2e2abed 100644
@@ -81,7 +81,7 @@ struct lov_stripe_md *lsm_alloc_plain(u16 stripe_count)
 	size_t oinfo_ptrs_size, lsm_size;
 	struct lov_stripe_md *lsm;
 	struct lov_oinfo     *loi;
-	unsigned int i;
+	int i;
 
 	LASSERT(stripe_count <= LOV_MAX_STRIPE_COUNT);