include/linux/module.h:213:1: error: expected ',' or ';' before 'extern'

PATCH New kbuild test robot 3 participants 3 messages Nov 10, 2016 – Nov 11, 2016 Common clk

Share & tools

kbuild test robot

author build bot

2016-11-10 23:20 UTC #0 lore raw

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-qcom-8994
head:   cc800227108710c8f02255e61659b956b041eec3
commit: cc800227108710c8f02255e61659b956b041eec3 [2/2] clk: qcom: Add support for msm8994 global clock controller
config: i386-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        git checkout cc800227108710c8f02255e61659b956b041eec3
        # save the attached .config to linux build tree
        make ARCH=i386

All error/warnings (new ones prefixed by >>):

In file included from drivers/clk/qcom/gcc-msm8994.c:20:0:

>> include/linux/module.h:213:1: error: expected ',' or ';' before 'extern'
    extern const typeof(name) __mod_##type##__##name##_device_table  \
    ^
>> drivers/clk/qcom/gcc-msm8994.c:2265:1: note: in expansion of macro 'MODULE_DEVICE_TABLE'
    MODULE_DEVICE_TABLE(of, gcc_msm8994_match_table);
    ^~~~~~~~~~~~~~~~~~~

vim +213 include/linux/module.h

^1da177e Linus Torvalds  2005-04-16  207  /* What your module does. */
^1da177e Linus Torvalds  2005-04-16  208  #define MODULE_DESCRIPTION(_description) MODULE_INFO(description, _description)
^1da177e Linus Torvalds  2005-04-16  209  
cff26a51 Rusty Russell   2014-02-03  210  #ifdef MODULE
cff26a51 Rusty Russell   2014-02-03  211  /* Creates an alias so file2alias.c can find device table. */
^1da177e Linus Torvalds  2005-04-16  212  #define MODULE_DEVICE_TABLE(type, name)					\
6301939d Andrey Ryabinin 2015-02-13 @213  extern const typeof(name) __mod_##type##__##name##_device_table		\
cff26a51 Rusty Russell   2014-02-03  214    __attribute__ ((unused, alias(__stringify(name))))
cff26a51 Rusty Russell   2014-02-03  215  #else  /* !MODULE */
cff26a51 Rusty Russell   2014-02-03  216  #define MODULE_DEVICE_TABLE(type, name)

:::::: The code at line 213 was first introduced by commit
:::::: 6301939d97d079f0d3dbe71e750f4daf5d39fc33 module: fix types of device tables aliases

:::::: TO: Andrey Ryabinin <[email protected]> :::::: CC: Linus Torvalds <[email protected]>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 56819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161111/9bf381ab/attachment-0001.gz>

Stephen Boyd

2016-11-10 23:45 UTC #1 lore raw

PATCH 2/2 include/linux/module.h:213:1: error: expected ',' or ';' before 'extern'

Quoted 10 lines · kbuild test robot

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-qcom-8994
head:   cc800227108710c8f02255e61659b956b041eec3
commit: cc800227108710c8f02255e61659b956b041eec3 [2/2] clk: qcom: Add support for msm8994 global clock controller
config: i386-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        git checkout cc800227108710c8f02255e61659b956b041eec3
        # save the attached .config to linux build tree
        make ARCH=i386

Quoted 8 lines

All error/warnings (new ones prefixed by >>):
   In file included from drivers/clk/qcom/gcc-msm8994.c:20:0:
Quoted 1 line
Quoted 1 line
include/linux/module.h:213:1: error: expected ',' or ';' before 'extern'
    extern const typeof(name) __mod_##type##__##name##_device_table  \
    ^
Quoted 1 line
Quoted 1 line
drivers/clk/qcom/gcc-msm8994.c:2265:1: note: in expansion of macro 'MODULE_DEVICE_TABLE'
    MODULE_DEVICE_TABLE(of, gcc_msm8994_match_table);

Urgh that's sad. Too bad MODULE_DEVICE_TABLE doesn't have something in it in the !MODULE case to cause compilation problems like this to come out. I'll go fix this up.

Signature · 2 lines

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Bastian Köcher

2016-11-11 07:35 UTC #2 lore raw

PATCH 2/2 include/linux/module.h:213:1: error: expected ',' or '; ' before 'extern'

Thanks for doing that :)

Quoted 25 lines · On Donnerstag, 10. November 2016 15:45:15 CET Stephen Boyd wrote:

Quoted 10 lines · kbuild test robot
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-qcom-8994
head:   cc800227108710c8f02255e61659b956b041eec3
commit: cc800227108710c8f02255e61659b956b041eec3 [2/2] clk: qcom: Add support for msm8994 global clock controller
config: i386-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        git checkout cc800227108710c8f02255e61659b956b041eec3
        # save the attached .config to linux build tree
        make ARCH=i386 
Quoted 8 lines
All error/warnings (new ones prefixed by >>):
   In file included from drivers/clk/qcom/gcc-msm8994.c:20:0:
Quoted 1 line
Quoted 1 line
include/linux/module.h:213:1: error: expected ',' or ';' before 'extern'
    extern const typeof(name) __mod_##type##__##name##_device_table  \
    ^
Quoted 1 line
Quoted 1 line
drivers/clk/qcom/gcc-msm8994.c:2265:1: note: in expansion of macro 'MODULE_DEVICE_TABLE'
    MODULE_DEVICE_TABLE(of, gcc_msm8994_match_table);
Urgh that's sad. Too bad MODULE_DEVICE_TABLE doesn't have something in it in the !MODULE case to cause compilation problems like this to come out. I'll go fix this up.