Skip to contentSkip to conversation

watchdog: jz4740: Fix modular build

PATCH In review Stephen Boyd 2 participants 2 messages Nov 11, 2016

Subsystems (2)
Watchdog device drivers Ingenic JZ47xx SoCs
lore
Share & tools
lore

Stephen Boyd

author
#0 lore raw

PATCH 1/1 watchdog: jz4740: Fix modular build

Compiling this driver as a module causes a build error because a semicolon is missing after MODULE_DEVICE_TABLE. Add it.

CC [M] drivers/watchdog/jz4740_wdt.o
drivers/watchdog/jz4740_wdt.c:154:1: error: expected ‘,’ or ‘;’ before ‘static’ drivers/watchdog/jz4740_wdt.c:218:11: error: ‘jz4740_wdt_probe’ undeclared here (not in a function)

Cc Zubair Lutfullah Kakakhel <[email protected]>
Cc Guenter Roeck <[email protected]>
Signed-off-by Stephen Boyd <[email protected]>
---
 drivers/watchdog/jz4740_wdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/jz4740_wdt.c +1 -1
index c8d51ddb26d5..20627f22baf6 100644
@@ -148,7 +148,7 @@ static const struct of_device_id jz4740_wdt_of_matches[] = {
 	{ .compatible = "ingenic,jz4740-watchdog", },
 	{ /* sentinel */ }
 };
-MODULE_DEVICE_TABLE(of, jz4740_wdt_of_matches)
+MODULE_DEVICE_TABLE(of, jz4740_wdt_of_matches);
 #endif
 
 static int jz4740_wdt_probe(struct platform_device *pdev)
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Stephen Boyd

Compiling this driver as a module causes a build error because a semicolon is missing after MODULE_DEVICE_TABLE. Add it.

CC [M] drivers/watchdog/jz4740_wdt.o
drivers/watchdog/jz4740_wdt.c:154:1: error: expected ‘,’ or ‘;’ before ‘static’ drivers/watchdog/jz4740_wdt.c:218:11: error: ‘jz4740_wdt_probe’ undeclared here (not in a function)

Cc Zubair Lutfullah Kakakhel <[email protected]>
Cc Guenter Roeck <[email protected]>
Signed-off-by Stephen Boyd <[email protected]>

Oops :-(

Reviewed-by Guenter Roeck <[email protected]>
Quoted 10 lines
---
 drivers/watchdog/jz4740_wdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/jz4740_wdt.c +0 -0
index c8d51ddb26d5..20627f22baf6 100644

drivers/watchdog/jz4740_wdt.c static const struct of_device_id jz4740_wdt_of_matches[] = { · line 154

Quoted 8 lines
drivers/watchdog/jz4740_wdt.c +1 -1
@@ -148,7 +148,7 @@ static const struct of_device_id jz4740_wdt_of_matches[] = {
 	{ .compatible = "ingenic,jz4740-watchdog", },
 	{ /* sentinel */ }
 };
-MODULE_DEVICE_TABLE(of, jz4740_wdt_of_matches)
+MODULE_DEVICE_TABLE(of, jz4740_wdt_of_matches);
 #endif
 
 static int jz4740_wdt_probe(struct platform_device *pdev)

--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html