Skip to contentSkip to conversation

HID: wacom: Declare tool ID 0x84a as an Intuos eraser

PATCH Applied Jason Gerecke 3 participants 3 messages Nov 11, 2016 – Nov 15, 2016

Subsystems (2)
HID HID wacom driver
lore
Share & tools
lore

Jason Gerecke

author
#0 lore raw

PATCH 1/1 HID: wacom: Declare tool ID 0x84a as an Intuos eraser

The eraser end of the 8K pen available for the MobileStudio Pro has a tool ID of 0x84a. The 'wacom_intuos_get_tool_type' function does not currently recognize this ID, causing it to return BTN_TOOL_PEN rather than BTN_TOOL_RUBBER. This does not cause a problem for the MobileStudio Pro since, as a HID_GENERIC device, the driver relies on the state of the HID_DG_INVERT usage instead. It would, however, cause problems if the pen is used with devices that use the traditional 'wacom_intuos_irq' codepath instead.

Signed-off-by Jason Gerecke <[email protected]>
---
 drivers/hid/wacom_wac.c | 1 +
 1 file changed, 1 insertion(+)
drivers/hid/wacom_wac.c +1 -0
index 0723ba8..55857bf 100644
@@ -645,6 +645,7 @@ static int wacom_intuos_get_tool_type(int tool_id)
 		break;
 
 	case 0x82a: /* Eraser */
+	case 0x84a:
 	case 0x85a:
 	case 0x91a:
 	case 0xd1a:
Signature · 1 line
2.10.2
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Jason Gerecke

The eraser end of the 8K pen available for the MobileStudio Pro has a tool ID of 0x84a. The 'wacom_intuos_get_tool_type' function does not currently recognize this ID, causing it to return BTN_TOOL_PEN rather than BTN_TOOL_RUBBER. This does not cause a problem for the MobileStudio Pro since, as a HID_GENERIC device, the driver relies on the state of the HID_DG_INVERT usage instead. It would, however, cause problems if the pen is used with devices that use the traditional 'wacom_intuos_irq' codepath instead.

Signed-off-by Jason Gerecke <[email protected]>
Acked-by Benjamin Tissoires <[email protected]>
maintainer Applied
#2 lore raw
In reply to Jason Gerecke
Quoted 8 lines · Jason Gerecke

The eraser end of the 8K pen available for the MobileStudio Pro has a tool ID of 0x84a. The 'wacom_intuos_get_tool_type' function does not currently recognize this ID, causing it to return BTN_TOOL_PEN rather than BTN_TOOL_RUBBER. This does not cause a problem for the MobileStudio Pro since, as a HID_GENERIC device, the driver relies on the state of the HID_DG_INVERT usage instead. It would, however, cause problems if the pen is used with devices that use the traditional 'wacom_intuos_irq' codepath instead.

Applied, thanks.

Signature · 2 lines
Jiri Kosina
SUSE Labs