Skip to contentSkip to conversation

console: Fix compiler warning

PATCH In review David Sommerseth 2 participants 2 messages Nov 11, 2016 – Nov 12, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 console: Fix compiler warning

Building with -O2, the compiler warned about query_user_SINGLE() being declared and not used in console.c. This function, defined in console.h, should have been declared as 'static inline'. This also removes that warning.

---
 src/openvpn/console.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/openvpn/console.h +1 -1
index 41f2b8c..ec32cf6 100644
@@ -106,7 +106,7 @@ static bool query_user_exec ()
  *             to be called at start-up initialization of OpenVPN.
  *
  */
-static bool query_user_SINGLE (char *prompt, size_t prompt_len,
+static inline bool query_user_SINGLE (char *prompt, size_t prompt_len,
                      char *resp, size_t resp_len,
                      bool echo)
 {
Signature · 1 line
1.8.3.1
#1 lore raw

ACK. Compile-tested only (this is the sort of change that either breaks at compilation or not :) )

Your patch has been applied to the master branch.

commit 14cb1639f7694cdd461bace5e273acd7722cd3cf

Author: David Sommerseth
Date:   Fri Nov 11 14:30:07 2016 +0100
     console: Fix compiler warning

     Signed-off-by: David Sommerseth <[email protected]...>
     Acked-by: Gert Doering <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg13005.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering