Skip to contentSkip to conversation

gp8psk-fe: add missing MODULE_foo() macros

PATCH In review Mauro Carvalho Chehab 2 participants 2 messages Nov 14, 2016

Subsystems (2)
Media (V4L/DVB) Linux-next tree
lore
Share & tools
lore

Mauro Carvalho Chehab

author
#0 lore raw

PATCH 1/1 gp8psk-fe: add missing MODULE_foo() macros

This file was converted to a separate module at commit
7a0786c19d65 ("gp8psk: Fix DVB frontend attach"), because
the DVB attach routines require it to work. However,
I forgot to copy the MODULE_foo() macros from the original
module, causing this warning:
WARNING: modpost: missing MODULE_LICENSE() in drivers/media/dvb-frontends/gp8psk-fe.o

Reported-by Stephen Rothwell <[email protected]>
Fixes 7a0786c19d65 ("gp8psk: Fix DVB frontend attach")
Signed-off-by Mauro Carvalho Chehab <[email protected]>
drivers/media/dvb-frontends/gp8psk-fe.c +10 -7
index be19afeed7a9..93f59bfea092 100644
@@ -1,5 +1,5 @@
-/* DVB USB compliant Linux driver for the
- *  - GENPIX 8pks/qpsk/DCII USB2.0 DVB-S module
+/*
+ * Frontend driver for the GENPIX 8pks/qpsk/DCII USB2.0 DVB-S module
  *
  * Copyright (C) 2006,2007 Alan Nisota ([email protected])
  * Copyright (C) 2006,2007 Genpix Electronics ([email protected])

@@ -8,11 +8,9 @@
  *
  * This module is based off the vp7045 and vp702x modules
  *
- *	This program is free software; you can redistribute it and/or modify it
- *	under the terms of the GNU General Public License as published by the Free
- *	Software Foundation, version 2.
- *
- * see Documentation/dvb/README.dvb-usb for more information
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License as published by the Free
+ * Software Foundation, version 2.
  */
 
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

@@ -395,3 +393,8 @@ static struct dvb_frontend_ops gp8psk_fe_ops = {
 	.dishnetwork_send_legacy_command = gp8psk_fe_send_legacy_dish_cmd,
 	.enable_high_lnb_voltage = gp8psk_fe_enable_high_lnb_voltage
 };
+
+MODULE_AUTHOR("Alan Nisota <[email protected]>");
+MODULE_DESCRIPTION("Frontend Driver for Genpix DVB-S");
+MODULE_VERSION("1.1");
+MODULE_LICENSE("GPL");

Thanks,
Mauro

#1 lore raw

drivers/media/dvb-frontends/gp8psk-fe.c

Quoted 8 lines · Mauro Carvalho Chehab
drivers/media/dvb-frontends/gp8psk-fe.c +4 -0
 
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License as published by the Free
+ * Software Foundation, version 2.
 
+MODULE_LICENSE("GPL");

Nit: according to the comments in include/linux/module.h the "ident" that matches the license described at the top of this file is "GPL v2".

Paul Bolle