alpha: silence a buffer overflow warning

PATCH New Dan Carpenter 1 participant 1 message Nov 14, 2016

Subsystems (2)

Kernel janitors Alpha port

lore

Share & tools

lore

Dan Carpenter

author

2016-11-14 11:34 UTC #0 lore raw

PATCH 1/1 alpha: silence a buffer overflow warning

We check that "member" is in bounds for the first line, but we also use it on the next line without checking which is a mistake.

Signed-off-by Dan Carpenter <[email protected]>

arch/alpha/kernel/setup.c +3 -2

index 4811e54..7574377 100644
@@ -1094,8 +1094,9 @@ get_sysnames(unsigned long type, unsigned long variation, unsigned long cpu,
 	default: /* default to variation "0" for now */
 		break;
 	case ST_DEC_EB164:
-		if (member < ARRAY_SIZE(eb164_indices))
-			*variation_name = eb164_names[eb164_indices[member]];
+		if (member >= ARRAY_SIZE(eb164_indices))
+			break;
+		*variation_name = eb164_names[eb164_indices[member]];
 		/* PC164 may show as EB164 variation, but with EV56 CPU,
 		   so, since no true EB164 had anything but EV5... */
 		if (eb164_indices[member] = 0 && cpu = EV56_CPU)