Skip to contentSkip to conversation

ARM: dts: imx6q: replace gpio-key, wakeup with wakeup-source for Utilite Pro

PATCH New Sudeep Holla 3 participants 3 messages Nov 14, 2016 – Nov 15, 2016

Subsystems (2)
Device tree bindings Arm i.MX and Layerscape
lore
Share & tools
lore

Sudeep Holla

author
#0 lore raw

PATCH 1/1 ARM: dts: imx6q: replace gpio-key, wakeup with wakeup-source for Utilite Pro

Though the keyboard driver for GPIO buttons(gpio-keys) will continue to check for/support the legacy "gpio-key,wakeup" boolean property to enable gpio buttons as wakeup source, "wakeup-source" is the new standard binding.

This patch replaces the legacy "gpio-key,wakeup" with the unified "wakeup-source" property in order to avoid any further copy-paste duplication.

Cc Shawn Guo <[email protected]>
Cc Sascha Hauer <[email protected]>
Cc Fabio Estevam <[email protected]>
Signed-off-by Sudeep Holla <[email protected]>
---
 arch/arm/boot/dts/imx6q-utilite-pro.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Hi,

Inspite of getting rid of most of the legacy property almost a year ago, addition of new platforms have brought this back and over time it's now found again in few places. Just get rid of them *again*

Regards,
Sudeep

arch/arm/boot/dts/imx6q-utilite-pro.dts +1 -1
index 61990630a748..104bbe710927 100644
@@ -68,7 +68,7 @@
 			label = "Power Button";
 			gpios = <&gpio1 29 GPIO_ACTIVE_LOW>;
 			linux,code = <KEY_POWER>;
-			gpio-key,wakeup;
+			wakeup-source;
 		};
 	};
 };

--
2.7.4

reviewer
#1 lore raw

PATCH 1/1 ARM: dts: imx6q: replace gpio-key,wakeup with wakeup-source for Utilite Pro

Quoted 5 lines · Sudeep Holla

Though the keyboard driver for GPIO buttons(gpio-keys) will continue to check for/support the legacy "gpio-key,wakeup" boolean property to enable gpio buttons as wakeup source, "wakeup-source" is the new standard binding.

Quoted 8 lines

This patch replaces the legacy "gpio-key,wakeup" with the unified "wakeup-source" property in order to avoid any further copy-paste duplication.

Cc Shawn Guo <[email protected]>
Cc Sascha Hauer <[email protected]>
Cc Fabio Estevam <[email protected]>
Signed-off-by Sudeep Holla <[email protected]>
Reviewed-by Fabio Estevam <[email protected]>
Applied
#2 lore raw

PATCH 1/1 ARM: dts: imx6q: replace gpio-key,wakeup with wakeup-source for Utilite Pro

In reply to Sudeep Holla
Quoted 5 lines · Sudeep Holla

Though the keyboard driver for GPIO buttons(gpio-keys) will continue to check for/support the legacy "gpio-key,wakeup" boolean property to enable gpio buttons as wakeup source, "wakeup-source" is the new standard binding.

Quoted 8 lines

This patch replaces the legacy "gpio-key,wakeup" with the unified "wakeup-source" property in order to avoid any further copy-paste duplication.

Cc Shawn Guo <[email protected]>
Cc Sascha Hauer <[email protected]>
Cc Fabio Estevam <[email protected]>
Signed-off-by Sudeep Holla <[email protected]>

Applied, thanks.