Skip to contentSkip to conversation

Add a libfdt function to write a property placeholder

PATCH Simon Glass 2 participants 2 messages Nov 15, 2016 – Nov 16, 2016 3 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): 1477353294-15212-1-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org

#2 lore raw

Hi David,

Quoted 14 lines · Simon Glass

The existing function to add a new property to a tree being built requires that the entire contents of the new property be passed in. For some applications it is more convenient to be able to add the property contents later, perhaps by reading from a file. This avoids double-buffering of the contents.

Add a new function to support this and adjust the existing fdt_property() to use it.

---

Changes in v2:
- Add tests

Quoted 8 lines
 libfdt/fdt_sw.c                    | 16 ++++++++++++++--
 libfdt/libfdt.h                    | 16 ++++++++++++++++
 tests/include7.dts                 |  1 +
 tests/sw_tree1.c                   |  5 +++++
 tests/test_tree1.dts               |  1 +
 tests/test_tree1_label_noderef.dts |  1 +
 tests/trees.S                      |  2 ++
 7 files changed, 40 insertions(+), 2 deletions(-)

Did you see this one?

Regards,
SImon

A message that is not in the archive (sent off-list or not yet received): CAPnjgZ10ZR1sycDZYxvQs=sAM9rCV0irXatqMt0KPm-PCkQmYg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#4 lore raw
Quoted 26 lines · Simon Glass

Hi David,

Quoted 14 lines · Simon Glass

The existing function to add a new property to a tree being built requires that the entire contents of the new property be passed in. For some applications it is more convenient to be able to add the property contents later, perhaps by reading from a file. This avoids double-buffering of the contents.

Add a new function to support this and adjust the existing fdt_property() to use it.

---

Changes in v2:
- Add tests

Quoted 8 lines
 libfdt/fdt_sw.c                    | 16 ++++++++++++++--
 libfdt/libfdt.h                    | 16 ++++++++++++++++
 tests/include7.dts                 |  1 +
 tests/sw_tree1.c                   |  5 +++++
 tests/test_tree1.dts               |  1 +
 tests/test_tree1_label_noderef.dts |  1 +
 tests/trees.S                      |  2 ++
 7 files changed, 40 insertions(+), 2 deletions(-)
Quoted 1 line

Did you see this one?

No, somehow I missed it.

Signature · 4 lines
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson