Skip to contentSkip to conversation

libdbus-c++: added recipe for it

PATCH In review Thilo Cestonaro 2 participants 5 messages Nov 16, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libdbus-c++: added recipe for it

to fix the build, two patches where needed.

One which just adds an include of unistd.h, as the functions pipe, write and close defined by this include, weren't defined.

The other patch enables the build to build the tools of libdbus-c++ for the target, which, without the patch, will always be build for the host, even when cross compiling.

---
 .../fix-missing-unistd.h-include.patch             | 12 +++++++++++
 .../remove-CXX_FOR_BUILD-stuff.patch               | 24 ++++++++++++++++++++++
 meta-oe/recipes-core/dbus/libdbus-c++_0.9.0.bb     | 24 ++++++++++++++++++++++
 3 files changed, 60 insertions(+)
 create mode 100644 meta-oe/recipes-core/dbus/libdbus-c++-0.9.0/fix-missing-unistd.h-include.patch
 create mode 100644 meta-oe/recipes-core/dbus/libdbus-c++-0.9.0/remove-CXX_FOR_BUILD-stuff.patch
 create mode 100644 meta-oe/recipes-core/dbus/libdbus-c++_0.9.0.bb
meta-oe/recipes-core/dbus/libdbus-c++-0.9.0/fix-missing-unistd.h-include.patch new file +12 -0
new file mode 100644
index 0000000..5cb8096
@@ -0,0 +1,12 @@
+diff --git a/include/dbus-c++/eventloop-integration.h b/include/dbus-c++/eventloop-integration.h
+index 1b0302e..3e44304 100644
+--- a/include/dbus-c++/eventloop-integration.h
++++ b/include/dbus-c++/eventloop-integration.h
+@@ -26,6 +26,7 @@
+ #define __DBUSXX_EVENTLOOP_INTEGRATION_H
+ 
+ #include <errno.h>
++#include <unistd.h>
+ #include "api.h"
+ #include "dispatcher.h"
+ #include "util.h"
meta-oe/recipes-core/dbus/libdbus-c++-0.9.0/remove-CXX_FOR_BUILD-stuff.patch new file +24 -0
new file mode 100644
index 0000000..906470a
@@ -0,0 +1,24 @@
+diff -Naur libdbus-c++-0.9.0.ori/configure.ac libdbus-c++-0.9.0/configure.ac
+--- libdbus-c++-0.9.0.ori/configure.ac	2016-11-15 14:25:36.085882774 +0100
++++ libdbus-c++-0.9.0/configure.ac	2016-11-15 14:27:08.814568717 +0100
+@@ -64,9 +64,6 @@
+ AC_PROG_CC
+ AC_PROG_CXX
+ 
+-CXX_FOR_BUILD=${CXX_FOR_BUILD-${CXX}}
+-AC_SUBST(CXX_FOR_BUILD)
+-
+ AM_PROG_LIBTOOL
+ 
+ PKG_PROG_PKG_CONFIG
+diff -Naur libdbus-c++-0.9.0.ori/tools/Makefile.am libdbus-c++-0.9.0/tools/Makefile.am
+--- libdbus-c++-0.9.0.ori/tools/Makefile.am	2016-11-15 14:25:36.089882803 +0100
++++ libdbus-c++-0.9.0/tools/Makefile.am	2016-11-15 14:26:19.454203583 +0100
+@@ -1,7 +1,5 @@
+ # hacky, but ...
+ 
+-CXX = $(CXX_FOR_BUILD)
+-
+ AM_CPPFLAGS = \
+ 	$(dbus_CFLAGS) \
+ 	$(xml_CFLAGS) \
meta-oe/recipes-core/dbus/libdbus-c++_0.9.0.bb new file +24 -0
new file mode 100644
index 0000000..7edaffc
@@ -0,0 +1,24 @@
+SUMMARY = "DBus-C++ Library"
+DESCRIPTION = "DBus-c++ attempts to provide a C++ API for D-BUS. The library has a glib and an Ecore mainloop integration. It also offers an optional own main loop."
+HOMEPAGE = "http://dbus-cplusplus.sourceforge.net"
+SECTION = "base"
+LICENSE = "LGPLv2.1"
+LIC_FILES_CHKSUM = "file://COPYING;md5=fbc093901857fcd118f065f900982c24"
+DEPENDS = "dbus glib-2.0 libpcre"
+
+SRC_URI = "${SOURCEFORGE_MIRROR}/project/dbus-cplusplus/dbus-c++/${PV}/${BPN}-${PV}.tar.gz \
+		   file://fix-missing-unistd.h-include.patch \
+		   file://remove-CXX_FOR_BUILD-stuff.patch"
+SRC_URI[md5sum] = "e752116f523fa88ef041e63d3dee4de2"
+SRC_URI[sha256sum] = "bc11ac297b3cb010be904c72789695543ee3fdf3d75cdc8225fd371385af4e61"
+
+EXTRA_OECONF = "--disable-ecore --disable-examples --disable-tests"
+
+inherit autotools pkgconfig
+
+PACKAGES += "${PN}-tools"
+
+FILES_${PN} = "${libdir}"
+FILES_${PN}-tools = "${bindir}"
+
+BBCLASSEXTEND = "native"
Signature · 1 line
2.10.2
#1 lore raw
Quoted 8 lines · Thilo Cestonaro

to fix the build, two patches where needed.

One which just adds an include of unistd.h, as the functions pipe, write and close defined by this include, weren't defined.

The other patch enables the build to build the tools of libdbus-c++ for the target, which, without the patch, will always be build for the host, even when cross compiling.

You need to include this information on top of the patch files themselves. So that when people look at the patches, they can immediately see what they are for, without digging through commit history. And also patches are still missing Upstream-Status, and Signed-off-by lines (I asked you about it earlier). Have a look at any other recipe patch in oe-core to see how it should look like.

Do read http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines please.

Alex

#2 lore raw

Hey Alex,

the whole mail is the patch. I send it via git send-email and there is the signed off line in it. But I can attach it and send it manually with my mail program if the git send-email thing is no good.

Regards,
Thilo

Am Mittwoch, den 16.11.2016, 17:27 +0200 schrieb Alexander Kanavin:

Quoted 22 lines · Thilo Cestonaro
Quoted 8 lines

to fix the build, two patches where needed.

One which just adds an include of unistd.h, as the functions pipe, write and close defined by this include, weren't defined.

The other patch enables the build to build the tools of libdbus-c++ for the target, which, without the patch, will always be build for the host, even when cross compiling.

You need to include this information on top of the patch files themselves. So that when people look at the patches, they can immediately see what they are for, without digging through commit history. And also patches are still missing Upstream-Status, and Signed-off-by lines (I asked you about it earlier). Have a look at any other recipe patch in oe-core to see how it should look like.

Do read http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
please.

Alex

#3 lore raw
Quoted 4 lines · On 11/16/2016 05:42 PM, [email protected] wrote:

the whole mail is the patch. I send it via git send-email and there is the signed off line in it. But I can attach it and send it manually with my mail program if the git send-email thing is no good.

The patch that you are sending adds three files: one recipe and two patches. It is those two patches that you need to fix. Their filenames are fix-missing-unistd.h-include.patch and remove-CXX_FOR_BUILD-stuff.patch. Is this clear?

Alex

#4 lore raw

Am Mittwoch, den 16.11.2016, 17:53 +0200 schrieb Alexander Kanavin:

Quoted 11 lines · On 11/16/2016 05:42 PM, [email protected] wrote:
Quoted 4 lines

the whole mail is the patch. I send it via git send-email and there is the signed off line in it. But I can attach it and send it manually with my mail program if the git send-email thing is no good.

The patch that you are sending adds three files: one recipe and two patches. It is those two patches that you need to fix. Their filenames are fix-missing-unistd.h-include.patch and remove-CXX_FOR_BUILD-stuff.patch. Is this clear?

Sorry, that wasn't clear. Will fix this! Thanks for you're patience! :)

Quoted 3 lines

Alex