Skip to contentSkip to conversation

drivers:dfu:dfu_sf: Fix upload - add partition/altsetting start address

PATCH New michael.hennerich at analog.com 2 participants 2 messages Nov 16, 2016

lore
Share & tools
lore

michael.hennerich at analog.com

author
#0 lore raw

PATCH 1/1 drivers:dfu:dfu_sf: Fix upload - add partition/altsetting start address

From: Michael Hennerich <[email protected]>

This fixes a bug seen with DFU Serial Flash upload/medium-read in case dfu->data.sf.start > 0.

Signed-off-by Michael Hennerich <[email protected]>
---
 drivers/dfu/dfu_sf.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/dfu/dfu_sf.c +2 -1
index 9702eee..51c9b7f 100644
@@ -20,7 +20,8 @@ static long dfu_get_medium_size_sf(struct dfu_entity *dfu)
 static int dfu_read_medium_sf(struct dfu_entity *dfu, u64 offset, void *buf,
 		long *len)
 {
-	return spi_flash_read(dfu->data.sf.dev, offset, *len, buf);
+	return spi_flash_read(dfu->data.sf.dev, dfu->data.sf.start + offset,
+			      *len, buf);
 }
 
 static u64 find_sector(struct dfu_entity *dfu, u64 start, u64 offset)
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 drivers:dfu:dfu_sf: Fix upload - add partition/altsetting start address

Hi michael.hennerich at analog.com,

Quoted 22 lines

From: Michael Hennerich <[email protected]>

This fixes a bug seen with DFU Serial Flash upload/medium-read in case dfu->data.sf.start > 0.

Signed-off-by Michael Hennerich <[email protected]>
---
 drivers/dfu/dfu_sf.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/dfu/dfu_sf.c +0 -0
index 9702eee..51c9b7f 100644
@@ -20,7 +20,8 @@ static long dfu_get_medium_size_sf(struct

dfu_entity *dfu) static int dfu_read_medium_sf(struct dfu_entity *dfu, u64 offset, void *buf, long *len)
{

drivers/dfu/dfu_sf.c +1 -1
-	return spi_flash_read(dfu->data.sf.dev, offset, *len, buf);
+	return spi_flash_read(dfu->data.sf.dev, dfu->data.sf.start +

offset,

drivers/dfu/dfu_sf.c static long dfu_get_medium_size_sf(struct dfu_entity *dfu) · line 27

Quoted 4 lines
drivers/dfu/dfu_sf.c +1 -0
+			      *len, buf);
 }
 
 static u64 find_sector(struct dfu_entity *dfu, u64 start, u64 offset)

Thanks for the patch.

Acked-by Lukasz Majewski <[email protected]>

Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group