Skip to contentSkip to conversation

clk: berlin: Pass correct type to hw provider registration

PATCH Applied Stephen Boyd 1 participant 2 messages Nov 16, 2016 – Nov 17, 2016 Common clk

lore
Share & tools
lore

Stephen Boyd

author
#0 lore raw

PATCH 1/1 clk: berlin: Pass correct type to hw provider registration

Dan Carpenter reports that we're passing a pointer to a pointer here when we should just be passing a pointer. Pass the right pointer so that the of_clk_hw_onecell_get() sees the appropriate data pointer on its end.

Reported-by Dan Carpenter <[email protected]>
Cc Jisheng Zhang <[email protected]>
Cc Alexandre Belloni <[email protected]>
Cc Sebastian Hesselbarth <[email protected]>
Cc Stephen Boyd <[email protected]>
Fixes f6475e298297 ("clk: berlin: Migrate to clk_hw based registration and OF APIs")
Signed-off-by Stephen Boyd <[email protected]>
---
 drivers/clk/berlin/bg2.c  | 2 +-
 drivers/clk/berlin/bg2q.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/clk/berlin/bg2.c +1 -1
index edf3b96b3b73..1d99292e2039 100644
@@ -685,7 +685,7 @@ static void __init berlin2_clock_setup(struct device_node *np)
 	}
 
 	/* register clk-provider */
-	of_clk_add_hw_provider(np, of_clk_hw_onecell_get, &clk_data);
+	of_clk_add_hw_provider(np, of_clk_hw_onecell_get, clk_data);
 
 	return;
drivers/clk/berlin/bg2q.c +1 -1
index 0718e831475f..3b784b593afd 100644
@@ -382,7 +382,7 @@ static void __init berlin2q_clock_setup(struct device_node *np)
 	}
 
 	/* register clk-provider */
-	of_clk_add_hw_provider(np, of_clk_hw_onecell_get, &clk_data);
+	of_clk_add_hw_provider(np, of_clk_hw_onecell_get, clk_data);
 
 	return;
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
author Applied
#1 lore raw
Quoted 5 lines · Stephen Boyd

Dan Carpenter reports that we're passing a pointer to a pointer here when we should just be passing a pointer. Pass the right pointer so that the of_clk_hw_onecell_get() sees the appropriate data pointer on its end.

Quoted 8 lines
Reported-by Dan Carpenter <[email protected]>
Cc Jisheng Zhang <[email protected]>
Cc Alexandre Belloni <[email protected]>
Cc Sebastian Hesselbarth <[email protected]>
Cc Stephen Boyd <[email protected]>
Fixes f6475e298297 ("clk: berlin: Migrate to clk_hw based registration and OF APIs")
Signed-off-by Stephen Boyd <[email protected]>

---

Applied to clk-fixes

Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project