Skip to contentSkip to conversation

openobex: upgrade to 1.7.2

PATCH In review Chen Qi 3 participants 4 messages Nov 17, 2016 – Nov 22, 2016

lore
Share & tools
lore

Chen Qi

author
#0 lore raw

PATCH v2 1/1 openobex: upgrade to 1.7.2

Add a patch to resolve segment fault in obex-check-device. Disable generation of documentation.

---
 .../obex/openobex-1.5/disable-cable-test.patch     | 16 ----------
 .../openobex-1.5/libusb_crosscompile_check.patch   | 11 -------
 .../obex/openobex-1.5/separate_builddir.patch      | 16 ----------
 ...001-obex-check-device-avoid-segment-fault.patch | 29 ++++++++++++++++++
 meta-oe/recipes-connectivity/obex/openobex_1.5.bb  | 35 ----------------------
 .../recipes-connectivity/obex/openobex_1.7.2.bb    | 33 ++++++++++++++++++++
 6 files changed, 62 insertions(+), 78 deletions(-)
 delete mode 100644 meta-oe/recipes-connectivity/obex/openobex-1.5/disable-cable-test.patch
 delete mode 100644 meta-oe/recipes-connectivity/obex/openobex-1.5/libusb_crosscompile_check.patch
 delete mode 100644 meta-oe/recipes-connectivity/obex/openobex-1.5/separate_builddir.patch
 create mode 100644 meta-oe/recipes-connectivity/obex/openobex/0001-obex-check-device-avoid-segment-fault.patch
 delete mode 100644 meta-oe/recipes-connectivity/obex/openobex_1.5.bb
 create mode 100644 meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb
meta-oe/recipes-connectivity/obex/openobex-1.5/disable-cable-test.patch deleted +0 -16
deleted file mode 100644
index 95b636d..0000000
@@ -1,16 +0,0 @@
-
-#
-# Patch managed by http://www.holgerschurig.de/patcher.html
-#
-
---- openobex-1.2/apps/Makefile.am~disable-cable-test
-+++ openobex-1.2/apps/Makefile.am
-@@ -6,7 +6,7 @@
- 	obex_io.c obex_io.h \
- 	obex_put_common.c obex_put_common.h
- 
--bin_PROGRAMS = irxfer obex_tcp irobex_palm3 obex_test
-+bin_PROGRAMS = irxfer obex_tcp irobex_palm3
- 
- obex_test_SOURCES = \
- 	obex_test.c obex_test.h \
meta-oe/recipes-connectivity/obex/openobex-1.5/libusb_crosscompile_check.patch deleted +0 -11
deleted file mode 100644
index 1177dfe..0000000
@@ -1,11 +0,0 @@
---- /tmp/acinclude.m4	2009-04-12 10:32:15.000000000 +0200
-+++ openobex-1.5/acinclude.m4	2009-04-12 10:32:38.000000000 +0200
-@@ -158,7 +158,7 @@
- 		;;
- 	*)
- 		PKG_CHECK_MODULES(USB, libusb, usb_lib_found=yes, AC_MSG_RESULT(no))
--		AC_CHECK_FILE(${prefix}/lib/pkgconfig/libusb.pc, REQUIRES="libusb")
-+		REQUIRES="libusb"
- 		;;
- 	esac
- 	AC_SUBST(USB_CFLAGS)
meta-oe/recipes-connectivity/obex/openobex-1.5/separate_builddir.patch deleted +0 -16
deleted file mode 100644
index 8abf8ae..0000000
@@ -1,16 +0,0 @@
-Fix detection of IrDA failing with B!=S
-
-Upstream-Status: Pending
-
-Signed-off-by: Paul Eggleton <[email protected]>
-
---- a/acinclude.m4	2014-05-24 14:05:41.757796816 +0100
-+++ b/acinclude.m4	2014-05-24 14:03:06.556795536 +0100
-@@ -54,6 +54,7 @@
- ])
- 
- AC_DEFUN([AC_PATH_IRDA_LINUX], [
-+	CPPFLAGS="${CPPFLAGS} -I${srcdir}"
- 	AC_CACHE_CHECK([for IrDA support], irda_found, [
- 		AC_TRY_COMPILE([
- 				#include <sys/socket.h>
meta-oe/recipes-connectivity/obex/openobex/0001-obex-check-device-avoid-segment-fault.patch new file +29 -0
new file mode 100644
index 0000000..d7c2681
@@ -0,0 +1,29 @@
+Subject: obex-check-device: avoid segment fault
+
+The argument number needs to be no less than 3 instead of 2. Otherwise,
+when we use `obex-check-device xxx' on target, there would be segment
+fault error.
+
+Upstream-Status: Pending
+
+Signed-off-by: Chen Qi <[email protected]>
+---
+ udev/obex-check-device.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/udev/obex-check-device.c b/udev/obex-check-device.c
+index 9eb4769..df9fc73 100644
+--- a/udev/obex-check-device.c
++++ b/udev/obex-check-device.c
+@@ -62,7 +62,7 @@ int main (int argc, char **argv)
+ 	unsigned long vendor;
+ 	unsigned long product;
+ 
+-	if (argc < 2)
++	if (argc < 3)
+ 		return 0;
+ 
+ 	vendor = strtoul(argv[1], NULL, 16);
+-- 
+2.8.3
+
meta-oe/recipes-connectivity/obex/openobex_1.5.bb deleted +0 -35
deleted file mode 100644
index 6ac7905..0000000
@@ -1,35 +0,0 @@
-DESCRIPTION = "The Openobex project is an open source implementation of the \
-Object Exchange (OBEX) protocol."
-HOMEPAGE = "http://openobex.triq.net"
-SECTION = "libs"
-DEPENDS = "virtual/libusb0"
-DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES','bluez5','bluez5','bluez4',d)}"
-
-LICENSE = "GPLv2 & LGPLv2.1"
-LIC_FILES_CHKSUM = "file://COPYING;md5=eb723b61539feef013de476e68b5c50a \
-                    file://COPYING.LIB;md5=a6f89e2100d9b6cdffcea4f398e37343 \
-"
-
-SRC_URI = "http://www.kernel.org/pub/linux/bluetooth/openobex-${PV}.tar.gz \
-           file://disable-cable-test.patch \
-           file://libusb_crosscompile_check.patch \
-           file://separate_builddir.patch"
-
-SRC_URI[md5sum] = "0d83dc86445a46a1b9750107ba7ab65c"
-SRC_URI[sha256sum] = "e602047570799a47ecb028420bda8f2cef41310e5a99d084de10aa9422935e65"
-
-inherit autotools binconfig pkgconfig
-
-EXTRA_OECONF = "--enable-apps --enable-syslog"
-
-do_install_append() {
-    install -d ${D}${datadir}/aclocal
-    install -m 0644 ${S}/openobex.m4 ${D}${datadir}/aclocal
-}
-
-PACKAGES += "openobex-apps"
-FILES_${PN} = "${libdir}/lib*.so.*"
-FILES_${PN}-dev += "${bindir}/openobex-config"
-FILES_${PN}-apps = "${bindir}/*"
-DEBIAN_NOAUTONAME_${PN}-apps = "1"
-
meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb new file +33 -0
new file mode 100644
index 0000000..948308e
@@ -0,0 +1,33 @@
+DESCRIPTION = "The Openobex project is an open source implementation of the \
+Object Exchange (OBEX) protocol."
+HOMEPAGE = "http://openobex.triq.net"
+SECTION = "libs"
+DEPENDS = "virtual/libusb0"
+DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES','bluez5','bluez5','bluez4',d)}"
+
+LICENSE = "GPLv2 & LGPLv2.1"
+LIC_FILES_CHKSUM = "file://COPYING;md5=eb723b61539feef013de476e68b5c50a \
+                    file://COPYING.LIB;md5=a6f89e2100d9b6cdffcea4f398e37343 \
+"
+
+SRC_URI = "http://downloads.sourceforge.net/openobex/openobex-${PV}-Source.tar.gz \
+           file://0001-obex-check-device-avoid-segment-fault.patch"
+
+SRC_URI[md5sum] = "f6e0b6cb7dcfd731460a7e9a91429a3a"
+SRC_URI[sha256sum] = "158860aaea52f0fce0c8e4b64550daaae06df2689e05834697b7e8c7d73dd4fc"
+
+inherit cmake
+
+S = "${WORKDIR}/openobex-${PV}-Source"
+
+EXTRA_OECMAKE += "-DCMAKE_BUILD_TYPE=Release -DBUILD_DOCUMENTATION=no"
+
+do_install_append () {
+    if [ "`ls -A ${D}${bindir}`" = "" ]; then
+	rm -rf ${D}${bindir}
+    fi
+}
+
+FILES_${PN}-dev += "${libdir}/cmake"
+
+
Signature · 1 line
2.8.3
#1 lore raw

Can you also take a look at

https://github.com/kraj/meta-openembedded/commit/3789eb98ee620916c47ba5f7c66bffd90a8a6161

and

https://github.com/kraj/meta-openembedded/commit/9d2100ee53b3c11324f998fde4c47ba371d03fae

As well. May be you can do a patch on top of them ?

Quoted 196 lines · Chen Qi

Add a patch to resolve segment fault in obex-check-device. Disable generation of documentation.

---
 .../obex/openobex-1.5/disable-cable-test.patch     | 16 ----------
 .../openobex-1.5/libusb_crosscompile_check.patch   | 11 -------
 .../obex/openobex-1.5/separate_builddir.patch      | 16 ----------
 ...001-obex-check-device-avoid-segment-fault.patch | 29 ++++++++++++++++++
 meta-oe/recipes-connectivity/obex/openobex_1.5.bb  | 35 ----------------------
 .../recipes-connectivity/obex/openobex_1.7.2.bb    | 33 ++++++++++++++++++++
 6 files changed, 62 insertions(+), 78 deletions(-)
 delete mode 100644 meta-oe/recipes-connectivity/obex/openobex-1.5/disable-cable-test.patch
 delete mode 100644 meta-oe/recipes-connectivity/obex/openobex-1.5/libusb_crosscompile_check.patch
 delete mode 100644 meta-oe/recipes-connectivity/obex/openobex-1.5/separate_builddir.patch
 create mode 100644 meta-oe/recipes-connectivity/obex/openobex/0001-obex-check-device-avoid-segment-fault.patch
 delete mode 100644 meta-oe/recipes-connectivity/obex/openobex_1.5.bb
 create mode 100644 meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb
meta-oe/recipes-connectivity/obex/openobex-1.5/disable-cable-test.patch deleted +0 -16
deleted file mode 100644
index 95b636d..0000000
@@ -1,16 +0,0 @@
-
-#
-# Patch managed by http://www.holgerschurig.de/patcher.html
-#
-
---- openobex-1.2/apps/Makefile.am~disable-cable-test
-+++ openobex-1.2/apps/Makefile.am
-@@ -6,7 +6,7 @@
- 	obex_io.c obex_io.h \
- 	obex_put_common.c obex_put_common.h
- 
--bin_PROGRAMS = irxfer obex_tcp irobex_palm3 obex_test
-+bin_PROGRAMS = irxfer obex_tcp irobex_palm3
- 
- obex_test_SOURCES = \
- 	obex_test.c obex_test.h \
meta-oe/recipes-connectivity/obex/openobex-1.5/libusb_crosscompile_check.patch deleted +0 -11
deleted file mode 100644
index 1177dfe..0000000
@@ -1,11 +0,0 @@
---- /tmp/acinclude.m4	2009-04-12 10:32:15.000000000 +0200
-+++ openobex-1.5/acinclude.m4	2009-04-12 10:32:38.000000000 +0200
-@@ -158,7 +158,7 @@
- 		;;
- 	*)
- 		PKG_CHECK_MODULES(USB, libusb, usb_lib_found=yes, AC_MSG_RESULT(no))
--		AC_CHECK_FILE(${prefix}/lib/pkgconfig/libusb.pc, REQUIRES="libusb")
-+		REQUIRES="libusb"
- 		;;
- 	esac
- 	AC_SUBST(USB_CFLAGS)
meta-oe/recipes-connectivity/obex/openobex-1.5/separate_builddir.patch deleted +0 -16
deleted file mode 100644
index 8abf8ae..0000000
@@ -1,16 +0,0 @@
-Fix detection of IrDA failing with B!=S
-
-Upstream-Status: Pending
-
-Signed-off-by: Paul Eggleton <[email protected]>
-
---- a/acinclude.m4	2014-05-24 14:05:41.757796816 +0100
-+++ b/acinclude.m4	2014-05-24 14:03:06.556795536 +0100
-@@ -54,6 +54,7 @@
- ])
- 
- AC_DEFUN([AC_PATH_IRDA_LINUX], [
-+	CPPFLAGS="${CPPFLAGS} -I${srcdir}"
- 	AC_CACHE_CHECK([for IrDA support], irda_found, [
- 		AC_TRY_COMPILE([
- 				#include <sys/socket.h>
meta-oe/recipes-connectivity/obex/openobex/0001-obex-check-device-avoid-segment-fault.patch new file +29 -0
new file mode 100644
index 0000000..d7c2681
@@ -0,0 +1,29 @@
+Subject: obex-check-device: avoid segment fault
+
+The argument number needs to be no less than 3 instead of 2. Otherwise,
+when we use `obex-check-device xxx' on target, there would be segment
+fault error.
+
+Upstream-Status: Pending
+
+Signed-off-by: Chen Qi <[email protected]>
+---
+ udev/obex-check-device.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/udev/obex-check-device.c b/udev/obex-check-device.c
+index 9eb4769..df9fc73 100644
+--- a/udev/obex-check-device.c
++++ b/udev/obex-check-device.c
+@@ -62,7 +62,7 @@ int main (int argc, char **argv)
+ 	unsigned long vendor;
+ 	unsigned long product;
+ 
+-	if (argc < 2)
++	if (argc < 3)
+ 		return 0;
+ 
+ 	vendor = strtoul(argv[1], NULL, 16);
+-- 
+2.8.3
+
meta-oe/recipes-connectivity/obex/openobex_1.5.bb deleted +0 -35
deleted file mode 100644
index 6ac7905..0000000
@@ -1,35 +0,0 @@
-DESCRIPTION = "The Openobex project is an open source implementation of the \
-Object Exchange (OBEX) protocol."
-HOMEPAGE = "http://openobex.triq.net"
-SECTION = "libs"
-DEPENDS = "virtual/libusb0"
-DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES','bluez5','bluez5','bluez4',d)}"
-
-LICENSE = "GPLv2 & LGPLv2.1"
-LIC_FILES_CHKSUM = "file://COPYING;md5=eb723b61539feef013de476e68b5c50a \
-                    file://COPYING.LIB;md5=a6f89e2100d9b6cdffcea4f398e37343 \
-"
-
-SRC_URI = "http://www.kernel.org/pub/linux/bluetooth/openobex-${PV}.tar.gz \
-           file://disable-cable-test.patch \
-           file://libusb_crosscompile_check.patch \
-           file://separate_builddir.patch"
-
-SRC_URI[md5sum] = "0d83dc86445a46a1b9750107ba7ab65c"
-SRC_URI[sha256sum] = "e602047570799a47ecb028420bda8f2cef41310e5a99d084de10aa9422935e65"
-
-inherit autotools binconfig pkgconfig
-
-EXTRA_OECONF = "--enable-apps --enable-syslog"
-
-do_install_append() {
-    install -d ${D}${datadir}/aclocal
-    install -m 0644 ${S}/openobex.m4 ${D}${datadir}/aclocal
-}
-
-PACKAGES += "openobex-apps"
-FILES_${PN} = "${libdir}/lib*.so.*"
-FILES_${PN}-dev += "${bindir}/openobex-config"
-FILES_${PN}-apps = "${bindir}/*"
-DEBIAN_NOAUTONAME_${PN}-apps = "1"
-
meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb new file +33 -0
new file mode 100644
index 0000000..948308e
@@ -0,0 +1,33 @@
+DESCRIPTION = "The Openobex project is an open source implementation of the \
+Object Exchange (OBEX) protocol."
+HOMEPAGE = "http://openobex.triq.net"
+SECTION = "libs"
+DEPENDS = "virtual/libusb0"
+DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES','bluez5','bluez5','bluez4',d)}"
+
+LICENSE = "GPLv2 & LGPLv2.1"
+LIC_FILES_CHKSUM = "file://COPYING;md5=eb723b61539feef013de476e68b5c50a \
+                    file://COPYING.LIB;md5=a6f89e2100d9b6cdffcea4f398e37343 \
+"
+
+SRC_URI = "http://downloads.sourceforge.net/openobex/openobex-${PV}-Source.tar.gz \
+           file://0001-obex-check-device-avoid-segment-fault.patch"
+
+SRC_URI[md5sum] = "f6e0b6cb7dcfd731460a7e9a91429a3a"
+SRC_URI[sha256sum] = "158860aaea52f0fce0c8e4b64550daaae06df2689e05834697b7e8c7d73dd4fc"
+
+inherit cmake
+
+S = "${WORKDIR}/openobex-${PV}-Source"
+
+EXTRA_OECMAKE += "-DCMAKE_BUILD_TYPE=Release -DBUILD_DOCUMENTATION=no"
+
+do_install_append () {
+    if [ "`ls -A ${D}${bindir}`" = "" ]; then
+	rm -rf ${D}${bindir}
+    fi
+}
+
+FILES_${PN}-dev += "${libdir}/cmake"
+
+
#2 lore raw
In reply to Chen Qi
Quoted 2 lines · Chen Qi

Add a patch to resolve segment fault in obex-check-device. Disable generation of documentation.

This is probably causing obexftp and obex-data-server issues:
http://errors.yoctoproject.org/Errors/Details/104698/
http://errors.yoctoproject.org/Errors/Details/104700/

reported in
http://lists.openembedded.org/pipermail/openembedded-devel/2016-November/109897.html

Quoted 201 lines
---
 .../obex/openobex-1.5/disable-cable-test.patch     | 16 ----------
 .../openobex-1.5/libusb_crosscompile_check.patch   | 11 -------
 .../obex/openobex-1.5/separate_builddir.patch      | 16 ----------
 ...001-obex-check-device-avoid-segment-fault.patch | 29 ++++++++++++++++++
 meta-oe/recipes-connectivity/obex/openobex_1.5.bb  | 35 ----------------------
 .../recipes-connectivity/obex/openobex_1.7.2.bb    | 33 ++++++++++++++++++++
 6 files changed, 62 insertions(+), 78 deletions(-)
 delete mode 100644 meta-oe/recipes-connectivity/obex/openobex-1.5/disable-cable-test.patch
 delete mode 100644 meta-oe/recipes-connectivity/obex/openobex-1.5/libusb_crosscompile_check.patch
 delete mode 100644 meta-oe/recipes-connectivity/obex/openobex-1.5/separate_builddir.patch
 create mode 100644 meta-oe/recipes-connectivity/obex/openobex/0001-obex-check-device-avoid-segment-fault.patch
 delete mode 100644 meta-oe/recipes-connectivity/obex/openobex_1.5.bb
 create mode 100644 meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb
meta-oe/recipes-connectivity/obex/openobex-1.5/disable-cable-test.patch deleted +0 -16
deleted file mode 100644
index 95b636d..0000000
@@ -1,16 +0,0 @@
-
-#
-# Patch managed by http://www.holgerschurig.de/patcher.html
-#
-
---- openobex-1.2/apps/Makefile.am~disable-cable-test
-+++ openobex-1.2/apps/Makefile.am
-@@ -6,7 +6,7 @@
- 	obex_io.c obex_io.h \
- 	obex_put_common.c obex_put_common.h
- 
--bin_PROGRAMS = irxfer obex_tcp irobex_palm3 obex_test
-+bin_PROGRAMS = irxfer obex_tcp irobex_palm3
- 
- obex_test_SOURCES = \
- 	obex_test.c obex_test.h \
meta-oe/recipes-connectivity/obex/openobex-1.5/libusb_crosscompile_check.patch deleted +0 -11
deleted file mode 100644
index 1177dfe..0000000
@@ -1,11 +0,0 @@
---- /tmp/acinclude.m4	2009-04-12 10:32:15.000000000 +0200
-+++ openobex-1.5/acinclude.m4	2009-04-12 10:32:38.000000000 +0200
-@@ -158,7 +158,7 @@
- 		;;
- 	*)
- 		PKG_CHECK_MODULES(USB, libusb, usb_lib_found=yes, AC_MSG_RESULT(no))
--		AC_CHECK_FILE(${prefix}/lib/pkgconfig/libusb.pc, REQUIRES="libusb")
-+		REQUIRES="libusb"
- 		;;
- 	esac
- 	AC_SUBST(USB_CFLAGS)
meta-oe/recipes-connectivity/obex/openobex-1.5/separate_builddir.patch deleted +0 -16
deleted file mode 100644
index 8abf8ae..0000000
@@ -1,16 +0,0 @@
-Fix detection of IrDA failing with B!=S
-
-Upstream-Status: Pending
-
-Signed-off-by: Paul Eggleton <[email protected]>
-
---- a/acinclude.m4	2014-05-24 14:05:41.757796816 +0100
-+++ b/acinclude.m4	2014-05-24 14:03:06.556795536 +0100
-@@ -54,6 +54,7 @@
- ])
- 
- AC_DEFUN([AC_PATH_IRDA_LINUX], [
-+	CPPFLAGS="${CPPFLAGS} -I${srcdir}"
- 	AC_CACHE_CHECK([for IrDA support], irda_found, [
- 		AC_TRY_COMPILE([
- 				#include <sys/socket.h>
meta-oe/recipes-connectivity/obex/openobex/0001-obex-check-device-avoid-segment-fault.patch new file +29 -0
new file mode 100644
index 0000000..d7c2681
@@ -0,0 +1,29 @@
+Subject: obex-check-device: avoid segment fault
+
+The argument number needs to be no less than 3 instead of 2. Otherwise,
+when we use `obex-check-device xxx' on target, there would be segment
+fault error.
+
+Upstream-Status: Pending
+
+Signed-off-by: Chen Qi <[email protected]>
+---
+ udev/obex-check-device.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/udev/obex-check-device.c b/udev/obex-check-device.c
+index 9eb4769..df9fc73 100644
+--- a/udev/obex-check-device.c
++++ b/udev/obex-check-device.c
+@@ -62,7 +62,7 @@ int main (int argc, char **argv)
+ 	unsigned long vendor;
+ 	unsigned long product;
+ 
+-	if (argc < 2)
++	if (argc < 3)
+ 		return 0;
+ 
+ 	vendor = strtoul(argv[1], NULL, 16);
+-- 
+2.8.3
+
meta-oe/recipes-connectivity/obex/openobex_1.5.bb deleted +0 -35
deleted file mode 100644
index 6ac7905..0000000
@@ -1,35 +0,0 @@
-DESCRIPTION = "The Openobex project is an open source implementation of the \
-Object Exchange (OBEX) protocol."
-HOMEPAGE = "http://openobex.triq.net"
-SECTION = "libs"
-DEPENDS = "virtual/libusb0"
-DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES','bluez5','bluez5','bluez4',d)}"
-
-LICENSE = "GPLv2 & LGPLv2.1"
-LIC_FILES_CHKSUM = "file://COPYING;md5=eb723b61539feef013de476e68b5c50a \
-                    file://COPYING.LIB;md5=a6f89e2100d9b6cdffcea4f398e37343 \
-"
-
-SRC_URI = "http://www.kernel.org/pub/linux/bluetooth/openobex-${PV}.tar.gz \
-           file://disable-cable-test.patch \
-           file://libusb_crosscompile_check.patch \
-           file://separate_builddir.patch"
-
-SRC_URI[md5sum] = "0d83dc86445a46a1b9750107ba7ab65c"
-SRC_URI[sha256sum] = "e602047570799a47ecb028420bda8f2cef41310e5a99d084de10aa9422935e65"
-
-inherit autotools binconfig pkgconfig
-
-EXTRA_OECONF = "--enable-apps --enable-syslog"
-
-do_install_append() {
-    install -d ${D}${datadir}/aclocal
-    install -m 0644 ${S}/openobex.m4 ${D}${datadir}/aclocal
-}
-
-PACKAGES += "openobex-apps"
-FILES_${PN} = "${libdir}/lib*.so.*"
-FILES_${PN}-dev += "${bindir}/openobex-config"
-FILES_${PN}-apps = "${bindir}/*"
-DEBIAN_NOAUTONAME_${PN}-apps = "1"
-
meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb new file +33 -0
new file mode 100644
index 0000000..948308e
@@ -0,0 +1,33 @@
+DESCRIPTION = "The Openobex project is an open source implementation of the \
+Object Exchange (OBEX) protocol."
+HOMEPAGE = "http://openobex.triq.net"
+SECTION = "libs"
+DEPENDS = "virtual/libusb0"
+DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES','bluez5','bluez5','bluez4',d)}"
+
+LICENSE = "GPLv2 & LGPLv2.1"
+LIC_FILES_CHKSUM = "file://COPYING;md5=eb723b61539feef013de476e68b5c50a \
+                    file://COPYING.LIB;md5=a6f89e2100d9b6cdffcea4f398e37343 \
+"
+
+SRC_URI = "http://downloads.sourceforge.net/openobex/openobex-${PV}-Source.tar.gz \
+           file://0001-obex-check-device-avoid-segment-fault.patch"
+
+SRC_URI[md5sum] = "f6e0b6cb7dcfd731460a7e9a91429a3a"
+SRC_URI[sha256sum] = "158860aaea52f0fce0c8e4b64550daaae06df2689e05834697b7e8c7d73dd4fc"
+
+inherit cmake
+
+S = "${WORKDIR}/openobex-${PV}-Source"
+
+EXTRA_OECMAKE += "-DCMAKE_BUILD_TYPE=Release -DBUILD_DOCUMENTATION=no"
+
+do_install_append () {
+    if [ "`ls -A ${D}${bindir}`" = "" ]; then
+	rm -rf ${D}${bindir}
+    fi
+}
+
+FILES_${PN}-dev += "${libdir}/cmake"
+
+
Signature · 7 lines
2.8.3

-- 
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#3 lore raw

I am sending patches which should fix these too

Quoted 257 lines · Martin Jansa
Quoted 2 lines · Chen Qi

Add a patch to resolve segment fault in obex-check-device. Disable generation of documentation.

This is probably causing obexftp and obex-data-server issues:
http://errors.yoctoproject.org/Errors/Details/104698/
http://errors.yoctoproject.org/Errors/Details/104700/

reported in
http://lists.openembedded.org/pipermail/openembedded-devel/
2016-November/109897.html

Quoted 7 lines
---
 .../obex/openobex-1.5/disable-cable-test.patch     | 16 ----------
 .../openobex-1.5/libusb_crosscompile_check.patch   | 11 -------
 .../obex/openobex-1.5/separate_builddir.patch      | 16 ----------
 ...001-obex-check-device-avoid-segment-fault.patch | 29

++++++++++++++++++

Quoted 1 line
 meta-oe/recipes-connectivity/obex/openobex_1.5.bb  | 35

----------------------

Quoted 1 line
 .../recipes-connectivity/obex/openobex_1.7.2.bb    | 33

++++++++++++++++++++

Quoted 2 lines
 6 files changed, 62 insertions(+), 78 deletions(-)
 delete mode 100644 meta-oe/recipes-connectivity/

obex/openobex-1.5/disable-cable-test.patch

Quoted 1 line
 delete mode 100644 meta-oe/recipes-connectivity/

obex/openobex-1.5/libusb_crosscompile_check.patch

Quoted 1 line
 delete mode 100644 meta-oe/recipes-connectivity/

obex/openobex-1.5/separate_builddir.patch

Quoted 1 line
 create mode 100644 meta-oe/recipes-connectivity/

obex/openobex/0001-obex-check-device-avoid-segment-fault.patch

Review

Quoted 4 lines
 delete mode 100644 meta-oe/recipes-connectivity/obex/openobex_1.5.bb
 create mode 100644 meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb
(quoted diff) +0 -0

b/meta-oe/recipes-connectivity/obex/openobex-1.5/disable-cable-test.patch

Quoted 3 lines

deleted file mode 100644
index 95b636d..0000000
--- a/meta-oe/recipes-connectivity/obex/openobex-1.

5/disable-cable-test.patch

Review

Quoted 19 lines

+++ /dev/null

meta-oe/recipes-connectivity/obex/openobex-1.5/disable-cable-test.patch deleted +0 -16
@@ -1,16 +0,0 @@
-
-#
-# Patch managed by http://www.holgerschurig.de/patcher.html
-#
-
---- openobex-1.2/apps/Makefile.am~disable-cable-test
-+++ openobex-1.2/apps/Makefile.am
-@@ -6,7 +6,7 @@
-     obex_io.c obex_io.h \
-     obex_put_common.c obex_put_common.h
-
--bin_PROGRAMS = irxfer obex_tcp irobex_palm3 obex_test
-+bin_PROGRAMS = irxfer obex_tcp irobex_palm3
-
- obex_test_SOURCES = \
-     obex_test.c obex_test.h \
(quoted diff) +0 -0

5/libusb_crosscompile_check.patch b/meta-oe/recipes- connectivity/obex/openobex-1.5/libusb_crosscompile_check.patch

Quoted 3 lines

deleted file mode 100644
index 1177dfe..0000000
--- a/meta-oe/recipes-connectivity/obex/openobex-1.

5/libusb_crosscompile_check.patch

meta-oe/recipes-connectivity/obex/openobex-1.5/libusb_crosscompile_check.patch line 6

Quoted 8 lines

+++ /dev/null

meta-oe/recipes-connectivity/obex/openobex-1.5/libusb_crosscompile_check.patch deleted +0 -6
@@ -1,11 +0,0 @@
---- /tmp/acinclude.m4        2009-04-12 10:32:15.000000000 +0200
-+++ openobex-1.5/acinclude.m4        2009-04-12 10:32:38.000000000 +0200
-@@ -158,7 +158,7 @@
-             ;;
-     *)
-             PKG_CHECK_MODULES(USB, libusb, usb_lib_found=yes,

AC_MSG_RESULT(no))

Review line 7

Quoted 1 line
(quoted diff) +0 -1
--            AC_CHECK_FILE(${prefix}/lib/pkgconfig/libusb.pc,

REQUIRES="libusb")

Review

Quoted 5 lines
meta-oe/recipes-connectivity/obex/openobex-1.5/libusb_crosscompile_check.patch deleted +0 -4
-+            REQUIRES="libusb"
-             ;;
-     esac
-     AC_SUBST(USB_CFLAGS)
(quoted diff) +0 -0

b/meta-oe/recipes-connectivity/obex/openobex-1.5/separate_builddir.patch

Quoted 3 lines

deleted file mode 100644
index 8abf8ae..0000000
--- a/meta-oe/recipes-connectivity/obex/openobex-1.

5/separate_builddir.patch

Review

Quoted 19 lines

+++ /dev/null

meta-oe/recipes-connectivity/obex/openobex-1.5/separate_builddir.patch deleted +0 -16
@@ -1,16 +0,0 @@
-Fix detection of IrDA failing with B!=S
-
-Upstream-Status: Pending
-
-Signed-off-by: Paul Eggleton <[email protected]>
-
---- a/acinclude.m4   2014-05-24 14:05:41.757796816 +0100
-+++ b/acinclude.m4   2014-05-24 14:03:06.556795536 +0100
-@@ -54,6 +54,7 @@
- ])
-
- AC_DEFUN([AC_PATH_IRDA_LINUX], [
-+    CPPFLAGS="${CPPFLAGS} -I${srcdir}"
-     AC_CACHE_CHECK([for IrDA support], irda_found, [
-             AC_TRY_COMPILE([
-                             #include <sys/socket.h>
(quoted diff) +0 -0

0001-obex-check-device-avoid-segment-fault.patch b/meta-oe/recipes- connectivity/obex/openobex/0001-obex-check-device-avoid- segment-fault.patch

meta-oe/recipes-connectivity/obex/openobex/

Quoted 4 lines

new file mode 100644
index 0000000..d7c2681

meta-oe/recipes-connectivity/obex/openobex/ new file +0 -0

0001-obex-check-device-avoid-segment-fault.patch

Review

Quoted 31 lines
meta-oe/recipes-connectivity/obex/openobex/ new file +29 -0
@@ -0,0 +1,29 @@
+Subject: obex-check-device: avoid segment fault
+
+The argument number needs to be no less than 3 instead of 2. Otherwise,
+when we use `obex-check-device xxx' on target, there would be segment
+fault error.
+
+Upstream-Status: Pending
+
+Signed-off-by: Chen Qi <[email protected]>
+---
+ udev/obex-check-device.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/udev/obex-check-device.c b/udev/obex-check-device.c
+index 9eb4769..df9fc73 100644
+--- a/udev/obex-check-device.c
++++ b/udev/obex-check-device.c
+@@ -62,7 +62,7 @@ int main (int argc, char **argv)
+     unsigned long vendor;
+     unsigned long product;
+
+-    if (argc < 2)
++    if (argc < 3)
+             return 0;
+
+     vendor = strtoul(argv[1], NULL, 16);
+--
+2.8.3
+
(quoted diff) +0 -0

b/meta-oe/recipes-connectivity/obex/openobex_1.5.bb

meta-oe/recipes-connectivity/obex/openobex_1.5.bb line 1

Quoted 6 lines

deleted file mode 100644
index 6ac7905..0000000

meta-oe/recipes-connectivity/obex/openobex_1.5.bb deleted +0 -1
@@ -1,35 +0,0 @@
-DESCRIPTION = "The Openobex project is an open source implementation of

the \

meta-oe/recipes-connectivity/obex/openobex_1.5.bb

Quoted 5 lines
meta-oe/recipes-connectivity/obex/openobex_1.5.bb deleted +0 -5
-Object Exchange (OBEX) protocol."
-HOMEPAGE = "http://openobex.triq.net"
-SECTION = "libs"
-DEPENDS = "virtual/libusb0"
-DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES','bluez5','bluez5','

bluez4',d)}"

meta-oe/recipes-connectivity/obex/openobex_1.5.bb

Quoted 3 lines
meta-oe/recipes-connectivity/obex/openobex_1.5.bb deleted +0 -3
-
-LICENSE = "GPLv2 & LGPLv2.1"
-LIC_FILES_CHKSUM = "file://COPYING;md5=eb723b61539feef013de476e68b5c50a

\

meta-oe/recipes-connectivity/obex/openobex_1.5.bb line 10

Quoted 1 line
meta-oe/recipes-connectivity/obex/openobex_1.5.bb deleted +0 -1
-                    file://COPYING.LIB;md5=

a6f89e2100d9b6cdffcea4f398e37343 \

meta-oe/recipes-connectivity/obex/openobex_1.5.bb

Quoted 3 lines
meta-oe/recipes-connectivity/obex/openobex_1.5.bb deleted +0 -3
-"
-
-SRC_URI = "http://www.kernel.org/pub/linux/bluetooth/openobex-${PV}

.tar.gz \

meta-oe/recipes-connectivity/obex/openobex_1.5.bb

Quoted 6 lines
meta-oe/recipes-connectivity/obex/openobex_1.5.bb deleted +0 -6
-           file://disable-cable-test.patch \
-           file://libusb_crosscompile_check.patch \
-           file://separate_builddir.patch"
-
-SRC_URI[md5sum] = "0d83dc86445a46a1b9750107ba7ab65c"
-SRC_URI[sha256sum] = "e602047570799a47ecb028420bda8f

2cef41310e5a99d084de10aa9422935e65"

Review

Quoted 17 lines
meta-oe/recipes-connectivity/obex/openobex_1.5.bb deleted +0 -16
-
-inherit autotools binconfig pkgconfig
-
-EXTRA_OECONF = "--enable-apps --enable-syslog"
-
-do_install_append() {
-    install -d ${D}${datadir}/aclocal
-    install -m 0644 ${S}/openobex.m4 ${D}${datadir}/aclocal
-}
-
-PACKAGES += "openobex-apps"
-FILES_${PN} = "${libdir}/lib*.so.*"
-FILES_${PN}-dev += "${bindir}/openobex-config"
-FILES_${PN}-apps = "${bindir}/*"
-DEBIAN_NOAUTONAME_${PN}-apps = "1"
-
(quoted diff) +0 -0

b/meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb

meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb line 1

Quoted 6 lines

new file mode 100644
index 0000000..948308e

meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb new file +1 -0
@@ -0,0 +1,33 @@
+DESCRIPTION = "The Openobex project is an open source implementation of

the \

meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb

Quoted 5 lines
meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb new file +5 -0
+Object Exchange (OBEX) protocol."
+HOMEPAGE = "http://openobex.triq.net"
+SECTION = "libs"
+DEPENDS = "virtual/libusb0"
+DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES','bluez5','bluez5','

bluez4',d)}"

meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb

Quoted 3 lines
meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb new file +3 -0
+
+LICENSE = "GPLv2 & LGPLv2.1"
+LIC_FILES_CHKSUM = "file://COPYING;md5=eb723b61539feef013de476e68b5c50a

\

meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb line 10

Quoted 1 line
meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb new file +1 -0
+                    file://COPYING.LIB;md5=

a6f89e2100d9b6cdffcea4f398e37343 \

meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb

Quoted 3 lines
meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb new file +3 -0
+"
+
+SRC_URI = "http://downloads.sourceforge.net/openobex/openobex-${PV}-

Source.tar.gz \

meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb

Quoted 4 lines
meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb new file +4 -0
+           file://0001-obex-check-device-avoid-segment-fault.patch"
+
+SRC_URI[md5sum] = "f6e0b6cb7dcfd731460a7e9a91429a3a"
+SRC_URI[sha256sum] = "158860aaea52f0fce0c8e4b64550da

aae06df2689e05834697b7e8c7d73dd4fc"

Quoted 19 lines
meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb new file +16 -1
+
+inherit cmake
+
+S = "${WORKDIR}/openobex-${PV}-Source"
+
+EXTRA_OECMAKE += "-DCMAKE_BUILD_TYPE=Release -DBUILD_DOCUMENTATION=no"
+
+do_install_append () {
+    if [ "`ls -A ${D}${bindir}`" = "" ]; then
+     rm -rf ${D}${bindir}
+    fi
+}
+
+FILES_${PN}-dev += "${libdir}/cmake"
+
+
--

2.8.3

Quoted 5 lines

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
Martin 'JaMa' Jansa jabber: [email protected]

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel