Skip to contentSkip to conversation

python-protobuf: Allow host building

PATCH New William A. Kennington III 2 participants 5 messages Nov 17, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 python-protobuf: Allow host building

Currently python-protobuf does not allow the building as a host package during a cross compile. We would like to be able to build nanopb as a host package but can't without host-python-protobuf.

Google-Bug-Id: 28000875

Change-Id Id09f461bda3f9c7a0bd6b5c36a6a8fa92e4adb27
---
  package/python-protobuf/python-protobuf.mk | 1 +
  1 file changed, 1 insertion(+)
(quoted diff) +0 -0

b/package/python-protobuf/python-protobuf.mk
index d8be76d..d46bda2 100644

package/python-protobuf/python-protobuf.mk +1 -0
@@ -13,4 +13,5 @@ PYTHON_PROTOBUF_DEPENDENCIES = host-protobuf
  PYTHON_PROTOBUF_SETUP_TYPE = setuptools
  PYTHON_PROTOBUF_SUBDIR = python
 
+$(eval $(host-python-package))
  $(eval $(python-package))
Signature · 1 line
2.10.2
#1 lore raw

PATCH 1/1 python-protobuf: Allow host building

Hello,

Quoted 7 lines · William A. Kennington III

Currently python-protobuf does not allow the building as a host package during a cross compile. We would like to be able to build nanopb as a host package but can't without host-python-protobuf.

Google-Bug-Id: 28000875

Change-Id Id09f461bda3f9c7a0bd6b5c36a6a8fa92e4adb27

Thanks for this contribution!

However, we don't really like to have "orphan" host packages, i.e host packages that are not a dependency of anything else in Buildroot.

Do you intend to submit a Buildroot package for nanopb? Even if it's a host package, it would probably be OK to have it in package/Config.in.host so that it appears in menuconfig.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 python-protobuf: Allow host building

Thomas,

The intention is to add nanopb as a host package for use in a library that will also eventually be added. I can just add that to this patch series if needed. I've never sent PR's via mail so I figured i would start with a tiny one to try things out which is why I didn't also send nanopb. Unfortunately the library depending on nanopb can't be added at this time but I plan to have it upstream within a month.

Thanks,
William

Quoted 20 lines · Thomas Petazzoni

Hello,

Quoted 7 lines · William A. Kennington III

Currently python-protobuf does not allow the building as a host package during a cross compile. We would like to be able to build nanopb as a host package but can't without host-python-protobuf.

Google-Bug-Id: 28000875

Change-Id Id09f461bda3f9c7a0bd6b5c36a6a8fa92e4adb27

Thanks for this contribution!

However, we don't really like to have "orphan" host packages, i.e host packages that are not a dependency of anything else in Buildroot.

Do you intend to submit a Buildroot package for nanopb? Even if it's a host package, it would probably be OK to have it in package/Config.in.host so that it appears in menuconfig.

Quoted 8 lines

Thanks,

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20161117/0be4cc79/attachment.html>

#3 lore raw

PATCH 1/1 python-protobuf: Allow host building

Hello,

Quoted 4 lines · William Kennington

The intention is to add nanopb as a host package for use in a library that will also eventually be added. I can just add that to this patch series if needed. I've never sent PR's via mail so I figured i would start with a tiny one to try things out which is why I didn't also send nanopb.

OK, understood.

Quoted 2 lines

Unfortunately the library depending on nanopb can't be added at this time but I plan to have it upstream within a month.

It would be great to send the whole thing as a patch series:

PATCH 1: adds the host variant of python-protobuf
PATCH 2: adds the host nanopb package
PATCH 3: adds the library that itself needs the host nanopb package

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#4 lore raw

PATCH 1/1 python-protobuf: Allow host building

Sounds good, closed. I'll submit the new patch series when it is ready.

Quoted 22 lines · Thomas Petazzoni

Hello,

Quoted 1 line · William Kennington

The intention is to add nanopb as a host package for use in a library

that

Quoted 1 line

will also eventually be added. I can just add that to this patch series

if

Quoted 2 lines

needed. I've never sent PR's via mail so I figured i would start with a tiny one to try things out which is why I didn't also send nanopb.

OK, understood.

Quoted 2 lines

Unfortunately the library depending on nanopb can't be added at this time but I plan to have it upstream within a month.

It would be great to send the whole thing as a patch series:

PATCH 1: adds the host variant of python-protobuf
PATCH 2: adds the host nanopb package
PATCH 3: adds the library that itself needs the host nanopb package

Quoted 8 lines

Thanks!

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20161117/8b23a748/attachment.html>