arm64: remove "SMP: Total of %d processors activated." message
PATCH 1/1 arm64: remove "SMP: Total of %d processors activated." message
There is a common SMP boot message in generic code on all arches, kill "SMP: Total of %d processors activated." in smp_cpus_done() on arm64.
---
Boot message on qemu.
[ 0.375116] smp: Brought up 1 node, 8 CPUs [ 0.383749] SMP: Total of 8 processors activated.
arch/arm64/kernel/smp.c | 1 - 1 file changed, 1 deletion(-)
arch/arm64/kernel/smp.c +0 -1
@@ -428,7 +428,6 @@ static void __init hyp_mode_check(void)void __init smp_cpus_done (unsigned int max_cpus) { -pr_info ("SMP: Total of %d processors activated.\n" ,num_online_cpus ());setup_cpu_features ();hyp_mode_check ();apply_alternatives_all ();
Signature · 1 line
1.7.12.4
PATCH 1/1 arm64: remove "SMP: Total of %d processors activated." message
Quoted 18 lines · Kefeng Wang
There is a common SMP boot message in generic code on all arches, kill "SMP: Total of %d processors activated." in
smp_cpus_done()on arm64.Signed-off-by Kefeng Wang <[email protected]>---
Boot message on qemu.[ 0.375116] smp: Brought up 1 node, 8 CPUs [ 0.383749] SMP: Total of 8 processors activated.arch/arm64/kernel/smp.c | 1 - 1 file changed, 1 deletion(-)arch/arm64/kernel/smp.c +0
-0
arch/arm64/kernel/smp.c static void __init hyp_mode_check(void) · line 433
Quoted 7 lines
arch/arm64/kernel/smp.c +0
-1@@ -428,7 +428,6 @@ static void __init hyp_mode_check(void)void __init smp_cpus_done (unsigned int max_cpus) { -pr_info ("SMP: Total of %d processors activated.\n" ,num_online_cpus ());setup_cpu_features ();hyp_mode_check ();apply_alternatives_all ();
Why? Are you proposing the same change to other architectures? Are you paid per patch?
Will
PATCH 1/1 arm64: remove "SMP: Total of %d processors activated." message
Quoted 20 lines · Will Deacon
Quoted 19 lines · Kefeng Wang
There is a common SMP boot message in generic code on all arches, kill "SMP: Total of %d processors activated." in
smp_cpus_done()on arm64.Signed-off-by Kefeng Wang <[email protected]>---
Boot message on qemu.[ 0.375116] smp: Brought up 1 node, 8 CPUs [ 0.383749] SMP: Total of 8 processors activated.arch/arm64/kernel/smp.c | 1 - 1 file changed, 1 deletion(-)arch/arm64/kernel/smp.c +0
-0@@ -428,7 +428,6 @@ static void __init hyp_mode_check(void)
Quoted 9 lines
arch/arm64/kernel/smp.c static void __init hyp_mode_check(void) · line 433
Quoted 6 lines
arch/arm64/kernel/smp.c +0
-1void __init smp_cpus_done (unsigned int max_cpus) { -pr_info ("SMP: Total of %d processors activated.\n" ,num_online_cpus ());setup_cpu_features ();hyp_mode_check ();apply_alternatives_all ();Why? Are you proposing the same change to other architectures? Are you paid per patch?
The message provides no further information than the generic code, so kill it. Or show BogoMIPS like arm32?
arch/arm64/kernel/smp.c +11 -1
@@ -428,7 +428,17 @@ static void __init hyp_mode_check(void)void __init smp_cpus_done (unsigned int max_cpus) { -pr_info ("SMP: Total of %d processors activated.\n" ,num_online_cpus ()); +int cpu; +unsigned long bogosum =0 ; + +for_each_online_cpu (cpu) + bogosum += loops_per_jiffy; + +pr_info ("SMP: Total of %d processors activated " +"(%lu.%02lu BogoMIPS).\n" , +num_online_cpus (), + bogosum / (500000 /HZ ), + (bogosum / (5000 /HZ )) %100 );setup_cpu_features ();hyp_mode_check ();apply_alternatives_all ()
Quoted 5 lines
Will
.
PATCH 1/1 arm64: remove "SMP: Total of %d processors activated." message
Quoted 33 lines · Kefeng Wang
Quoted 20 lines · Will Deacon
Quoted 19 lines · Kefeng Wang
There is a common SMP boot message in generic code on all arches, kill "SMP: Total of %d processors activated." in
smp_cpus_done()on arm64.Signed-off-by Kefeng Wang <[email protected]>---
Boot message on qemu.[ 0.375116] smp: Brought up 1 node, 8 CPUs [ 0.383749] SMP: Total of 8 processors activated.arch/arm64/kernel/smp.c | 1 - 1 file changed, 1 deletion(-)arch/arm64/kernel/smp.c +0
-0@@ -428,7 +428,6 @@ static void __init hyp_mode_check(void)Quoted 9 lines
arch/arm64/kernel/smp.c static void __init hyp_mode_check(void)
Quoted 6 lines
arch/arm64/kernel/smp.c +0
-1void __init smp_cpus_done (unsigned int max_cpus) { -pr_info ("SMP: Total of %d processors activated.\n" ,num_online_cpus ());setup_cpu_features ();hyp_mode_check ();apply_alternatives_all ();Why? Are you proposing the same change to other architectures? Are you paid per patch?
Quoted 2 lines
The message provides no further information than the generic code, so kill it. Or show BogoMIPS like arm32?
Ha! No, I don't think printing the BogoMIPS is the right solution. I just think that, if you insist on removing the harmless print, then you should also consider doing the same thing for all the other architectures that print the same message.
Will
PATCH 1/1 arm64: remove "SMP: Total of %d processors activated." message
Quoted 8 lines · Will Deacon
Quoted 2 lines · Kefeng Wang
The message provides no further information than the generic code, so kill it. Or show BogoMIPS like arm32?
Ha! No, I don't think printing the BogoMIPS is the right solution. I just think that, if you insist on removing the harmless print, then you should also consider doing the same thing for all the other architectures that print the same message.
Note that I'd removed the redundant message from ARM a long time ago, until Linus reverted the patch due to the /proc/cpuinfo part.
Signature · 3 lines
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.