ARM: dts: omap5: replace gpio-key, wakeup with wakeup-source property
PATCH 1/1 ARM: dts: omap5: replace gpio-key, wakeup with wakeup-source property
Though the keyboard driver for GPIO buttons(gpio-keys) will continue to check for/support the legacy "gpio-key,wakeup" boolean property to enable gpio buttons as wakeup source, "wakeup-source" is the new standard binding.
This patch replaces the legacy "gpio-key,wakeup" with the unified "wakeup-source" property in order to avoid any further copy-paste duplication.
--- arch/arm/boot/dts/omap5-uevm.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Hi,
Inspite of getting rid of most of the legacy property almost a year ago, addition of new platforms have brought this back and over time it's now found again in few places. Just get rid of them *again*
Regards,
Sudeep
arch/arm/boot/dts/omap5-uevm.dts +1 -1
@@ -41,7 +41,7 @@ label = "BTN1"; linux,code = <169>; gpios = <&gpio3 19 GPIO_ACTIVE_LOW>; /* gpio3_83 */ - gpio-key,wakeup; + wakeup-source; autorepeat; debounce_interval = <50>; };
--
2.7.4
PATCH 1/1 ARM: dts: omap5: replace gpio-key,wakeup with wakeup-source property
Quoted 16 lines · Sudeep Holla
Though the keyboard driver for GPIO buttons(gpio-keys) will continue to check for/support the legacy "gpio-key,wakeup" boolean property to enable gpio buttons as wakeup source, "wakeup-source" is the new standard binding.
This patch replaces the legacy "gpio-key,wakeup" with the unified "wakeup-source" property in order to avoid any further copy-paste duplication.
Cc "Beno?t Cousson" <[email protected]>Cc Tony Lindgren <[email protected]>Signed-off-by Sudeep Holla <[email protected]>--- arch/arm/boot/dts/omap5-uevm.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 5 lines
Hi,
Inspite of getting rid of most of the legacy property almost a year ago, addition of new platforms have brought this back and over time it's now found again in few places. Just get rid of them *again*
Thanks for the annual check up :)
Please let me know if you want me to pick this up instead.
Quoted 16 lines
arch/arm/boot/dts/omap5-uevm.dts +1
-2@@ -41,7 +41,7 @@ label = "BTN1"; linux,code = <169>; gpios = <&gpio3 19 GPIO_ACTIVE_LOW>; /* gpio3_83 */ - gpio-key,wakeup; + wakeup-source; autorepeat; debounce_interval = <50>; }; --2.7.4
PATCH 1/1 ARM: dts: omap5: replace gpio-key,wakeup with wakeup-source property
Quoted 23 lines · Tony Lindgren
Quoted 16 lines · Sudeep Holla
Though the keyboard driver for GPIO buttons(gpio-keys) will continue to check for/support the legacy "gpio-key,wakeup" boolean property to enable gpio buttons as wakeup source, "wakeup-source" is the new standard binding.
This patch replaces the legacy "gpio-key,wakeup" with the unified "wakeup-source" property in order to avoid any further copy-paste duplication.
Cc "Beno?t Cousson" <[email protected]>Cc Tony Lindgren <[email protected]>Signed-off-by Sudeep Holla <[email protected]>--- arch/arm/boot/dts/omap5-uevm.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Quoted 5 lines
Hi,
Inspite of getting rid of most of the legacy property almost a year ago, addition of new platforms have brought this back and over time it's now found again in few places. Just get rid of them *again*
Quoted 5 lines
Thanks for the annual check up :)
Acked-by Tony Lindgren <[email protected]>Please let me know if you want me to pick this up instead.
Yes that would be better. Also it's present only in your -next, looks like something newly added via commit 2d46c0c60725 ("ARM:
dts: omap5 uevm: add USR1 button")
Signature · 2 lines
Regards, Sudeep
PATCH 1/1 ARM: dts: omap5: replace gpio-key,wakeup with wakeup-source property
Quoted 28 lines · Sudeep Holla
Quoted 25 lines · Tony Lindgren
Quoted 16 lines · Sudeep Holla
Though the keyboard driver for GPIO buttons(gpio-keys) will continue to check for/support the legacy "gpio-key,wakeup" boolean property to enable gpio buttons as wakeup source, "wakeup-source" is the new standard binding.
This patch replaces the legacy "gpio-key,wakeup" with the unified "wakeup-source" property in order to avoid any further copy-paste duplication.
Cc "Beno?t Cousson" <[email protected]>Cc Tony Lindgren <[email protected]>Signed-off-by Sudeep Holla <[email protected]>--- arch/arm/boot/dts/omap5-uevm.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Quoted 5 lines
Hi,
Inspite of getting rid of most of the legacy property almost a year ago, addition of new platforms have brought this back and over time it's now found again in few places. Just get rid of them *again*
Thanks for the annual check up :)
Quoted 7 lines
Quoted 3 lines
Acked-by Tony Lindgren <[email protected]>Please let me know if you want me to pick this up instead.
Yes that would be better. Also it's present only in your -next, looks like something newly added via commit
2d46c0c60725("ARM:
dts: omap5 uevm: add USR1 button")
OK applied into omap-for-v4.10/dt:omap-for-v4.10/dt thanks.
Tony