sched/rt: Change rt_nr_running to rt_queued in the comment

PATCH Superseded T.Zhou 3 participants 5 messages Nov 18, 2016 – Nov 19, 2016 Scheduler

lore

Share & tools

lore

T.Zhou

author

2016-11-18 06:53 UTC #0 lore raw

PATCH 1/1 sched/rt: Change rt_nr_running to rt_queued in the comment

The code actually checks rt_queued not rt_nr_running in pick_next_task_rt(), so change the corresponding comment.

Signed-off-by T.Zhou <[email protected]>

---
 kernel/sched/rt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

kernel/sched/rt.c +1 -1

index 2516b8d..9b4a5c5 100644
@@ -1550,7 +1550,7 @@ pick_next_task_rt(struct rq *rq, struct task_struct *prev, struct pin_cookie coo
 
 	/*
 	 * We may dequeue prev's rt_rq in put_prev_task().
-	 * So, we update time before rt_nr_running check.
+	 * So, we update time before rt_queued check.
 	 */
 	if (prev->sched_class == &rt_sched_class)
 		update_curr_rt(rq);

Signature · 1 line

2.7.3

Steven Rostedt

reviewer Acked-by on v1 1/1

2016-11-18 14:53 UTC #1 lore raw

Peter,

Can you pull this patch into your queue?

Acked-by Steven Rostedt <[email protected]>

-- Steve

Quoted 22 lines · On Fri, 18 Nov 2016 14:39:04 +0800 "T.Zhou" <[email protected]> wrote:

The code actually checks rt_queued not rt_nr_running in pick_next_task_rt(), so change the corresponding comment.

Signed-off-by T.Zhou <[email protected]>

---
 kernel/sched/rt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

kernel/sched/rt.c +1 -1

index 2516b8d..9b4a5c5 100644
@@ -1550,7 +1550,7 @@ pick_next_task_rt(struct rq *rq, struct task_struct *prev, struct pin_cookie coo
 
 	/*
 	 * We may dequeue prev's rt_rq in put_prev_task().
-	 * So, we update time before rt_nr_running check.
+	 * So, we update time before rt_queued check.
 	 */
 	if (prev->sched_class == &rt_sched_class)
 		update_curr_rt(rq);