snsc: restore IRQs on error path in scdrv_write()

PATCH New Dan Carpenter 1 participant 1 message Nov 18, 2016

Subsystems (2)

Kernel janitors Char and misc drivers

lore

Share & tools

lore

Dan Carpenter

author

2016-11-18 11:30 UTC #0 lore raw

PATCH 1/1 snsc: restore IRQs on error path in scdrv_write()

This bug is as old as git. We need to be calling spin_unlock_irqrestore() instead of regular spin_unlock() here.

Signed-off-by Dan Carpenter <[email protected]>

drivers/char/snsc.c +1 -1

index 10e5632..ec07f0e 100644
@@ -285,7 +285,7 @@ scdrv_write(struct file *file, const char __user *buf,
 		DECLARE_WAITQUEUE(wait, current);
 
 		if (file->f_flags & O_NONBLOCK) {
-			spin_unlock(&sd->sd_wlock);
+			spin_unlock_irqrestore(&sd->sd_wlock, flags);
 			up(&sd->sd_wbs);
 			return -EAGAIN;
 		}