mailbox/tegra-hsp: Use after free in tegra_hsp_remove_doorbells()

PATCH In review Dan Carpenter 2 participants 2 messages Nov 18, 2016

Subsystems (3)

Kernel janitors Tegra architecture support Mailbox API

lore

Share & tools

lore

Dan Carpenter

author

2016-11-18 11:34 UTC #0 lore raw

PATCH 1/1 mailbox/tegra-hsp: Use after free in tegra_hsp_remove_doorbells()

We have to use the _safe version of list_for_each() because we're freeing the pointer as we go along. (This might not show up testing depending on what config options you have enabled).

Fixes ed65ee43e397 ("mailbox: Add Tegra HSP driver")

Signed-off-by Dan Carpenter <[email protected]>

drivers/mailbox/tegra-hsp.c +2 -2

index 17b256a..87be8d3 100644
@@ -397,12 +397,12 @@ static struct mbox_chan *of_tegra_hsp_xlate(struct mbox_controller *mbox,
 
 static void tegra_hsp_remove_doorbells(struct tegra_hsp *hsp)
 {
-	struct tegra_hsp_doorbell *db;
+	struct tegra_hsp_doorbell *db, *tmp;
 	unsigned long flags;
 
 	spin_lock_irqsave(&hsp->lock, flags);
 
-	list_for_each_entry(db, &hsp->doorbells, list)
+	list_for_each_entry_safe(db, tmp, &hsp->doorbells, list)
 		__tegra_hsp_doorbell_destroy(db);
 
 	spin_unlock_irqrestore(&hsp->lock, flags);

Thierry Reding

2016-11-18 13:31 UTC #1 lore raw

Quoted 6 lines · Dan Carpenter

We have to use the _safe version of list_for_each() because we're freeing the pointer as we go along. (This might not show up testing depending on what config options you have enabled).
Fixes ed65ee43e397 ("mailbox: Add Tegra HSP driver")
Signed-off-by Dan Carpenter <[email protected]>

Good catch! I've applied this on top of the original driver patch that Jassi acked earlier and I updated the Fixes: line with the new commit SHA1.

Thanks,
Thierry