Skip to contentSkip to conversation

: staging: Greybus: Remove unnecessary braces for single statement block

PATCH In review Rahul Krishnan 2 participants 2 messages Nov 18, 2016

Subsystems (3)
Staging Greybus Greybus SDIO/GPIO/SPI protocols drivers
lore
Share & tools
lore

Rahul Krishnan

author
#0 lore raw

PATCH v2 1/1 : staging: Greybus: Remove unnecessary braces for single statement block

This patch fixes the following checkpath.pl warning
WARNING: braces {} are not necessary for single statement blocks

Fixed indentation error, noted by Dan Carpenter

Signed-off-by Rahul Krishnan <[email protected]>
---
 drivers/staging/greybus/sdio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/greybus/sdio.c +1 -1
index f60b458..66b37ea 100644
@@ -192,7 +192,7 @@ static int _gb_sdio_process_events(struct gb_sdio_host *host, u8 event)
 	}
 
 	if (event & GB_SDIO_WP)
-	host->read_only = true;
+		host->read_only = true;
 
 	if (state_changed) {
 		dev_info(mmc_dev(host->mmc), "card %s now event\n",
Signature · 1 line
2.10.2
maintainer
#1 lore raw
Quoted 15 lines · Rahul Krishnan

This patch fixes the following checkpath.pl warning
WARNING: braces {} are not necessary for single statement blocks

Fixed indentation error, noted by Dan Carpenter

Signed-off-by Rahul Krishnan <[email protected]>
---
 drivers/staging/greybus/sdio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/greybus/sdio.c +0 -0
index f60b458..66b37ea 100644

drivers/staging/greybus/sdio.c static int _gb_sdio_process_events(struct gb_sdio_host *host, u8 event) · line 195

Quoted 5 lines
drivers/staging/greybus/sdio.c +1 -1
@@ -192,7 +192,7 @@ static int _gb_sdio_process_events(struct gb_sdio_host *host, u8 event)
 	}
 
 	if (event & GB_SDIO_WP)
-	host->read_only = true;
+		host->read_only = true;

You need to redo your original patch. This one instead looks like a follow-up to your first revision (which actually removed the braces).

drivers/staging/greybus/sdio.c static int _gb_sdio_process_events(struct gb_sdio_host *host, u8 event) · line 198

Quoted 3 lines
drivers/staging/greybus/sdio.c +0 -0
 	if (state_changed) {
 		dev_info(mmc_dev(host->mmc), "card %s now event\n",

Thanks,
Johan