Skip to contentSkip to conversation

: staging: Greybus: Remove unnecessary braces for single statement block

PATCH In review Rahul Krishnan 3 participants 3 messages Nov 18, 2016 – Nov 21, 2016

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 : staging: Greybus: Remove unnecessary braces for single statement block

This patch fixes the following checkpath.pl warning
WARNING: braces {} are not necessary for single statement blocks

---
 drivers/staging/greybus/sdio.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/greybus/sdio.c +1 -2
index 5649ef1..66b37ea 100644
@@ -191,9 +191,8 @@ static int _gb_sdio_process_events(struct gb_sdio_host *host, u8 event)
 		state_changed = 1;
 	}
 
-	if (event & GB_SDIO_WP) {
+	if (event & GB_SDIO_WP)
 		host->read_only = true;
-	}
 
 	if (state_changed) {
 		dev_info(mmc_dev(host->mmc), "card %s now event\n",
Signature · 1 line
2.10.2
maintainer Reviewed-by on v1 1/1
#1 lore raw

Hi Rahul,
Thanks for the patch.
Now looks great.

Quoted 5 lines · Rahul Krishnan

This patch fixes the following checkpath.pl warning
WARNING: braces {} are not necessary for single statement blocks

Quoted 22 lines

---
drivers/staging/greybus/sdio.c | 3 +--

1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/greybus/sdio.c +1 -2
index 5649ef1..66b37ea 100644
@@ -191,9 +191,8 @@ static int _gb_sdio_process_events(struct gb_sdio_host *host, u8 event)
 		state_changed = 1;
 	}
 
-	if (event & GB_SDIO_WP) {
+	if (event & GB_SDIO_WP)
 		host->read_only = true;
-	}
 
 	if (state_changed) {
 		dev_info(mmc_dev(host->mmc), "card %s now event\n",
Signature · 1 line
2.10.2