remoteproc: wcnss-pil: add QCOM_SMD dependency
PATCH 1/1 remoteproc: wcnss-pil: add QCOM_SMD dependency
When qcom_smd is a loadable module and adsp-pil is built-in, we get a link error:
drivers/remoteproc/qcom_wcnss_pil.o: In function `wcnss_smd_remove':
qcom_wcnss_iris.c:(.text.wcnss_smd_remove+0x10): undefined reference to qcom_smd_unregister_edge' drivers/remoteproc/qcom_wcnss_pil.o: In function wcnss_smd_probe':
qcom_wcnss_iris.c:(.text.wcnss_smd_probe+0x12): undefined reference to `qcom_smd_register_edge'
This adds a Kconfig dependency to avoid this. We can still allow build-testing with SMD disabled.
--- drivers/remoteproc/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/remoteproc/Kconfig +1 -0
@@ -106,6 +106,7 @@ config QCOM_Q6V5_PIL config QCOM_WCNSS_PIL tristate "Qualcomm WCNSS Peripheral Image Loader" depends on OF && ARCH_QCOM + depends on QCOM_SMD || (COMPILE_TEST && QCOM_SMD = n) depends on QCOM_SMEM depends on REMOTEPROC select QCOM_MDT_LOADER
Signature · 1 line
2.9.0
Bjorn Andersson
AppliedQuoted 8 lines · Arnd Bergmann
When
qcom_smdis a loadable module and adsp-pil is built-in, we get a link error:
drivers/remoteproc/qcom_wcnss_pil.o: In function `wcnss_smd_remove':
qcom_wcnss_iris.c:(.text.wcnss_smd_remove+0x10): undefined reference toqcom_smd_unregister_edge' drivers/remoteproc/qcom_wcnss_pil.o: In functionwcnss_smd_probe':
qcom_wcnss_iris.c:(.text.wcnss_smd_probe+0x12): undefined reference to `qcom_smd_register_edge'
Quoted 4 lines
This adds a
Kconfigdependency to avoid this. We can still allow build-testing with SMD disabled.Signed-off-by Arnd Bergmann <[email protected]>
Applied
Thanks,
Bjorn
Quoted 19 lines
--- drivers/remoteproc/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/remoteproc/Kconfig +1
-0@@ -106,6 +106,7 @@ config QCOM_Q6V5_PIL config QCOM_WCNSS_PIL tristate "Qualcomm WCNSS Peripheral Image Loader" depends on OF && ARCH_QCOM + depends on QCOM_SMD || (COMPILE_TEST && QCOM_SMD = n) depends on QCOM_SMEM depends on REMOTEPROC select QCOM_MDT_LOADERSignature · 1 line
2.9.0