Skip to contentSkip to conversation

sata: sata_mv: Fix misaligned cache warnings

PATCH New Stefan Roese 3 participants 5 messages Nov 18, 2016 – Dec 5, 2016 Block layer

lore
Share & tools
lore

Stefan Roese

author
#0 lore raw

PATCH 1/1 sata: sata_mv: Fix misaligned cache warnings

This patch fixes the warnings about misaligned cache on Armada XP:

CACHE: Misaligned operation at range [7facb400, 7facb460]

Signed-off-by Stefan Roese <[email protected]>
---
 drivers/block/sata_mv.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
drivers/block/sata_mv.c +9 -3
index 8d36f44..bbc75fe 100644
@@ -572,6 +572,7 @@ static int mv_ata_exec_ata_cmd(int port, struct sata_fis_h2d *cfis,
 	struct mv_priv *priv = (struct mv_priv *)sata_dev_desc[port].priv;
 	struct crqb *req;
 	int slot;
+	u32 start;
 
 	if (len >= 64 * 1024) {
 		printf("We only support <64K transfers for now\n");

@@ -628,7 +629,9 @@ static int mv_ata_exec_ata_cmd(int port, struct sata_fis_h2d *cfis,
 		CRQB_SECTCOUNT_COUNT_EXP_MASK;
 
 	/* Flush data */
-	flush_dcache_range((u32)req, (u32)req + sizeof(*req));
+	start = (u32)req & ~(ARCH_DMA_MINALIGN - 1);
+	flush_dcache_range(start,
+			   start + ALIGN(sizeof(*req), ARCH_DMA_MINALIGN));
 
 	/* Trigger operation */
 	slot = get_next_reqip(port);

@@ -643,8 +646,11 @@ static int mv_ata_exec_ata_cmd(int port, struct sata_fis_h2d *cfis,
 	process_responses(port);
 
 	/* Invalidate data on read */
-	if (buffer && len)
-		invalidate_dcache_range((u32)buffer, (u32)buffer + len);
+	if (buffer && len) {
+		start = (u32)buffer & ~(ARCH_DMA_MINALIGN - 1);
+		invalidate_dcache_range(start,
+					start + ALIGN(len, ARCH_DMA_MINALIGN));
+	}
 
 	return len;
 }
Signature · 1 line
2.10.2
author
#1 lore raw

PATCH 1/1 bootcounter_ram: Fix misaligned cache warning

This patch fixes the warning about misaligned cache on Armada XP:

CACHE: Misaligned operation at range [7ffff000, 7fffffac]

Signed-off-by Stefan Roese <[email protected]>
Cc Valentin Longchamp <[email protected]>
---
 drivers/bootcount/bootcount_ram.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/bootcount/bootcount_ram.c +2 -1
index e0d2669..ad4cc56 100644
@@ -37,7 +37,8 @@ void bootcount_store(ulong a)
 
 	/* Make sure the data is written to RAM */
 	flush_dcache_range((ulong)&save_addr[0],
-			   (ulong)&save_addr[REPEAT_PATTERN + OFFS_PATTERN]);
+			   (((ulong)&save_addr[REPEAT_PATTERN + OFFS_PATTERN] &
+			     ~(ARCH_DMA_MINALIGN - 1)) + ARCH_DMA_MINALIGN));
 }
 
 ulong bootcount_load(void)
Signature · 1 line
2.10.2
#2 lore raw

PATCH 1/1 bootcounter_ram: Fix misaligned cache warning

Quoted 6 lines · Stefan Roese

This patch fixes the warning about misaligned cache on Armada XP:

CACHE: Misaligned operation at range [7ffff000, 7fffffac]

Signed-off-by Stefan Roese <[email protected]>
Cc Valentin Longchamp <[email protected]>
Reviewed-by Tom Rini <[email protected]>
Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161121/461debc1/attachment.sig>
#3 lore raw

[U-Boot] bootcounter_ram: Fix misaligned cache warning

In reply to Stefan Roese
Quoted 7 lines · Stefan Roese

This patch fixes the warning about misaligned cache on Armada XP:

CACHE: Misaligned operation at range [7ffff000, 7fffffac]

Signed-off-by Stefan Roese <[email protected]>
Cc Valentin Longchamp <[email protected]>
Reviewed-by Tom Rini <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161128/3b348b97/attachment.sig>