Skip to contentSkip to conversation

phy: rockchip-inno-usb2: add extcon dependency

PATCH In review Arnd Bergmann 2 participants 2 messages Nov 18, 2016 Generic PHY framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 phy: rockchip-inno-usb2: add extcon dependency

If extcon is a loadable module and rockchip-inno-usb2 is built-in, we get a link failure:

drivers/phy/phy-rockchip-inno-usb2.o: In function `rockchip_usb2phy_probe':
phy-rockchip-inno-usb2.c:(.text.rockchip_usb2phy_probe+0x1ec): undefined reference to extcon_get_edev_by_phandle' phy-rockchip-inno-usb2.c:(.text.rockchip_usb2phy_probe+0x25c): undefined reference to devm_extcon_dev_allocate' phy-rockchip-inno-usb2.c:(.text.rockchip_usb2phy_probe+0x2a8): undefined reference to devm_extcon_dev_register' phy-rockchip-inno-usb2.c:(.text.rockchip_usb2phy_probe+0xa28): undefined reference to extcon_register_notifier'

Adding a hard dependency avoids the problem. Alternatively we could use "depends on EXTCON || !EXTCON" to allow building with extcon disabled completely, but the other PHY drivers with extcon support also just have a dependency, so this is more consistent.

Fixes 0c42fe48fd23 ("phy: rockchip-inno-usb2: support otg-port for rk3399")
---
 drivers/phy/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/phy/Kconfig +1 -0
index 53cab9f3323b..b135ff1ab12d 100644
@@ -366,6 +366,7 @@ config PHY_ROCKCHIP_INNO_USB2
 	depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF
 	depends on COMMON_CLK
 	depends on USB_SUPPORT
+	depends on EXTCON
 	select GENERIC_PHY
 	select USB_COMMON
 	help
Signature · 1 line
2.9.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Arnd Bergmann

If extcon is a loadable module and rockchip-inno-usb2 is built-in, we get a link failure:

drivers/phy/phy-rockchip-inno-usb2.o: In function `rockchip_usb2phy_probe':
phy-rockchip-inno-usb2.c:(.text.rockchip_usb2phy_probe+0x1ec): undefined reference to extcon_get_edev_by_phandle' phy-rockchip-inno-usb2.c:(.text.rockchip_usb2phy_probe+0x25c): undefined reference to devm_extcon_dev_allocate' phy-rockchip-inno-usb2.c:(.text.rockchip_usb2phy_probe+0x2a8): undefined reference to devm_extcon_dev_register' phy-rockchip-inno-usb2.c:(.text.rockchip_usb2phy_probe+0xa28): undefined reference to extcon_register_notifier'

Quoted 7 lines

Adding a hard dependency avoids the problem. Alternatively we could use "depends on EXTCON || !EXTCON" to allow building with extcon disabled completely, but the other PHY drivers with extcon support also just have a dependency, so this is more consistent.

Fixes 0c42fe48fd23 ("phy: rockchip-inno-usb2: support otg-port for rk3399")

Looking into the source, extcon support is now mandatory for this driver, so adding the dependency makes sense.

Quoted 19 lines
---
 drivers/phy/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/phy/Kconfig +1 -1
index 53cab9f3323b..b135ff1ab12d 100644
@@ -366,6 +366,7 @@ config PHY_ROCKCHIP_INNO_USB2
        depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF
        depends on COMMON_CLK
        depends on USB_SUPPORT
+       depends on EXTCON
        select GENERIC_PHY
        select USB_COMMON
        help
--

2.9.0