Skip to contentSkip to conversation

dmaengine: sun6i: fix the uninitialized value for v_lli

PATCH Applied Hao Zhang 2 participants 2 messages Nov 19, 2016 – Nov 25, 2016

Subsystems (2)
Arm/Allwinner sunXi SoC support dmaengine
lore
Share & tools
lore

Hao Zhang

author
#0 lore raw

PATCH v2 1/1 dmaengine: sun6i: fix the uninitialized value for v_lli

dma_pool_alloc does not initialize the value of the newly allocated block for the v_lli, and the uninitilize value make the tests failed which is on pine64 with dmatest.
we can fix it just change the "|=" to "=" for the v_lli->cfg.

Signed-off-by Hao Zhang <[email protected]>

---
v1: https://www.spinics.net/lists/arm-kernel/msg539966.html
Changes in v1:
-Remove ARM and add spaces after each tag in the title

 drivers/dma/sun6i-dma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dma/sun6i-dma.c +1 -1
index 8346199..a235878 100644
@@ -578,7 +578,7 @@ static struct dma_async_tx_descriptor *sun6i_dma_prep_dma_memcpy(
 
 	burst = convert_burst(8);
 	width = convert_buswidth(DMA_SLAVE_BUSWIDTH_4_BYTES);
-	v_lli->cfg |= DMA_CHAN_CFG_SRC_DRQ(DRQ_SDRAM) |
+	v_lli->cfg = DMA_CHAN_CFG_SRC_DRQ(DRQ_SDRAM) |
 		DMA_CHAN_CFG_DST_DRQ(DRQ_SDRAM) |
 		DMA_CHAN_CFG_DST_LINEAR_MODE |
 		DMA_CHAN_CFG_SRC_LINEAR_MODE |
Signature · 1 line
2.7.4
Applied
#1 lore raw
Quoted 4 lines · Hao Zhang

dma_pool_alloc does not initialize the value of the newly allocated block for the v_lli, and the uninitilize value make the tests failed which is on pine64 with dmatest.
we can fix it just change the "|=" to "=" for the v_lli->cfg.

Applied, thanks

Signature · 1 line
~Vinod