Skip to contentSkip to conversation

gpio: em: depnd on ARCH_SHMOBILE

PATCH In review Peter Robinson 3 participants 5 messages Nov 20, 2016 – Nov 24, 2016 GPIO

lore
Share & tools
lore

Peter Robinson

author
#0 lore raw

PATCH v2 1/1 gpio: em: depnd on ARCH_SHMOBILE

The GPIO_EM is part of the Renesas SoCs so depend on the arch.

Signed-off-by Peter Robinson <[email protected]>
---
 drivers/gpio/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

v1->v2:
- Add COMPILE_TEST

drivers/gpio/Kconfig +1 -1
index d011cb8..a09e237 100644
@@ -171,7 +171,7 @@ config GPIO_DWAPB
 
 config GPIO_EM
 	tristate "Emma Mobile GPIO"
-	depends on ARM && OF_GPIO
+	depends on (ARCH_SHMOBILE || COMPILE_TEST) && OF_GPIO
 	help
 	  Say yes here to support GPIO on Renesas Emma Mobile SoCs.
Signature · 1 line
2.9.3
#2 lore raw
In reply to Peter Robinson

CC linux-renesas-soc

Quoted 15 lines · Peter Robinson

The GPIO_EM is part of the Renesas SoCs so depend on the arch.

Signed-off-by Peter Robinson <[email protected]>
---
 drivers/gpio/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

v1->v2:
- Add COMPILE_TEST

drivers/gpio/Kconfig +0 -0
index d011cb8..a09e237 100644

drivers/gpio/Kconfig config GPIO_DWAPB · line 174

Quoted 5 lines
drivers/gpio/Kconfig +1 -1
@@ -171,7 +171,7 @@ config GPIO_DWAPB
 
 config GPIO_EM
        tristate "Emma Mobile GPIO"
-       depends on ARM && OF_GPIO
+       depends on (ARCH_SHMOBILE || COMPILE_TEST) && OF_GPIO

For ARM SoCs, ARCH_SHMOBILE is being phased out in favor of ARCH_RENESAS. Note that ARCH_SHMOBILE is also set for some SuperH SoCs.

However, ARCH_EMEV2 is even more suitable here.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#3 lore raw
Quoted 8 lines · Geert Uytterhoeven

drivers/gpio/Kconfig config GPIO_DWAPB · line 174

Quoted 6 lines · Peter Robinson

The GPIO_EM is part of the Renesas SoCs so depend on the arch.

config GPIO_EM
tristate "Emma Mobile GPIO"

drivers/gpio/Kconfig +1 -1
-       depends on ARM && OF_GPIO
+       depends on (ARCH_SHMOBILE || COMPILE_TEST) && OF_GPIO
Quoted 4 lines

For ARM SoCs, ARCH_SHMOBILE is being phased out in favor of ARCH_RENESAS. Note that ARCH_SHMOBILE is also set for some SuperH SoCs.

However, ARCH_EMEV2 is even more suitable here.

I fixed the patch in-tree to use ARCH_EMEV2 instead.

Thanks!

Yours,
Linus Walleij

author
#4 lore raw
Quoted 10 lines · Linus Walleij
Quoted 8 lines · Geert Uytterhoeven
Quoted 6 lines · Peter Robinson

The GPIO_EM is part of the Renesas SoCs so depend on the arch.

config GPIO_EM
tristate "Emma Mobile GPIO"

drivers/gpio/Kconfig +1 -1
-       depends on ARM && OF_GPIO
+       depends on (ARCH_SHMOBILE || COMPILE_TEST) && OF_GPIO
Quoted 6 lines
Quoted 4 lines

For ARM SoCs, ARCH_SHMOBILE is being phased out in favor of ARCH_RENESAS. Note that ARCH_SHMOBILE is also set for some SuperH SoCs.

However, ARCH_EMEV2 is even more suitable here.

I fixed the patch in-tree to use ARCH_EMEV2 instead.

Awesome, thanks, I was going to do a follow up patch.

Peter