Skip to contentSkip to conversation

spi: make architecture specific hardware depend on the associated hardware

PATCH In review Peter Robinson 3 participants 3 messages Nov 20, 2016 – Nov 21, 2016 1 message not in the archive SPI

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 spi: make architecture specific hardware depend on the associated hardware

There's not much point enabling hardware specific hardware drivers if the actual SoC architecture platforms aren't enabled as they're not much use with out it.

---
 drivers/spi/Kconfig | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

v1->v2:
- Add COMPILE_TEST to changes missing the option

drivers/spi/Kconfig +6 -4
index b799547..69730ac 100644
@@ -188,6 +188,7 @@ config SPI_BUTTERFLY
 
 config SPI_CADENCE
 	tristate "Cadence SPI controller"
+	depends on ARCH_ZYNQ || ARCH_ZYNQMP || COMPILE_TEST
 	help
 	  This selects the Cadence SPI controller master driver
 	  used by Xilinx Zynq and ZynqMP.
@@ -224,7 +225,7 @@ config SPI_DW_PCI
 
 config SPI_DW_MID_DMA
 	bool "DMA support for DW SPI controller on Intel MID platform"
-	depends on SPI_DW_PCI && DW_DMAC_PCI
+	depends on (X86 || COMPILE_TEST) && SPI_DW_PCI && DW_DMAC_PCI
 
 config SPI_DW_MMIO
 	tristate "Memory-mapped io interface driver for DW SPI core"
@@ -499,6 +500,7 @@ config SPI_PXA2XX_PCI
 
 config SPI_ROCKCHIP
 	tristate "Rockchip SPI controller driver"
+	depends on ARCH_ROCKCHIP || COMPILE_TEST
 	help
 	  This selects a driver for Rockchip SPI controller.
 
@@ -650,7 +652,7 @@ config SPI_TEGRA20_SLINK
 
 config SPI_THUNDERX
 	tristate "Cavium ThunderX SPI controller"
-	depends on PCI && 64BIT && (ARM64 || COMPILE_TEST)
+	depends on PCI && 64BIT && (ARCH_THUNDER || COMPILE_TEST)
 	help
 	  SPI host driver for the hardware found on Cavium ThunderX
 	  SOCs.
@@ -680,7 +682,7 @@ config SPI_XCOMM
 
 config SPI_XILINX
 	tristate "Xilinx SPI controller common module"
-	depends on HAS_IOMEM
+	depends on HAS_IOMEM && (ARCH_ZYNQ || ARCH_ZYNQMP || COMPILE_TEST)
 	select SPI_BITBANG
 	help
 	  This exposes the SPI controller IP from the Xilinx EDK.
@@ -715,7 +717,7 @@ config SPI_XTENSA_XTFPGA
 
 config SPI_ZYNQMP_GQSPI
 	tristate "Xilinx ZynqMP GQSPI controller"
-	depends on SPI_MASTER && HAS_DMA
+	depends on SPI_MASTER && HAS_DMA && (ARCH_ZYNQMP || COMPILE_TEST)
 	help
 	  Enables Xilinx GQSPI controller driver for Zynq UltraScale+ MPSoC.
 
Signature · 6 lines
2.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 20161120175505.2910-1-pbrobinson-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

#2 lore raw

drivers/spi/Kconfig config SPI_XCOMM · line 685

Quoted 4 lines · Peter Robinson

config SPI_XILINX

drivers/spi/Kconfig +1 -1
 	tristate "Xilinx SPI controller common module"
-	depends on HAS_IOMEM
+	depends on HAS_IOMEM && (ARCH_ZYNQ || ARCH_ZYNQMP || COMPILE_TEST)

I'm using this one on X86, or anything really that has PCIe support.

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw
In reply to a message not in the archive
Quoted 3 lines · Peter Robinson

There's not much point enabling hardware specific hardware drivers if the actual SoC architecture platforms aren't enabled as they're not much use with out it.

To repeat what I said last time please do make an effort to get this reviewed by the relevant driver maintainers.