Skip to contentSkip to conversation

openblas: disable OpenMP

PATCH New Arnout Vandecappelle (Essensium/Mind) 2 participants 2 messages Nov 20, 2016 – Nov 21, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 openblas: disable OpenMP

For powerpc (and powerpc only), the openblas build system will enable USE_OPENMP when threads are enabled. But the toolchain wasn't necessarily built with OpenMP support. So explicitly disable OpenMP - for all architectures, not just powerpc, just to keep things simple.

We could have autodetected whether OpenMP is available at configure time, but that would be more of a feature patch, it's up to upstream to do that.

Fixes:
http://autobuild.buildroot.net/results/423b5e79cd4342d6c160ed478054b294b0826c6a
http://autobuild.buildroot.net/results/c9e554c8f880b49b3c9203725ac5e6565b7e5c6f

---
 package/openblas/openblas.mk | 3 +++
 1 file changed, 3 insertions(+)
package/openblas/openblas.mk +3 -0
index 9583e0e..a26e10a 100644
@@ -31,6 +31,9 @@ else
 OPENBLAS_MAKE_OPTS += USE_THREAD=0
 endif
 
+# We don't know if OpenMP is available or not, so disable
+OPENBLAS_MAKE_OPTS += USE_OPENMP=0
+
 # Static-only/Shared-only toggle
 ifeq ($(BR2_STATIC_LIBS),y)
 OPENBLAS_MAKE_OPTS += NO_SHARED=1
Signature · 1 line
2.10.2
#1 lore raw

PATCH 1/1 openblas: disable OpenMP

Hello,

Quoted 9 lines · Arnout Vandecappelle (Essensium/Mind)

For powerpc (and powerpc only), the openblas build system will enable USE_OPENMP when threads are enabled. But the toolchain wasn't necessarily built with OpenMP support. So explicitly disable OpenMP - for all architectures, not just powerpc, just to keep things simple.

We could have autodetected whether OpenMP is available at configure time, but that would be more of a feature patch, it's up to upstream to do that.

Quoted 8 lines

Fixes:
http://autobuild.buildroot.net/results/423b5e79cd4342d6c160ed478054b294b0826c6a
http://autobuild.buildroot.net/results/c9e554c8f880b49b3c9203725ac5e6565b7e5c6f

---
 package/openblas/openblas.mk | 3 +++
 1 file changed, 3 insertions(+)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com