net: dsa: mv88e6xxx: egress all frames
Subsystems (4)
PATCH 1/1 net: dsa: mv88e6xxx: egress all frames
Egress multicast and egress unicast is only enabled for CPU/DSA ports but for switching operation it seems it should be enabled for all ports. Do I miss something here?
I did the following test:
brctl addbr br0
brctl addif br0 lan0
brctl addif br0 lan1
In this scenario the unicast and multicast packets were not forwarded, therefore ARP requests were not resolved, and no connection could be established.
If no bridge is configured we do not forward unicast and multicast packets because the VLAN mapping is active.
--- drivers/net/dsa/mv88e6xxx/chip.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
drivers/net/dsa/mv88e6xxx/chip.c +4 -5
@@ -2506,15 +2506,14 @@ static int mv88e6xxx_setup_port(struct mv88e6xxx_chip *chip, int port) mv88e6xxx_6185_family(chip) || mv88e6xxx_6320_family(chip)) reg =PORT_CONTROL_IGMP_MLD_SNOOP |PORT_CONTROL_USE_TAG |PORT_CONTROL_USE_IP | -PORT_CONTROL_STATE_FORWARDING ; +PORT_CONTROL_STATE_FORWARDING | +PORT_CONTROL_FORWARD_UNKNOWN_MC |PORT_CONTROL_FORWARD_UNKNOWN ;if (dsa_is_cpu_port (ds, port)) {if (mv88e6xxx_has (chip,MV88E6XXX_FLAG_EDSA )) - reg |=PORT_CONTROL_FRAME_ETHER_TYPE_DSA | -PORT_CONTROL_FORWARD_UNKNOWN_MC ; + reg |=PORT_CONTROL_FRAME_ETHER_TYPE_DSA ;else reg |=PORT_CONTROL_DSA_TAG ; - reg |=PORT_CONTROL_EGRESS_ADD_TAG | -PORT_CONTROL_FORWARD_UNKNOWN ; + reg |=PORT_CONTROL_EGRESS_ADD_TAG ; }if (dsa_is_dsa_port (ds, port)) { if (mv88e6xxx_6095_family(chip) ||
Signature · 1 line
2.9.3
Andrew Lunn
maintainerQuoted 4 lines · Stefan Eichenberger
Egress multicast and egress unicast is only enabled for CPU/DSA ports but for switching operation it seems it should be enabled for all ports. Do I miss something here?
Quoted 8 lines
I did the following test:
brctl addbr br0
brctl addif br0 lan0
brctl addif br0 lan1In this scenario the unicast and multicast packets were not forwarded, therefore ARP requests were not resolved, and no connection could be established.
Hi Stefan
This is probably specific to the 6097 family. It works fine without this on other devices. Creating a bridge like above and pinging across it is one of my standard tests. But i only test modern devices like the 6165, 6352, 6351, 6390 families.
In fact, you might need to review all the code and look where mv88e6xxx_6095_family(chip) is used and consider if you need to add mv88e6xxx_6097_family(chip). e.g.
if (mv88e6xxx_6095_family(chip) || mv88e6xxx_6185_family(chip)) {
/* Set the upstream port this port should use */
reg |= dsa_upstream_port(ds);
/* enable forwarding of unknown multicast addresses to
* the upstream port
*/
if (port == dsa_upstream_port(ds))
reg |= PORT_CONTROL_2_FORWARD_UNKNOWN;
}Maybe this is your problem?
Andrew
Hi Andrew
Quoted 14 lines · Andrew Lunn
Quoted 4 lines · Stefan Eichenberger
Egress multicast and egress unicast is only enabled for CPU/DSA ports but for switching operation it seems it should be enabled for all ports. Do I miss something here?
Quoted 8 lines
I did the following test:
brctl addbr br0
brctl addif br0 lan0
brctl addif br0 lan1In this scenario the unicast and multicast packets were not forwarded, therefore ARP requests were not resolved, and no connection could be established.
Quoted 6 lines
Hi Stefan
This is probably specific to the 6097 family. It works fine without this on other devices. Creating a bridge like above and pinging across it is one of my standard tests. But i only test modern devices like the 6165, 6352, 6351, 6390 families.
Okay perfect, I wasn't 100% sure if I would have to configure something additionally.
Quoted 15 lines
In fact, you might need to review all the code and look where
mv88e6xxx_6095_family(chip)is used and consider if you need to addmv88e6xxx_6097_family(chip). e.g.if (mv88e6xxx_6095_family(chip) || mv88e6xxx_6185_family(chip)) { /* Set the upstream port this port should use */ reg |= dsa_upstream_port(ds); /* enable forwarding of unknown multicast addresses to * the upstream port */ if (port == dsa_upstream_port(ds)) reg |= PORT_CONTROL_2_FORWARD_UNKNOWN; }
Quoted 1 line
Maybe this is your problem?
I think I still don't understand exactly how the driver works.
My problem is that the multicast and broadcast frames are filtered and the following counter is increasing in ethtool:sw_in_filtered: 596
This makes sense because "Egress Floods" in the Port Control Register is set to 0. What kind of mechanism should make sure that for example ARP packets are sent trough all ports anyway?
Unfortunately I don't have any devices available with more modern devices, so I can't double check the registers.
Regards,
Stefan
Andrew Lunn
maintainerQuoted 19 lines · Stefan Eichenberger
Hi Andrew
Quoted 16 lines · Andrew Lunn
Quoted 4 lines · Stefan Eichenberger
Egress multicast and egress unicast is only enabled for CPU/DSA ports but for switching operation it seems it should be enabled for all ports. Do I miss something here?
Quoted 8 lines
I did the following test:
brctl addbr br0
brctl addif br0 lan0
brctl addif br0 lan1In this scenario the unicast and multicast packets were not forwarded, therefore ARP requests were not resolved, and no connection could be established.
Hi Stefan
Quoted 7 lines
Quoted 4 lines
This is probably specific to the 6097 family. It works fine without this on other devices. Creating a bridge like above and pinging across it is one of my standard tests. But i only test modern devices like the 6165, 6352, 6351, 6390 families.
Okay perfect, I wasn't 100% sure if I would have to configure something additionally.
No. The idea is you treat the interfaces as normal interfaces. You should not need to do anything additional to what you would do with a normal interface, when adding it to a bridge.
Quoted 14 lines
Quoted 14 lines
In fact, you might need to review all the code and look where
mv88e6xxx_6095_family(chip)is used and consider if you need to addmv88e6xxx_6097_family(chip). e.g.if (mv88e6xxx_6095_family(chip) || mv88e6xxx_6185_family(chip)) { /* Set the upstream port this port should use */ reg |= dsa_upstream_port(ds); /* enable forwarding of unknown multicast addresses to * the upstream port */ if (port == dsa_upstream_port(ds)) reg |= PORT_CONTROL_2_FORWARD_UNKNOWN; }
Quoted 7 lines
Quoted 1 line
Maybe this is your problem?
I think I still don't understand exactly how the driver works.
My problem is that the multicast and broadcast frames are filtered and the following counter is increasing in ethtool:
sw_in_filtered: 596
This is not what is supposed to happen. Broadcast and multicast frames should go to all ports in the bridge. There are two different ways this can happen:
1) The mv88e6xxx driver started out with the host doing all bridge operations. The switch forwards all frames to the software bridge, and the software bridge then sends them out another port if needed.
2) We later added support for hardware bridging. That is, the switch itself bridges frames between ports. It will only pass frames to the software bridge if it does not know what to do with a frame itself.
Now, the different families are not 100% compatible with each other. We never had access to a 6097, so it has not been tested recently, and we have probably broken it... My guess would be, anywhere mv88e6xxx_6095_family(chip) is used, there also needs to be an mv88e6xxx_6097_family(chip). But i could be wrong.
What you might find useful is
https://github.com/vivien/linux.git 161b96bd7d16d21b0f046c935b70c3b2d277ccc2
although it might need some changes for recent commits.
With that, you can see deeper into the switches registers.
Andrew
Hi Andrew, Stefan,
Quoted 7 lines · Andrew Lunn
What you might find useful is
https://github.com/vivien/linux.git
161b96bd7d16d21b0f046c935b70c3b2d277ccc2although it might need some changes for recent commits.
With that, you can see deeper into the switches registers.
FYI, I have rebased it on top of the latest net-next (f9aa9dc7d2d0):
https://github.com/vivien/linux.git dsa/dev
Thanks,
Vivien
Hi Vivien
Quoted 8 lines · Vivien Didelot
Hi Andrew, Stefan,
Quoted 4 lines · Andrew Lunn
What you might find useful is
https://github.com/vivien/linux.git
161b96bd7d16d21b0f046c935b70c3b2d277ccc2
Quoted 8 lines
Quoted 3 lines
although it might need some changes for recent commits.
With that, you can see deeper into the switches registers.
FYI, I have rebased it on top of the latest net-next (
f9aa9dc7d2d0):
Perfect that is really helpful, thanks a lot!
Stefan
Quoted 58 lines · Andrew Lunn
Quoted 19 lines · Stefan Eichenberger
Hi Andrew
Quoted 16 lines · Andrew Lunn
Quoted 4 lines · Stefan Eichenberger
Egress multicast and egress unicast is only enabled for CPU/DSA ports but for switching operation it seems it should be enabled for all ports. Do I miss something here?
Quoted 8 lines
I did the following test:
brctl addbr br0
brctl addif br0 lan0
brctl addif br0 lan1In this scenario the unicast and multicast packets were not forwarded, therefore ARP requests were not resolved, and no connection could be established.
Hi Stefan
Quoted 7 lines
Quoted 4 lines
This is probably specific to the 6097 family. It works fine without this on other devices. Creating a bridge like above and pinging across it is one of my standard tests. But i only test modern devices like the 6165, 6352, 6351, 6390 families.
Okay perfect, I wasn't 100% sure if I would have to configure something additionally.
No. The idea is you treat the interfaces as normal interfaces. You should not need to do anything additional to what you would do with a normal interface, when adding it to a bridge.
Quoted 14 lines
Quoted 14 lines
In fact, you might need to review all the code and look where
mv88e6xxx_6095_family(chip)is used and consider if you need to addmv88e6xxx_6097_family(chip). e.g.if (mv88e6xxx_6095_family(chip) || mv88e6xxx_6185_family(chip)) { /* Set the upstream port this port should use */ reg |= dsa_upstream_port(ds); /* enable forwarding of unknown multicast addresses to * the upstream port */ if (port == dsa_upstream_port(ds)) reg |= PORT_CONTROL_2_FORWARD_UNKNOWN; }Quoted 7 lines
Quoted 1 line
Maybe this is your problem?
I think I still don't understand exactly how the driver works.
My problem is that the multicast and broadcast frames are filtered and the following counter is increasing in ethtool:
sw_in_filtered: 596This is not what is supposed to happen. Broadcast and multicast frames should go to all ports in the bridge. There are two different ways this can happen:
Quoted 7 lines
1) The mv88e6xxx driver started out with the host doing all bridge operations. The switch forwards all frames to the software bridge, and the software bridge then sends them out another port if needed.
2) We later added support for hardware bridging. That is, the switch itself bridges frames between ports. It will only pass frames to the software bridge if it does not know what to do with a frame itself.
Thanks for this explanation it helped a lot.
Quoted 6 lines
Now, the different families are not 100% compatible with each other. We never had access to a 6097, so it has not been tested recently, and we have probably broken it... My guess would be, anywhere
mv88e6xxx_6095_family(chip)is used, there also needs to be anmv88e6xxx_6097_family(chip). But i could be wrong.
I think I probably found the problem. For EDSA type switches the bit PORT_CONTROL_FORWARD_UNKNOWN_MC is set on the cpu port but not for DSA type switches. Broadcast addresses are threaded as multicast addresses, so unknown frames will never leave the switch.
Do you know if there is a reason why this bit isn't set for DSA type switches too? The patch would be extremely simple and it seems to work perfectly with this bit set on the CPU port.
Thanks
Stefan
Hi Stefan,
Quoted 10 lines · Stefan Eichenberger
Quoted 5 lines
Now, the different families are not 100% compatible with each other. We never had access to a 6097, so it has not been tested recently, and we have probably broken it... My guess would be, anywhere
mv88e6xxx_6095_family(chip)is used, there also needs to be anmv88e6xxx_6097_family(chip). But i could be wrong.I think I probably found the problem. For EDSA type switches the bit
PORT_CONTROL_FORWARD_UNKNOWN_MCis set on the cpu port but not for DSA type switches. Broadcast addresses are threaded as multicast addresses, so unknown frames will never leave the switch.
The Port Control Register (0x04) is one of these registers which changes almost completely among chip models.
Are you able to give us the layout of the port register 0x04 on your 88E6097? I don't have access to its datasheet.
For instance on 88E6185 bit 3 is reserved, on 88E6352 and 88E6390 bit 3:2 are "Egress Floods" and 0x2 means "Do not egress any frame with an unknown unicast DA".
Quoted 3 lines
Do you know if there is a reason why this bit isn't set for DSA type switches too? The patch would be extremely simple and it seems to work perfectly with this bit set on the CPU port.
All these family checks for bit masking are quite messy and ideally need proper abstraction...
Can you give us the chunk of patch you are refering to?
Thanks,
Vivien
Hi Vivien
Quoted 15 lines · Vivien Didelot
Hi Stefan,
Quoted 10 lines · Stefan Eichenberger
Quoted 5 lines
Now, the different families are not 100% compatible with each other. We never had access to a 6097, so it has not been tested recently, and we have probably broken it... My guess would be, anywhere
mv88e6xxx_6095_family(chip)is used, there also needs to be anmv88e6xxx_6097_family(chip). But i could be wrong.I think I probably found the problem. For EDSA type switches the bit
PORT_CONTROL_FORWARD_UNKNOWN_MCis set on the cpu port but not for DSA type switches. Broadcast addresses are threaded as multicast addresses, so unknown frames will never leave the switch.
Quoted 5 lines
The Port Control Register (
0x04) is one of these registers which changes almost completely among chip models.Are you able to give us the layout of the port register
0x04on your 88E6097? I don't have access to its datasheet.
Yes sure, the layout of the Port Control Register for the 88E6097 is the same as for the 88E6352:
15:14: SA Filtering: 00 -> SA filtering disabled
01 -> Drop on lock
10 -> Drop on Unlock
11 -> Drop to CPU
13:12: Egress Mode: 00 -> default unmodified mode
01 -> default to transmit all frames untagged
10 -> default to transmit all frames tagged
11 -> reserved for future use
11: Header: Ingress&Egress header mode (PORT_CONTROL_HEADER)
10: IGMP Snoop: IGMP/MLD Snooping (PORT_CONTROL_IGMP_MLD_SNOOP)
9:8 Frame Mode: 00 -> Normal Network
01 -> DSA (FRAME_MODE_DSA)
10 -> Provider (FRAME_MODE_PROVIDER)
11 -> Ether Type DSA (FRAME_ETHER_TYPE_DSA)
7: VLAN Tunnel: VLAN Tunnel (VLAN_TUNNEL)
6: TagIfBoth: Use tag info for QPri
5:4: InitialPri: 00 -> Use Port defaults for FPri and QPri
01 -> Use Tag Priority
10 -> Use IP Priority
11 -> Use Tag & IP Priority
3:2: Egress Floods:00 -> Do not egress any frame with unknown DA
01 -> Do not egress any frame with an unknown mc DA
10 -> Do not egress any frame with an unknown DA
11 -> Egress all frames with an unknown DA
Broadcasts are threaded as multicast if FloodBC in
global2 register is not set.
1:0: PortState: 00 -> Disabled
01 -> Blocking/Listening
10 -> Learning
11 -> ForwardingI hope this helps, feel free to ask for more infos.
Quoted 5 lines
For instance on 88E6185 bit 3 is reserved, on 88E6352 and 88E6390 bit 3:2 are "Egress Floods" and
0x2means "Do not egress any frame with an unknown unicast DA".
Quoted 8 lines
Quoted 3 lines
Do you know if there is a reason why this bit isn't set for DSA type switches too? The patch would be extremely simple and it seems to work perfectly with this bit set on the CPU port.
All these family checks for bit masking are quite messy and ideally need proper abstraction...
Can you give us the chunk of patch you are refering to?
I will send the patch in a few minutes.
Regards,
Stefan
PATCH v2 1/1 net: dsa: mv88e6xxx: forward unknown mc packets on mv88e6097
Packets with unknown destination addresses are not forwarded to the cpu port on mv88e6097 based switches (e.g. MV88E6097) at the moment. This commit enables PORT_CONTROL_FORWARD_UNKNOWN_MC for this family.
--- drivers/net/dsa/mv88e6xxx/chip.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/net/dsa/mv88e6xxx/chip.c +4 -0
@@ -2487,6 +2487,10 @@ static int mv88e6xxx_setup_port(struct mv88e6xxx_chip *chip, int port)PORT_CONTROL_FORWARD_UNKNOWN_MC ; else reg |= PORT_CONTROL_DSA_TAG; + +if (mv88e6xxx_6097_family (chip)) + reg |=PORT_CONTROL_FORWARD_UNKNOWN_MC ; + reg |=PORT_CONTROL_EGRESS_ADD_TAG |PORT_CONTROL_FORWARD_UNKNOWN ; }
Signature · 1 line
2.9.3
Andrew Lunn
maintainerRe: [PATCH v2] net: dsa: mv88e6xxx: forward unknown mc packets on mv88e6097
Quoted 3 lines · Stefan Eichenberger
Packets with unknown destination addresses are not forwarded to the cpu port on mv88e6097 based switches (e.g. MV88E6097) at the moment. This commit enables
PORT_CONTROL_FORWARD_UNKNOWN_MCfor this family.
Please try adding MV88E6XXX_FLAG_EDSA to MV88E6XXX_FLAGS_FAMILY_6097. That is the better fix if it works.
Andrew
PATCH v3 1/1 net: dsa: mv88e6xxx: enable EDSA on mv88e6097
EDSA is currently disabled on mv88e6097 devices, this commit enables it.
--- drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/dsa/mv88e6xxx/mv88e6xxx.h +2 -1
@@ -543,7 +543,8 @@ enum mv88e6xxx_cap { MV88E6XXX_FLAGS_MULTI_CHIP)#define MV88E6XXX_FLAGS_FAMILY_6097 \ - (MV88E6XXX_FLAG_G1_ATU_FID | \ + (MV88E6XXX_FLAG_EDSA | \ + MV88E6XXX_FLAG_G1_ATU_FID | \ MV88E6XXX_FLAG_G1_VTU_FID | \ MV88E6XXX_FLAG_GLOBAL2 | \ MV88E6XXX_FLAG_G2_MGMT_EN_2X | \
Signature · 1 line
2.9.3
Andrew Lunn
maintainerRe: [PATCH v3] net: dsa: mv88e6xxx: enable EDSA on mv88e6097
Quoted 1 line · Stefan Eichenberger
EDSA is currently disabled on mv88e6097 devices, this commit enables it.
And was that sufficient to fix all your issues?
Andrew
Re: [PATCH v2] net: dsa: mv88e6xxx: forward unknown mc packets on mv88e6097
In reply to Andrew LunnQuoted 7 lines · Andrew Lunn
Quoted 3 lines · Stefan Eichenberger
Packets with unknown destination addresses are not forwarded to the cpu port on mv88e6097 based switches (e.g. MV88E6097) at the moment. This commit enables
PORT_CONTROL_FORWARD_UNKNOWN_MCfor this family.Please try adding
MV88E6XXX_FLAG_EDSAtoMV88E6XXX_FLAGS_FAMILY_6097. That is the better fix if it works.
I was even wondering what EDSA means:) Thanks this solved the problem!
Regards
Stefan
Andrew Lunn
maintainerRe: [PATCH v2] net: dsa: mv88e6xxx: forward unknown mc packets on mv88e6097
Quoted 10 lines · Stefan Eichenberger
Quoted 7 lines · Andrew Lunn
Quoted 3 lines · Stefan Eichenberger
Packets with unknown destination addresses are not forwarded to the cpu port on mv88e6097 based switches (e.g. MV88E6097) at the moment. This commit enables
PORT_CONTROL_FORWARD_UNKNOWN_MCfor this family.Please try adding
MV88E6XXX_FLAG_EDSAtoMV88E6XXX_FLAGS_FAMILY_6097. That is the better fix if it works.I was even wondering what EDSA means:) Thanks this solved the problem!
Great.
We should fix up a few minor issues and resubmit.
What is the status of the first patch, which added 6097 to the driver? I don't think David accepted it yet. So lets make one patchset containing the two patches.
The subject line of the patches need to have net-next in it. e.g.
[PATCH net-next 0/2] Add support for the MV88e6097
Include a cover node, saying what the patchset as a whole does. This gets used as the merge commit message.
Then the two patches.
When posting the patchset, please start a new thread. A new version of a patchset or patch should be a new thread.
Thanks
Andrew
Re: [PATCH v2] net: dsa: mv88e6xxx: forward unknown mc packets on mv88e6097
Quoted 20 lines · Andrew Lunn
Quoted 10 lines · Stefan Eichenberger
Quoted 7 lines · Andrew Lunn
Quoted 3 lines · Stefan Eichenberger
Packets with unknown destination addresses are not forwarded to the cpu port on mv88e6097 based switches (e.g. MV88E6097) at the moment. This commit enables
PORT_CONTROL_FORWARD_UNKNOWN_MCfor this family.Please try adding
MV88E6XXX_FLAG_EDSAtoMV88E6XXX_FLAGS_FAMILY_6097. That is the better fix if it works.I was even wondering what EDSA means:) Thanks this solved the problem!
Great.
We should fix up a few minor issues and resubmit.
What is the status of the first patch, which added 6097 to the driver? I don't think David accepted it yet. So lets make one patchset containing the two patches.
Quoted 8 lines
The subject line of the patches need to have net-next in it. e.g.
[PATCH net-next 0/2] Add support for the MV88e6097
Include a cover node, saying what the patchset as a whole does. This gets used as the merge commit message.
Then the two patches.
Perfect, thanks a lot for the help! The patchset will follow.
Thanks
Stefan
Andrew Lunn
maintainerRe: [PATCH v2] net: dsa: mv88e6xxx: forward unknown mc packets on mv88e6097
In reply to Stefan EichenbergerQuoted 10 lines · Stefan Eichenberger
Quoted 7 lines · Andrew Lunn
Quoted 3 lines · Stefan Eichenberger
Packets with unknown destination addresses are not forwarded to the cpu port on mv88e6097 based switches (e.g. MV88E6097) at the moment. This commit enables
PORT_CONTROL_FORWARD_UNKNOWN_MCfor this family.Please try adding
MV88E6XXX_FLAG_EDSAtoMV88E6XXX_FLAGS_FAMILY_6097. That is the better fix if it works.I was even wondering what EDSA means:) Thanks this solved the problem!
Plain DSA puts four bytes of header between the MAC source address and the EtherType/Length.
EDSA puts in an 8 byte header, and includes an Ethertype value of 0xdada. Having that ethertype value makes it more obvious what is going on. And if you have a recent version of tcpdump, it will decode the header.
Andrew
Re: [PATCH v2] net: dsa: mv88e6xxx: forward unknown mc packets on mv88e6097
Hi Andrew,
Quoted 2 lines · Andrew Lunn
And if you have a recent version of tcpdump, it will decode the header.
Since d729eb4, thanks to you Andrew ;-)
I move up the cleanup of ports setup in my priority list. The code is quite cluttered at the moment and it's hard to read through it. We need proper helpers for egress floods, (E)DSA setup, etc. like what is being done for the other devices.
Thanks,
Vivien
Andrew Lunn
maintainerRe: [PATCH v2] net: dsa: mv88e6xxx: forward unknown mc packets on mv88e6097
Quoted 10 lines · Vivien Didelot
Hi Andrew,
Quoted 2 lines · Andrew Lunn
And if you have a recent version of tcpdump, it will decode the header.
Since d729eb4, thanks to you Andrew ;-)
I move up the cleanup of ports setup in my priority list.
Hi Vivien
Please take a look at my mv88e6390 branch. I already refactored this code, because the mv88e6390 does something slightly different...
I hope to post another batch of mv88e6390 patches soon, and they will include this cleanup. Since they will clash with these patches, i will post them first as RFC.
Andrew
Re: [PATCH v2] net: dsa: mv88e6xxx: forward unknown mc packets on mv88e6097
Hi Andrew,
Quoted 12 lines · Andrew Lunn
Quoted 10 lines · Vivien Didelot
Hi Andrew,
Quoted 2 lines · Andrew Lunn
And if you have a recent version of tcpdump, it will decode the header.
Since d729eb4, thanks to you Andrew ;-)
I move up the cleanup of ports setup in my priority list.
Quoted 8 lines
Hi Vivien
Please take a look at my mv88e6390 branch. I already refactored this code, because the mv88e6390 does something slightly different...
I hope to post another batch of mv88e6390 patches soon, and they will include this cleanup. Since they will clash with these patches, i will post them first as RFC.
Perfect. Please split an RFC only including this cleanup if possible. Fewer patches will be easier to review, since the first port registers differs a lot.
Thanks,
Vivien
Andrew Lunn
maintainerQuoted 4 lines
9:8 Frame Mode: 00 -> Normal Network
01 -> DSA (FRAME_MODE_DSA) 10 -> Provider (FRAME_MODE_PROVIDER) 11 -> Ether Type DSA (FRAME_ETHER_TYPE_DSA)
Ah, there is one issue. This device supports EDSA. However, MV88E6XXX_FLAGS_FAMILY_6097 does not list MV88E6XXX_FLAG_EDSA.
Without that flag set, the code assumes the device can only do DSA, using the older definition of this register.
Andrew