Makefile: fix ignored trace at target-finalize
PATCH 1/1 Makefile: fix ignored trace at target-finalize
Make may throw an error (but ignored) trace when cleaning up the rootfs.
The target-finalize rule intends to remove the folder $(TARGET_DIR)/usr/share' but this directory may still contain items (such as the udhcpc' helper script) and causes the rmdir to fail.
The stderr output is redirected to /dev/null but it returns and error which is escaped by the leading `-'; but make reports an ignored-error.
See the log below:
$ make (...) rm -rf (...)/target/usr/share/gtk-doc rmdir (...)/target/usr/share rmdir: failed to remove '(...)/target/usr/share': Directory not empty make[1]: [Makefile:650: target-finalize] Error 1 (ignored) find /(...)/target -type f \( -perm /111 -o -name '*.so*' \) -not \( -name 'libpthread*.so*' -o -name 'ld-*.so*' -o -name '*.ko' \) -print0 | xargs -0 (...)/host/usr/bin/arm-buildroot-linux-uclibcgnueabihf-strip --remove-section=.comment --remove-section=.note 2>/dev/null || true
This patch apply the same rule at the instruction immediately after:
* redirecting stderr to /dev/null (already done) and
* executing true if the `rmdir' instruction fails.
--- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
@@ -656,7 +656,7 @@ endif rm -rf $(TARGET_DIR)/usr/info $(TARGET_DIR)/usr/share/info rm -rf $(TARGET_DIR)/usr/doc $(TARGET_DIR)/usr/share/doc rm -rf $(TARGET_DIR)/usr/share/gtk-doc - -rmdir $(TARGET_DIR)/usr/share 2>/dev/null + rmdir $(TARGET_DIR)/usr/share 2>/dev/null || true $(STRIP_FIND_CMD) | xargs -0 $(STRIPCMD) 2>/dev/null || true # See http://sourceware.org/gdb/wiki/FAQ, "GDB does not see any threads
Signature · 1 line
2.10.2
PATCH 1/1 Makefile: fix ignored trace at target-finalize
Ga"el, All,
On 2016-11-22 15:53 -0500, Ga?l PORTAY spake thusly:
Quoted 19 lines
Make may throw an error (but ignored) trace when cleaning up the rootfs.
The target-finalize rule intends to remove the folder
$(TARGET_DIR)/usr/share' but this directory may still contain items (such as theudhcpc' helper script) and causes the rmdir to fail.The stderr output is redirected to
/dev/nullbut it returns and error which is escaped by the leading `-'; but make reports an ignored-error.See the log below:
$ make (...) rm -rf (...)/target/usr/share/gtk-doc rmdir (...)/target/usr/share rmdir: failed to remove '(...)/target/usr/share': Directory not empty make[1]: [Makefile:650: target-finalize] Error 1 (ignored) find /(...)/target -type f \( -perm /111 -o -name '*.so*' \) -not \( -name 'libpthread*.so*' -o -name 'ld-*.so*' -o -name '*.ko' \) -print0 | xargs -0 (...)/host/usr/bin/arm-buildroot-linux-uclibcgnueabihf-strip --remove-section=.comment --remove-section=.note 2>/dev/null || true
Quoted 5 lines
This patch apply the same rule at the instruction immediately after:
* redirecting stderr to/dev/null(already done) and
* executing true if the `rmdir' instruction fails.Signed-off-by Ga?l PORTAY <[email protected]>
Regards,
Yann E. MORIN.
Quoted 24 lines
--- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Makefile +1
-1@@ -656,7 +656,7 @@ endif rm -rf $(TARGET_DIR)/usr/info $(TARGET_DIR)/usr/share/info rm -rf $(TARGET_DIR)/usr/doc $(TARGET_DIR)/usr/share/doc rm -rf $(TARGET_DIR)/usr/share/gtk-doc - -rmdir $(TARGET_DIR)/usr/share 2>/dev/null + rmdir $(TARGET_DIR)/usr/share 2>/dev/null || true $(STRIP_FIND_CMD) | xargs -0 $(STRIPCMD) 2>/dev/null || true # See http://sourceware.org/gdb/wiki/FAQ, "GDB does not see any threadsSignature · 6 lines
2.10.2 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/1 Makefile: fix ignored trace at target-finalize
In reply to Gaël PORTAYHello,
Quoted 9 lines · Ga?l PORTAY
Make may throw an error (but ignored) trace when cleaning up the rootfs.
The target-finalize rule intends to remove the folder
$(TARGET_DIR)/usr/share' but this directory may still contain items (such as theudhcpc' helper script) and causes the rmdir to fail.The stderr output is redirected to
/dev/nullbut it returns and error which is escaped by the leading `-'; but make reports an ignored-error.
Ah, what is the problem with that? Just the fact that there is this "Error 1 (ignored)" message?
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH 1/1 Makefile: fix ignored trace at target-finalize
Thomas,
Quoted 3 lines · Thomas Petazzoni
Ah, what is the problem with that? Just the fact that there is this "Error 1 (ignored)" message?
Yes, just a nitpick.
There is absolutly no error: simply the trace. Error when things are `ok'.
Also to be more consistent with what is applied at the next line:
stderr + || true.
Thomas Petazzoni
AppliedPATCH 1/1 Makefile: fix ignored trace at target-finalize
In reply to Gaël PORTAYHello,
Quoted 19 lines · Ga?l PORTAY
Make may throw an error (but ignored) trace when cleaning up the rootfs.
The target-finalize rule intends to remove the folder
$(TARGET_DIR)/usr/share' but this directory may still contain items (such as theudhcpc' helper script) and causes the rmdir to fail.The stderr output is redirected to
/dev/nullbut it returns and error which is escaped by the leading `-'; but make reports an ignored-error.See the log below:
$ make (...) rm -rf (...)/target/usr/share/gtk-doc rmdir (...)/target/usr/share rmdir: failed to remove '(...)/target/usr/share': Directory not empty make[1]: [Makefile:650: target-finalize] Error 1 (ignored) find /(...)/target -type f \( -perm /111 -o -name '*.so*' \) -not \( -name 'libpthread*.so*' -o -name 'ld-*.so*' -o -name '*.ko' \) -print0 | xargs -0 (...)/host/usr/bin/arm-buildroot-linux-uclibcgnueabihf-strip --remove-section=.comment --remove-section=.note 2>/dev/null || true
Quoted 8 lines
This patch apply the same rule at the instruction immediately after:
* redirecting stderr to/dev/null(already done) and
* executing true if the `rmdir' instruction fails.Signed-off-by Ga?l PORTAY <[email protected]>--- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to next, thanks.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com