Skip to contentSkip to conversation

fs_racer: cleanup

PATCH Superseded Cui Bixuan 2 participants 5 messages Nov 23, 2016 – Nov 25, 2016

lore
Share & tools
lore

Cui Bixuan

author
#0 lore raw

PATCH 1/1 fs_racer: cleanup

Remove the DIR at the end of test

Signed-off-by Cui Bixuan <[email protected]>
---
 testcases/kernel/fs/racer/fs_racer.sh | 1 +
 1 file changed, 1 insertion(+)
testcases/kernel/fs/racer/fs_racer.sh +1 -0
index 5c4dc69..e7d5e4b 100755
@@ -86,6 +86,7 @@ call_exit()
     killall fs_racer_file_symlink.sh
     killall fs_racer_file_list.sh
     killall fs_racer_file_concat.sh
+    rm -rf $DIR >/dev/null
     exit 0
 }
Signature · 1 line
1.8.3.4
#1 lore raw

PATCH 1/1 fs_racer: cleanup

Hi!

Quoted 1 line

+ rm -rf $DIR >/dev/null

There shouldn't be any need to redirect the output to /dev/null once you pass the -f argument to the rm. Otherwise this is obviously correct.

Signature · 2 lines
Cyril Hrubis
[email protected]
author
#2 lore raw

PATCH v2 1/1 fs_racer: cleanup

Remove the DIR at the end of test

Signed-off-by Cui Bixuan <[email protected]>
---
 testcases/kernel/fs/racer/fs_racer.sh | 1 +
 1 file changed, 1 insertion(+)
testcases/kernel/fs/racer/fs_racer.sh +1 -0
index 5c4dc69..aa38e86 100755
@@ -86,6 +86,7 @@ call_exit()
     killall fs_racer_file_symlink.sh
     killall fs_racer_file_list.sh
     killall fs_racer_file_concat.sh
+    rm -rf $DIR
     exit 0
 }
Signature · 1 line
1.8.3.4
author
#4 lore raw

PATCH v2 1/1 fs_racer: cleanup

Quoted 2 lines · Cyril Hrubis

Hi!
Pushed, thanks.

Thank you

Quoted 1 line