mmc: sdhci-msm: Add clk-rates, DDR, HS400 support
Subsystems (8)
v9 cover mmc: sdhci-msm: Add clk-rates, DDR, HS400 support
Hi,
This is v9 version of the patch series which adds support for MSM8996. Adds HS400 driver support as well.
These are tested on internal msm8996 & db410c HW.
The patch series is ready. Do we think we can apply these patches for next now?
There are only minor changes in v9.
1. From <&xo_board 0> -> <&xo_board>.
2. Addressed Adrian minor comments on 009.
3. Other minor changes.
Older history:-
Changes from v7 -> v8 :-
1. Added patch 005 to add dt bindings for xo_clock.
2. Added patch 009 to factor out sdhci_enable_clock as discussed on v7 series. 2.a. Modified patch 010 by making use of sdhci_enable_clock.
2.b. Addressed Stephen's comment on patch 010 to call clk_set_rate unconditionally.
3. Addressed Stephen comments to remove unncessary one line comments, braces and other minor comments.
4. Added changes from Jeremy in patch 002 for gcc-msm8994 as well for sdcc clk_rcg2_floor_ops. minor comments.
v7 was verified on my Nexus 5X (msm8992).
Older history :-
Below are the changes in v7.
Changes from v6 -> v7 :-
1. Removed patch "clk: Add clk_hw_get_clk() helper API to be used by clk providers" in v7 as it was not required.
2. Addressed Stephen review comments on -
"clk: qcom: Add rcg ops to return floor value closest to the requested rate"
3. Addressed comments from Stephen to add xo_clock entry in the sdhc clock node. Using the same xo_clock entry from DT to get the clk_rate of xo_clock used in sdhci-msm driver. Patch 04 adds this entry into DT.
Patch 05 adds the driver support for xo_clock mentioned above.
Hence there is a minor change in Patch05, which can be reviewed and taken into the tree.
IMHO, almost all patches are almost done and are ready to be accepted. Will below process work out?
Patches 001 & 002 :- (clock changes) - Can go via Stephen's Boyd Tree. Patches 004 & 010 :- (DTS changes) - Can go via Andy Gross. Patches 003, 005-009 & 011-014 :- (sdhci-msm changes) - Adrian's tree.
Please let me know in case if anything else is required on above.
Changes from v5 -> v6 :-
1. Earlier in v5 series DT node was added to get the clk-rates table needed for sdhci-msm driver. But this is removed in this(v6) patch series and instead the clk changes are done in the clk driver as per Rob H comment.
2. Added clk driver changes(patch 1-3) to provide floor rate values of requested clock for sdhc client.
For following boards- apq8084, msm8996, msm8916, msm8974.
3. Other minor patch comments were addressed.
Changes from v4 -> v5 :-
1. Added HS400 sdhci-msm controller specific changes:- (Patch 10, 11, 12)
2. Addressed comment from Adrian on Patch 07 @[3].
3. Addressed comment from Arnd on Patch 03, to directly add clk_table into sdhci_msm_host. [4]
4. Addressed comment from Bjorn to not enforce having clk-rates property in DT for older targets based on discussion at [5]
5. Retained Acks from Adrian on patches (01 & 02 & 06) where there were no changes made while addressing above comments.
Older history:-
This is v4 version of the patch series.
Patches 01, 02, 05 & 06 were Acked-by Adrian.
Changes from v3 -> v4 :-
1. Addressed comments from Adrian on Patch 03, 07, 08.
2. Addressed comments from Bjorn on Patch 03.
3. Added clk-rate support for sdhc DT nodes to all MSM platforms. in Pacth 04.
4. Rebased on next branch of Ulf.
Changes from v2 -> v3 :-
1. Addded Patch 01 based on Bjorn comment[2] -
This fixes/unrolls the poor coding style of read/writes of registers from base sdhci-msm driver.
2. Fixed/unrolled poor style of reads/writes of registers in Patch 02, based on Bjorn comment[2]. Also changed name of flag from use_updated_dll_reset -> use_14lpp_dll_reset.
Changes from v1->v2 :-
1. Removed patch 06 & 08 from v1 patch series[1] (which were introducing unnecessary quirks). Instead have implemented __sdhci_msm_set_clock version of sdhci_set_clock in sdhci_msm driver itself in patch 07 of this patch series.
2. Enabled extra quirk (SDHCI_QUIRK2_PRESET_VALUE_BROKEN) in patch 05 of this patch series.
Description of patches :-
This patchset adds clk-rates & other required changes to upstream sdhci-msm driver from codeaurora tree.
It has been tested on a db410c Dragonboard and msm8996 based platform.
Patch 0001-0003- Adds support in qcom clk driver to return floor value of requested clock rate instead of ceil rate for sdhc clients.
Patch 0004- Adds updated dll sequence for newer controllers which has minor_version >= 0x42. This is required for msm8996.
MSM controller HW recommendation is to use the base MCI clock and directly control this MCI clock at GCC in order to change the clk-rate.
Patches 06-08 bring in required change for this to sdhci-msm.
MSM controller would require 2x clock rate from source for DDR bus speed modes. Patch 09 adds this support.
Patch 0010- adds DDR support in DT for sdhc1 of msm8916.
Patches 0011-0014- Adds HS400 support to sdhci-msm.
[1]:- http://www.spinics.net/lists/linux-mmc/msg38467.html
[2]:- http://www.spinics.net/lists/linux-mmc/msg38578.html
[3]:- https://patchwork.kernel.org/patch/9289345/
[4]:- https://www.spinics.net/lists/linux-mmc/msg39107.html
[5]:- http://www.spinics.net/lists/linux-mmc/msg38749.html
[6]:- https://patchwork.kernel.org/patch/9297381/
Rajendra Nayak (2):
clk: qcom: Add rcg ops to return floor value closest to the requested
rate
clk: qcom: Move all sdcc rcgs to use clk_rcg2_floor_ops
Ritesh Harjani (12):
mmc: sdhci-msm: Change poor style writel/readl of registers
ARM: dts: Add xo to sdhc clock node on qcom platforms
dt-bindings: sdhci-msm: Add xo value
mmc: sdhci-msm: Add get_min_clock() and get_max_clock() callback
mmc: sdhci-msm: Enable few quirks
mmc: sdhci: Factor out sdhci_enable_clk
mmc: sdhci-msm: Implement set_clock callback for sdhci-msm
mmc: sdhci-msm: Add clock changes for DDR mode.
arm64: dts: qcom: msm8916: Add ddr support to sdhc1
mmc: sdhci-msm: Save the calculated tuning phase
mmc: sdhci-msm: Add calibration tuning for CDCLP533 circuit
sdhci: sdhci-msm: update dll configuration
Venkat Gopalakrishnan (2):
mmc: sdhci-msm: Update DLL reset sequence
mmc: sdhci-msm: Add HS400 platform support
.../devicetree/bindings/mmc/sdhci-msm.txt | 1 + arch/arm/boot/dts/qcom-apq8084.dtsi | 16 +- arch/arm/boot/dts/qcom-msm8974.dtsi | 16 +- arch/arm64/boot/dts/qcom/msm8916.dtsi | 11 +- arch/arm64/boot/dts/qcom/msm8996.dtsi | 9 +- drivers/clk/qcom/clk-rcg.h | 1 + drivers/clk/qcom/clk-rcg2.c | 76 ++- drivers/clk/qcom/common.c | 16 + drivers/clk/qcom/common.h | 2 + drivers/clk/qcom/gcc-apq8084.c | 8 +- drivers/clk/qcom/gcc-msm8916.c | 4 +- drivers/clk/qcom/gcc-msm8974.c | 8 +- drivers/clk/qcom/gcc-msm8994.c | 8 +- drivers/clk/qcom/gcc-msm8996.c | 8 +- drivers/mmc/host/sdhci-msm.c | 626 +++++++++++++++++++-- drivers/mmc/host/sdhci.c | 28 +- drivers/mmc/host/sdhci.h | 1 + 17 files changed, 739 insertions(+), 100 deletions(-)
Signature · 7 lines
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH v9 1/16 clk: qcom: Add rcg ops to return floor value closest to the requested rate
From: Rajendra Nayak <[email protected]>
The default behaviour with clk_rcg2_ops is for the clk_round_rate()/clk_set_rate() to return/set a ceil clock rate closest to the requested rate by looking up the corresponding frequency table.
However, we do have some instances (mainly sdcc on various platforms) of clients expecting a clk_set_rate() to set a floor value instead. Add a new clk_rcg2_floor_ops to handle this for such specific rcg instances
--- drivers/clk/qcom/clk-rcg.h | 1 + drivers/clk/qcom/clk-rcg2.c | 76 +++++++++++++++++++++++++++++++++++++++------ drivers/clk/qcom/common.c | 16 ++++++++++ drivers/clk/qcom/common.h | 2 ++ 4 files changed, 86 insertions(+), 9 deletions(-)
drivers/clk/qcom/clk-rcg.h +1 -0
@@ -173,6 +173,7 @@ struct clk_rcg2 {#define to_clk_rcg2 (_hw) container_of(to_clk_regmap(_hw), struct clk_rcg2, clkr)extern const struct clk_ops clk_rcg2_ops; +extern const struct clk_ops clk_rcg2_floor_ops;extern const struct clk_ops clk_rcg2_shared_ops;extern const struct clk_ops clk_edp_pixel_ops;extern const struct clk_ops clk_byte_ops;
drivers/clk/qcom/clk-rcg2.c +67 -9
133 lines not on this page · raw message
drivers/clk/qcom/common.c +16 -0
@@ -46,6 +46,22 @@ struct freq_tbl *qcom_find_freq(const struct freq_tbl *f, unsigned long rate) }EXPORT_SYMBOL_GPL (qcom_find_freq); +const struct freq_tbl *qcom_find_freq_floor (const struct freq_tbl *f, +unsigned long rate) +{ +const struct freq_tbl *best =NULL ; + +for ( ; f->freq; f++) { +if (rate >= f->freq) + best = f; +else +break ; + } + +return best; +} +EXPORT_SYMBOL_GPL (qcom_find_freq_floor); +int qcom_find_src_index (struct clk_hw *hw,const struct parent_map *map,u8 src) {int i, num_parents =clk_hw_get_num_parents (hw);
drivers/clk/qcom/common.h +2 -0
@@ -41,6 +41,8 @@ struct qcom_cc_desc {extern const struct freq_tbl *qcom_find_freq (const struct freq_tbl *f,unsigned long rate); +extern const struct freq_tbl *qcom_find_freq_floor (const struct freq_tbl *f, +unsigned long rate);extern void qcom_pll_set_fsm_mode (struct regmap *m,u32 reg,u8 bias_count,u8 lock_count); extern int qcom_find_src_index(struct clk_hw *hw, const struct parent_map *map,
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
A message that is not in the archive (sent off-list or not yet received): 1479710246-26676-2-git-send-email-riteshh-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org
Stephen Boyd
AppliedRe: [PATCH v9 01/16] clk: qcom: Add rcg ops to return floor value closest to the requested rate
Quoted 11 lines · Ritesh Harjani
From: Rajendra Nayak <[email protected]>
The default behaviour with
clk_rcg2_opsis for the clk_round_rate()/clk_set_rate() to return/set a ceil clock rate closest to the requested rate by looking up the corresponding frequency table.
However, we do have some instances (mainly sdcc on various platforms) of clients expecting aclk_set_rate()to set a floor value instead. Add a newclk_rcg2_floor_opsto handle this for such specific rcg instances
Quoted 3 lines
Signed-off-by Rajendra Nayak <[email protected]>Signed-off-by Ritesh Harjani <[email protected]>---
Applied to clk-next
Signature · 6 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH v9 2/16 clk: qcom: Move all sdcc rcgs to use clk_rcg2_floor_ops
In reply to Ritesh HarjaniFrom: Rajendra Nayak <[email protected]>
The sdcc driver for msm8996/msm8916/msm8974/msm8994 and apq8084 expects a clk_set_rate() on the sdcc rcg clk to set
a floor value of supported clk rate closest to the requested rate, by looking up the frequency table.
So move all the sdcc rcgs on all these platforms to use the newly introduced clk_rcg2_floor_ops
--- drivers/clk/qcom/gcc-apq8084.c | 8 ++++---- drivers/clk/qcom/gcc-msm8916.c | 4 ++-- drivers/clk/qcom/gcc-msm8974.c | 8 ++++---- drivers/clk/qcom/gcc-msm8994.c | 8 ++++---- drivers/clk/qcom/gcc-msm8996.c | 8 ++++---- 5 files changed, 18 insertions(+), 18 deletions(-)
drivers/clk/qcom/gcc-apq8084.c +4 -4
@@ -1142,7 +1142,7 @@ enum { .name = "sdcc1_apps_clk_src", .parent_names = gcc_xo_gpll0_gpll4, .num_parents = 3, - .ops = &clk_rcg2_ops, + .ops = &clk_rcg2_floor_ops, }, };
@@ -1156,7 +1156,7 @@ enum { .name = "sdcc2_apps_clk_src", .parent_names = gcc_xo_gpll0, .num_parents = 2, - .ops = &clk_rcg2_ops, + .ops = &clk_rcg2_floor_ops, }, };
@@ -1170,7 +1170,7 @@ enum { .name = "sdcc3_apps_clk_src", .parent_names = gcc_xo_gpll0, .num_parents = 2, - .ops = &clk_rcg2_ops, + .ops = &clk_rcg2_floor_ops, }, };
@@ -1184,7 +1184,7 @@ enum { .name = "sdcc4_apps_clk_src", .parent_names = gcc_xo_gpll0, .num_parents = 2, - .ops = &clk_rcg2_ops, + .ops = &clk_rcg2_floor_ops, }, };
drivers/clk/qcom/gcc-msm8916.c +2 -2
@@ -1107,7 +1107,7 @@ enum { .name = "sdcc1_apps_clk_src", .parent_names = gcc_xo_gpll0, .num_parents = 2, - .ops = &clk_rcg2_ops, + .ops = &clk_rcg2_floor_ops, }, };
@@ -1132,7 +1132,7 @@ enum { .name = "sdcc2_apps_clk_src", .parent_names = gcc_xo_gpll0, .num_parents = 2, - .ops = &clk_rcg2_ops, + .ops = &clk_rcg2_floor_ops, }, };
drivers/clk/qcom/gcc-msm8974.c +4 -4
@@ -872,7 +872,7 @@ enum { .name = "sdcc1_apps_clk_src", .parent_names = gcc_xo_gpll0, .num_parents = 2, - .ops = &clk_rcg2_ops, + .ops = &clk_rcg2_floor_ops, };static struct clk_rcg2 sdcc1_apps_clk_src = {
@@ -894,7 +894,7 @@ enum { .name = "sdcc2_apps_clk_src", .parent_names = gcc_xo_gpll0, .num_parents = 2, - .ops = &clk_rcg2_ops, + .ops = &clk_rcg2_floor_ops, }, };
@@ -908,7 +908,7 @@ enum { .name = "sdcc3_apps_clk_src", .parent_names = gcc_xo_gpll0, .num_parents = 2, - .ops = &clk_rcg2_ops, + .ops = &clk_rcg2_floor_ops, }, };
@@ -922,7 +922,7 @@ enum { .name = "sdcc4_apps_clk_src", .parent_names = gcc_xo_gpll0, .num_parents = 2, - .ops = &clk_rcg2_ops, + .ops = &clk_rcg2_floor_ops, }, };
drivers/clk/qcom/gcc-msm8994.c +4 -4
@@ -912,7 +912,7 @@ enum { .name = "sdcc1_apps_clk_src", .parent_names = gcc_xo_gpll0_gpll4, .num_parents = 3, - .ops = &clk_rcg2_ops, + .ops = &clk_rcg2_floor_ops, }, };
@@ -938,7 +938,7 @@ enum { .name = "sdcc2_apps_clk_src", .parent_names = gcc_xo_gpll0, .num_parents = 2, - .ops = &clk_rcg2_ops, + .ops = &clk_rcg2_floor_ops, }, };
@@ -953,7 +953,7 @@ enum { .name = "sdcc3_apps_clk_src", .parent_names = gcc_xo_gpll0, .num_parents = 2, - .ops = &clk_rcg2_ops, + .ops = &clk_rcg2_floor_ops, }, };
@@ -968,7 +968,7 @@ enum { .name = "sdcc4_apps_clk_src", .parent_names = gcc_xo_gpll0, .num_parents = 2, - .ops = &clk_rcg2_ops, + .ops = &clk_rcg2_floor_ops, }, };
drivers/clk/qcom/gcc-msm8996.c +4 -4
@@ -460,7 +460,7 @@ enum { .name = "sdcc1_apps_clk_src", .parent_names = gcc_xo_gpll0_gpll4_gpll0_early_div, .num_parents = 4, - .ops = &clk_rcg2_ops, + .ops = &clk_rcg2_floor_ops, }, };
@@ -505,7 +505,7 @@ enum { .name = "sdcc2_apps_clk_src", .parent_names = gcc_xo_gpll0_gpll4, .num_parents = 3, - .ops = &clk_rcg2_ops, + .ops = &clk_rcg2_floor_ops, }, };
@@ -519,7 +519,7 @@ enum { .name = "sdcc3_apps_clk_src", .parent_names = gcc_xo_gpll0_gpll4, .num_parents = 3, - .ops = &clk_rcg2_ops, + .ops = &clk_rcg2_floor_ops, }, };
@@ -543,7 +543,7 @@ enum { .name = "sdcc4_apps_clk_src", .parent_names = gcc_xo_gpll0, .num_parents = 2, - .ops = &clk_rcg2_ops, + .ops = &clk_rcg2_floor_ops, }, };
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
Stephen Boyd
AppliedRe: [PATCH v9 02/16] clk: qcom: Move all sdcc rcgs to use clk_rcg2_floor_ops
Quoted 9 lines · Ritesh Harjani
From: Rajendra Nayak <[email protected]>
The sdcc driver for msm8996/msm8916/msm8974/msm8994 and apq8084 expects a
clk_set_rate()on the sdcc rcg clk to set
a floor value of supported clk rate closest to the requested rate, by looking up the frequency table.
So move all the sdcc rcgs on all these platforms to use the newly introducedclk_rcg2_floor_ops
Quoted 4 lines
Signed-off-by Rajendra Nayak <[email protected]>Signed-off-by Ritesh Harjani <[email protected]>Signed-off-by Jeremy McNicoll <[email protected]>---
Applied to clk-next
Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
PATCH v9 3/16 mmc: sdhci-msm: Change poor style writel/readl of registers
In reply to Ritesh HarjaniThis patch changes the poor style of writel/readl registers into more readable format. This avoid mixed style format of readl/writel in sdhci-msm driver.
This patch also removes the one line comments which were present for above writel/readl, since they were of no help.
--- drivers/mmc/host/sdhci-msm.c | 62 +++++++++++++++++++++++--------------------- 1 file changed, 32 insertions(+), 30 deletions(-)
drivers/mmc/host/sdhci-msm.c +32 -30
@@ -138,9 +138,9 @@ static int msm_config_cm_dll_phase(struct sdhci_host *host, u8 phase) config |= grey_coded_phase_table[phase] <<CDR_SELEXT_SHIFT ;writel_relaxed (config, host->ioaddr +CORE_DLL_CONFIG ); -/* Set CK_OUT_EN bit of DLL_CONFIG register to 1. */ -writel_relaxed ((readl_relaxed (host->ioaddr +CORE_DLL_CONFIG ) - |CORE_CK_OUT_EN ), host->ioaddr +CORE_DLL_CONFIG ); + config =readl_relaxed (host->ioaddr +CORE_DLL_CONFIG ); + config |=CORE_CK_OUT_EN ; +writel_relaxed (config, host->ioaddr +CORE_DLL_CONFIG );/* Wait until CK_OUT_EN bit of DLL_CONFIG register becomes '1' */ rc =msm_dll_poll_ck_out_en (host,1 );
@@ -307,6 +307,7 @@ static int msm_init_cm_dll(struct sdhci_host *host)struct mmc_host *mmc = host->mmc;int wait_cnt =50 ;unsigned long flags; +u32 config;spin_lock_irqsave (&host->lock, flags);
@@ -315,33 +316,34 @@ static int msm_init_cm_dll(struct sdhci_host *host)* tuning is in progress. Keeping PWRSAVE ON may * turn off the clock. */ -writel_relaxed ((readl_relaxed (host->ioaddr +CORE_VENDOR_SPEC ) - & ~CORE_CLK_PWRSAVE ), host->ioaddr +CORE_VENDOR_SPEC ); + config =readl_relaxed (host->ioaddr +CORE_VENDOR_SPEC ); + config &= ~CORE_CLK_PWRSAVE ; +writel_relaxed (config, host->ioaddr +CORE_VENDOR_SPEC ); -/* Write 1 to DLL_RST bit of DLL_CONFIG register */ -writel_relaxed ((readl_relaxed (host->ioaddr +CORE_DLL_CONFIG ) - |CORE_DLL_RST ), host->ioaddr +CORE_DLL_CONFIG ); + config =readl_relaxed (host->ioaddr +CORE_DLL_CONFIG ); + config |=CORE_DLL_RST ; +writel_relaxed (config, host->ioaddr +CORE_DLL_CONFIG ); -/* Write 1 to DLL_PDN bit of DLL_CONFIG register */ -writel_relaxed ((readl_relaxed (host->ioaddr +CORE_DLL_CONFIG ) - |CORE_DLL_PDN ), host->ioaddr +CORE_DLL_CONFIG ); + config =readl_relaxed (host->ioaddr +CORE_DLL_CONFIG ); + config |=CORE_DLL_PDN ; +writel_relaxed (config, host->ioaddr +CORE_DLL_CONFIG );msm_cm_dll_set_freq (host); -/* Write 0 to DLL_RST bit of DLL_CONFIG register */ -writel_relaxed ((readl_relaxed (host->ioaddr +CORE_DLL_CONFIG ) - & ~CORE_DLL_RST ), host->ioaddr +CORE_DLL_CONFIG ); + config =readl_relaxed (host->ioaddr +CORE_DLL_CONFIG ); + config &= ~CORE_DLL_RST ; +writel_relaxed (config, host->ioaddr +CORE_DLL_CONFIG ); -/* Write 0 to DLL_PDN bit of DLL_CONFIG register */ -writel_relaxed ((readl_relaxed (host->ioaddr +CORE_DLL_CONFIG ) - & ~CORE_DLL_PDN ), host->ioaddr +CORE_DLL_CONFIG ); + config =readl_relaxed (host->ioaddr +CORE_DLL_CONFIG ); + config &= ~CORE_DLL_PDN ; +writel_relaxed (config, host->ioaddr +CORE_DLL_CONFIG ); -/* Set DLL_EN bit to 1. */ -writel_relaxed ((readl_relaxed (host->ioaddr +CORE_DLL_CONFIG ) - |CORE_DLL_EN ), host->ioaddr +CORE_DLL_CONFIG ); + config =readl_relaxed (host->ioaddr +CORE_DLL_CONFIG ); + config |=CORE_DLL_EN ; +writel_relaxed (config, host->ioaddr +CORE_DLL_CONFIG ); -/* Set CK_OUT_EN bit to 1. */ -writel_relaxed ((readl_relaxed (host->ioaddr +CORE_DLL_CONFIG ) - |CORE_CK_OUT_EN ), host->ioaddr +CORE_DLL_CONFIG ); + config =readl_relaxed (host->ioaddr +CORE_DLL_CONFIG ); + config |=CORE_CK_OUT_EN ; +writel_relaxed (config, host->ioaddr +CORE_DLL_CONFIG );/* Wait until DLL_LOCK bit of DLL_STATUS register becomes '1' */ while (!(readl_relaxed(host->ioaddr + CORE_DLL_STATUS) &
@@ -538,7 +540,7 @@ static int sdhci_msm_probe(struct platform_device *pdev)struct resource *core_memres;int ret;u16 host_version, core_minor; -u32 core_version, caps; +u32 core_version, config;u8 core_major; host =sdhci_pltfm_init (pdev, &sdhci_msm_pdata,sizeof (*msm_host));
@@ -606,9 +608,9 @@ static int sdhci_msm_probe(struct platform_device *pdev) goto clk_disable; } -/* Reset the core and Enable SDHC mode */ -writel_relaxed (readl_relaxed (msm_host->core_mem +CORE_POWER ) | -CORE_SW_RST , msm_host->core_mem +CORE_POWER ); + config =readl_relaxed (msm_host->core_mem +CORE_POWER ); + config |=CORE_SW_RST ; +writel_relaxed (config, msm_host->core_mem +CORE_POWER );/* SW reset can take upto 10HCLK + 15MCLK cycles. (min 40us) */ usleep_range (1000 ,5000 );
@@ -638,9 +640,9 @@ static int sdhci_msm_probe(struct platform_device *pdev)* controller versions and must be explicitly enabled. */ if (core_major >=1 && core_minor !=0x11 && core_minor !=0x12 ) { - caps =readl_relaxed (host->ioaddr +SDHCI_CAPABILITIES ); - caps |=SDHCI_CAN_VDD_300 |SDHCI_CAN_DO_8BIT ; -writel_relaxed (caps, host->ioaddr + + config =readl_relaxed (host->ioaddr +SDHCI_CAPABILITIES ); + config |=SDHCI_CAN_VDD_300 |SDHCI_CAN_DO_8BIT ; +writel_relaxed (config, host->ioaddr +CORE_VENDOR_SPEC_CAPABILITIES0 ); }
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
PATCH v9 4/16 ARM: dts: Add xo to sdhc clock node on qcom platforms
In reply to Ritesh HarjaniAdd xo entry to sdhc clock node on all qcom platforms.
--- arch/arm/boot/dts/qcom-apq8084.dtsi | 16 ++++++++++------ arch/arm/boot/dts/qcom-msm8974.dtsi | 16 ++++++++++------ arch/arm64/boot/dts/qcom/msm8916.dtsi | 10 ++++++---- arch/arm64/boot/dts/qcom/msm8996.dtsi | 9 +++++---- 4 files changed, 31 insertions(+), 20 deletions(-)
arch/arm/boot/dts/qcom-apq8084.dtsi +10 -6
@@ -182,13 +182,13 @@ }; clocks { - xo_board { + xo_board: xo_board { compatible = "fixed-clock"; #clock-cells = <0>; clock-frequency = <19200000>; }; - sleep_clk { + sleep_clk: sleep_clk { compatible = "fixed-clock"; #clock-cells = <0>; clock-frequency = <32768>;
@@ -416,8 +416,10 @@ reg-names = "hc_mem", "core_mem"; interrupts = <0 123 0>, <0 138 0>; interrupt-names = "hc_irq", "pwr_irq"; - clocks = <&gcc GCC_SDCC1_APPS_CLK>, <&gcc GCC_SDCC1_AHB_CLK>; - clock-names = "core", "iface"; + clocks = <&gcc GCC_SDCC1_APPS_CLK>, + <&gcc GCC_SDCC1_AHB_CLK>, + <&xo_board>; + clock-names = "core", "iface", "xo"; status = "disabled"; };
@@ -427,8 +429,10 @@ reg-names = "hc_mem", "core_mem"; interrupts = <0 125 0>, <0 221 0>; interrupt-names = "hc_irq", "pwr_irq"; - clocks = <&gcc GCC_SDCC2_APPS_CLK>, <&gcc GCC_SDCC2_AHB_CLK>; - clock-names = "core", "iface"; + clocks = <&gcc GCC_SDCC2_APPS_CLK>, + <&gcc GCC_SDCC2_AHB_CLK>, + <&xo_board>; + clock-names = "core", "iface", "xo"; status = "disabled"; };
arch/arm/boot/dts/qcom-msm8974.dtsi +10 -6
@@ -220,13 +220,13 @@ }; clocks { - xo_board { + xo_board: xo_board { compatible = "fixed-clock"; #clock-cells = <0>; clock-frequency = <19200000>; }; - sleep_clk { + sleep_clk: sleep_clk { compatible = "fixed-clock"; #clock-cells = <0>; clock-frequency = <32768>;
@@ -558,8 +558,10 @@ reg-names = "hc_mem", "core_mem"; interrupts = <0 123 0>, <0 138 0>; interrupt-names = "hc_irq", "pwr_irq"; - clocks = <&gcc GCC_SDCC1_APPS_CLK>, <&gcc GCC_SDCC1_AHB_CLK>; - clock-names = "core", "iface"; + clocks = <&gcc GCC_SDCC1_APPS_CLK>, + <&gcc GCC_SDCC1_AHB_CLK>, + <&xo_board>; + clock-names = "core", "iface", "xo"; status = "disabled"; };
@@ -569,8 +571,10 @@ reg-names = "hc_mem", "core_mem"; interrupts = <0 125 0>, <0 221 0>; interrupt-names = "hc_irq", "pwr_irq"; - clocks = <&gcc GCC_SDCC2_APPS_CLK>, <&gcc GCC_SDCC2_AHB_CLK>; - clock-names = "core", "iface"; + clocks = <&gcc GCC_SDCC2_APPS_CLK>, + <&gcc GCC_SDCC2_AHB_CLK>, + <&xo_board>; + clock-names = "core", "iface", "xo"; status = "disabled"; };
arch/arm64/boot/dts/qcom/msm8916.dtsi +6 -4
@@ -512,8 +512,9 @@ interrupts = <0 123 0>, <0 138 0>; interrupt-names = "hc_irq", "pwr_irq"; clocks = <&gcc GCC_SDCC1_APPS_CLK>, - <&gcc GCC_SDCC1_AHB_CLK>; - clock-names = "core", "iface"; + <&gcc GCC_SDCC1_AHB_CLK>, + <&xo_board>; + clock-names = "core", "iface", "xo"; bus-width = <8>; non-removable; status = "disabled";
@@ -527,8 +528,9 @@ interrupts = <0 125 0>, <0 221 0>; interrupt-names = "hc_irq", "pwr_irq"; clocks = <&gcc GCC_SDCC2_APPS_CLK>, - <&gcc GCC_SDCC2_AHB_CLK>; - clock-names = "core", "iface"; + <&gcc GCC_SDCC2_AHB_CLK>, + <&xo_board>; + clock-names = "core", "iface", "xo"; bus-width = <4>; status = "disabled"; };
arch/arm64/boot/dts/qcom/msm8996.dtsi +5 -4
@@ -192,14 +192,14 @@ }; clocks { - xo_board { + xo_board: xo_board { compatible = "fixed-clock"; #clock-cells = <0>; clock-frequency = <19200000>; clock-output-names = "xo_board"; }; - sleep_clk { + sleep_clk: sleep_clk { compatible = "fixed-clock"; #clock-cells = <0>; clock-frequency = <32764>;
@@ -347,9 +347,10 @@ interrupts = <0 125 0>, <0 221 0>; interrupt-names = "hc_irq", "pwr_irq"; - clock-names = "iface", "core"; + clock-names = "iface", "core", "xo"; clocks = <&gcc GCC_SDCC2_AHB_CLK>, - <&gcc GCC_SDCC2_APPS_CLK>; + <&gcc GCC_SDCC2_APPS_CLK>, + <&xo_board>; bus-width = <4>; };
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
PATCH v9 5/16 dt-bindings: sdhci-msm: Add xo value
In reply to Ritesh HarjaniAdd "xo" value which is tcxo clock to sdhci-msm
DT binding properties.
--- Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/mmc/sdhci-msm.txt +1 -0
@@ -17,6 +17,7 @@ Required properties: "iface" - Main peripheral bus clock (PCLK/HCLK - AHB Bus clock) (required) "core" - SDC MMC clock (MCLK) (required) "bus" - SDCC bus voter clock (optional) + "xo" - TCXO clock (optional) Example:
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
PATCH v9 6/16 mmc: sdhci-msm: Update DLL reset sequence
In reply to Ritesh HarjaniFrom: Venkat Gopalakrishnan <[email protected]>
SDCC core with minor version >= 0x42 introduced new 14lpp DLL. This has additional requirements in the reset sequence for DLL tuning. Make necessary changes as needed.
Without this patch we see below errors on such SDHC controllers
sdhci_msm 7464900.sdhci: mmc0: DLL failed to LOCK
mmc0: tuning execution failed: -110
--- drivers/mmc/host/sdhci-msm.c | 60 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 60 insertions(+)
drivers/mmc/host/sdhci-msm.c +60 -0
@@ -59,6 +59,10 @@#define CORE_DLL_CONFIG 0x100#define CORE_DLL_STATUS 0x108 +#define CORE_DLL_CONFIG_2 0x1b4 +#define CORE_FLL_CYCLE_CNT BIT(18) +#define CORE_DLL_CLOCK_DISABLE BIT(21) +#define CORE_VENDOR_SPEC 0x10c#define CORE_CLK_PWRSAVE BIT(1)
@@ -77,7 +81,9 @@ struct sdhci_msm_host {struct clk *clk;/* main SD/MMC bus clock */ struct clk *pclk;/* SDHC peripheral bus clock */ struct clk *bus_clk;/* SDHC bus voter clock */ +struct clk *xo_clk;/* TCXO clk needed for FLL feature of cm_dll*/ struct mmc_host *mmc; +bool use_14lpp_dll_reset; };/* Platform specific tuning */
@@ -305,6 +311,8 @@ static inline void msm_cm_dll_set_freq(struct sdhci_host *host)static int msm_init_cm_dll (struct sdhci_host *host) {struct mmc_host *mmc = host->mmc; +struct sdhci_pltfm_host *pltfm_host =sdhci_priv (host); +struct sdhci_msm_host *msm_host =sdhci_pltfm_priv (pltfm_host);int wait_cnt =50 ;unsigned long flags;u32 config;
@@ -320,6 +328,16 @@ static int msm_init_cm_dll(struct sdhci_host *host) config &= ~CORE_CLK_PWRSAVE ;writel_relaxed (config, host->ioaddr +CORE_VENDOR_SPEC ); +if (msm_host->use_14lpp_dll_reset) { + config =readl_relaxed (host->ioaddr +CORE_DLL_CONFIG ); + config &= ~CORE_CK_OUT_EN ; +writel_relaxed (config, host->ioaddr +CORE_DLL_CONFIG ); + + config =readl_relaxed (host->ioaddr +CORE_DLL_CONFIG_2 ); + config |=CORE_DLL_CLOCK_DISABLE ; +writel_relaxed (config, host->ioaddr +CORE_DLL_CONFIG_2 ); + } + config =readl_relaxed (host->ioaddr +CORE_DLL_CONFIG ); config |=CORE_DLL_RST ;writel_relaxed (config, host->ioaddr +CORE_DLL_CONFIG );
@@ -329,6 +347,28 @@ static int msm_init_cm_dll(struct sdhci_host *host)writel_relaxed (config, host->ioaddr +CORE_DLL_CONFIG );msm_cm_dll_set_freq (host); +if (msm_host->use_14lpp_dll_reset && + !IS_ERR_OR_NULL (msm_host->xo_clk)) { +u32 mclk_freq =0 ; + + config =readl_relaxed (host->ioaddr +CORE_DLL_CONFIG_2 ); + config &=CORE_FLL_CYCLE_CNT ; +if (config) + mclk_freq =DIV_ROUND_CLOSEST_ULL ((host->clock *8 ), +clk_get_rate (msm_host->xo_clk)); +else + mclk_freq =DIV_ROUND_CLOSEST_ULL ((host->clock *4 ), +clk_get_rate (msm_host->xo_clk)); + + config =readl_relaxed (host->ioaddr +CORE_DLL_CONFIG_2 ); + config &= ~(0xFF <<10 ); + config |= mclk_freq <<10 ; + +writel_relaxed (config, host->ioaddr +CORE_DLL_CONFIG_2 ); +/* wait for 5us before enabling DLL clock */ +udelay (5 ); + } + config =readl_relaxed (host->ioaddr +CORE_DLL_CONFIG ); config &= ~CORE_DLL_RST ;writel_relaxed (config, host->ioaddr +CORE_DLL_CONFIG );
@@ -337,6 +377,13 @@ static int msm_init_cm_dll(struct sdhci_host *host) config &= ~CORE_DLL_PDN ;writel_relaxed (config, host->ioaddr +CORE_DLL_CONFIG ); +if (msm_host->use_14lpp_dll_reset) { +msm_cm_dll_set_freq (host); + config =readl_relaxed (host->ioaddr +CORE_DLL_CONFIG_2 ); + config &= ~CORE_DLL_CLOCK_DISABLE ; +writel_relaxed (config, host->ioaddr +CORE_DLL_CONFIG_2 ); + } + config =readl_relaxed (host->ioaddr +CORE_DLL_CONFIG ); config |=CORE_DLL_EN ;writel_relaxed (config, host->ioaddr +CORE_DLL_CONFIG );
@@ -590,6 +637,16 @@ static int sdhci_msm_probe(struct platform_device *pdev) goto pclk_disable; } +/* +* xo clock is needed for FLL feature of cm_dll. +* In case if xo clock is not mentioned in DT, warn and proceed. +*/ + msm_host->xo_clk =devm_clk_get (&pdev->dev,"xo" ); +if (IS_ERR (msm_host->xo_clk)) { + ret =PTR_ERR (msm_host->xo_clk); +dev_warn (&pdev->dev,"TCXO clk not present (%d)\n" , ret); + } +/* Vote for maximum clock rate for maximum performance */ ret =clk_set_rate (msm_host->clk,INT_MAX );if (ret)
@@ -635,6 +692,9 @@ static int sdhci_msm_probe(struct platform_device *pdev)dev_dbg (&pdev->dev,"MCI Version: 0x%08x, major: 0x%04x, minor: 0x%02x\n" , core_version, core_major, core_minor); +if (core_major ==1 && core_minor >=0x42 ) + msm_host->use_14lpp_dll_reset = true; +/* * Support for some capabilities is not advertised by newer * controller versions and must be explicitly enabled.
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
PATCH v9 7/16 mmc: sdhci-msm: Add get_min_clock() and get_max_clock() callback
In reply to Ritesh HarjaniThis add get_min_clock() and get_max_clock() callback for sdhci-msm. sdhci-msm min/max clocks may be different hence implement these callbacks.
--- drivers/mmc/host/sdhci-msm.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)
drivers/mmc/host/sdhci-msm.c +17 -0
@@ -68,6 +68,8 @@#define CORE_VENDOR_SPEC_CAPABILITIES0 0x11c +#define SDHCI_MSM_MIN_CLOCK 400000 +#define CDR_SELEXT_SHIFT 20#define CDR_SELEXT_MASK (0xf << CDR_SELEXT_SHIFT)#define CMUX_SHIFT_PHASE_SHIFT 24
@@ -556,6 +558,19 @@ static irqreturn_t sdhci_msm_pwr_irq(int irq, void *data)return IRQ_HANDLED ; } +static unsigned int sdhci_msm_get_max_clock (struct sdhci_host *host) +{ +struct sdhci_pltfm_host *pltfm_host =sdhci_priv (host); +struct sdhci_msm_host *msm_host =sdhci_pltfm_priv (pltfm_host); + +return clk_round_rate (msm_host->clk,ULONG_MAX ); +} + +static unsigned int sdhci_msm_get_min_clock (struct sdhci_host *host) +{ +return SDHCI_MSM_MIN_CLOCK ; +} +static const struct of_device_id sdhci_msm_dt_match[] = { { .compatible ="qcom,sdhci-msm-v4" }, {},
@@ -567,6 +582,8 @@ static irqreturn_t sdhci_msm_pwr_irq(int irq, void *data) .platform_execute_tuning = sdhci_msm_execute_tuning, .reset = sdhci_reset, .set_clock = sdhci_set_clock, + .get_min_clock = sdhci_msm_get_min_clock, + .get_max_clock = sdhci_msm_get_max_clock, .set_bus_width = sdhci_set_bus_width, .set_uhs_signaling = sdhci_msm_set_uhs_signaling, .voltage_switch = sdhci_msm_voltage_switch,
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
Re: [PATCH v9 07/16] mmc: sdhci-msm: Add get_min_clock() and get_max_clock() callback
Quoted 7 lines · Ritesh Harjani
This add
get_min_clock()andget_max_clock()callback for sdhci-msm. sdhci-msm min/max clocks may be different hence implement these callbacks.Signed-off-by Sahitya Tummala <[email protected]>Signed-off-by Ritesh Harjani <[email protected]>Acked-by Adrian Hunter <[email protected]>
This patch needs to be picked up for stable as 4.9 is currently broken w.r.t. MMC on Qualcomm platforms.
Regards,
Andy Gross
Re: [PATCH v9 07/16] mmc: sdhci-msm: Add get_min_clock() and get_max_clock() callback
Quoted 5 lines · Andy Gross
Quoted 4 lines · Ritesh Harjani
This add
get_min_clock()andget_max_clock()callback for sdhci-msm. sdhci-msm min/max clocks may be different hence implement these callbacks.
Quoted 8 lines
Quoted 3 lines
Signed-off-by Sahitya Tummala <[email protected]>Signed-off-by Ritesh Harjani <[email protected]>Acked-by Adrian Hunter <[email protected]>This patch needs to be picked up for stable as 4.9 is currently broken w.r.t. MMC on Qualcomm platforms.
Fixes d84be51d1c1d ("mmc: sdhci-msm: Enable few quirks")
Agree! Applying this patch (80031bdeb764) in stable fixes the broken mmc. Otherwise the following error is seen since v4.9.22:
mmc0: Hardware doesn't specify base clock frequency.
Thanks,
Georgi
Re: [PATCH v9 07/16] mmc: sdhci-msm: Add get_min_clock() and get_max_clock() callback
In reply to Andy Gross+Greg
-trimmed cc
Quoted 9 lines · Andy Gross
Quoted 7 lines · Ritesh Harjani
This add
get_min_clock()andget_max_clock()callback for sdhci-msm. sdhci-msm min/max clocks may be different hence implement these callbacks.Signed-off-by Sahitya Tummala <[email protected]>Signed-off-by Ritesh Harjani <[email protected]>Acked-by Adrian Hunter <[email protected]>
Quoted 8 lines
This patch needs to be picked up for stable as 4.9 is currently broken w.r.t. MMC on Qualcomm platforms.
Fixes d84be51d1c1d ("mmc: sdhci-msm: Enable few quirks")Regards,
Andy Gross
I did a quick investigation around this.
So for some reason Greg decided to pick up the original commit, a0e3142869d2 ("mmc: sdhci-msm: Enable few quirks"), for 4.9 stable [1], even if that patch wasn't sent or tagged for stable. It was a mistake, as simple as that - and I should also have spotted it when Greg posted his stable-review series, sorry.
For clarification, the original commit a0e3142869d2 ("mmc: sdhci-msm:
Enable few quirks"), is present in 4.10 together with $subject patch. So the regression is present only in 4.9 stable.
Greg, can you pick up @subject patch for stable according to Andy's suggestion or you want some of us to re-post it to stable?
Kind regards
Uffe
Greg Kroah-Hartman
maintainerRe: [PATCH v9 07/16] mmc: sdhci-msm: Add get_min_clock() and get_max_clock() callback
Quoted 30 lines · Ulf Hansson
(quoted diff) +1
-1+Greg -trimmed ccQuoted 9 lines · Andy Gross
Quoted 7 lines · Ritesh Harjani
This add
get_min_clock()andget_max_clock()callback for sdhci-msm. sdhci-msm min/max clocks may be different hence implement these callbacks.Signed-off-by Sahitya Tummala <[email protected]>Signed-off-by Ritesh Harjani <[email protected]>Acked-by Adrian Hunter <[email protected]>Quoted 8 lines
This patch needs to be picked up for stable as 4.9 is currently broken w.r.t. MMC on Qualcomm platforms.
Fixes d84be51d1c1d ("mmc: sdhci-msm: Enable few quirks")Regards,
Andy Gross
I did a quick investigation around this.
So for some reason Greg decided to pick up the original commit,
a0e3142869d2("mmc: sdhci-msm: Enable few quirks"), for 4.9 stable [1], even if that patch wasn't sent or tagged for stable. It was a mistake, as simple as that - and I should also have spotted it when Greg posted his stable-review series, sorry.
Quoted 6 lines
For clarification, the original commit
a0e3142869d2("mmc: sdhci-msm:
Enable few quirks"), is present in 4.10 together with $subject patch. So the regression is present only in 4.9 stable.Greg, can you pick up @subject patch for stable according to Andy's suggestion or you want some of us to re-post it to stable?
Sorry about this. What git commit should I take for this from Linus's tree for the 4.9-stable tree? Or if there isn't one, I'll be glad to just revert this.
thanks,
greg k-h
Re: [PATCH v9 07/16] mmc: sdhci-msm: Add get_min_clock() and get_max_clock() callback
Quoted 35 lines · Greg Kroah-Hartman
Quoted 34 lines · Ulf Hansson
(quoted diff) +1
-1+Greg -trimmed ccQuoted 9 lines · Andy Gross
Quoted 7 lines · Ritesh Harjani
This add
get_min_clock()andget_max_clock()callback for sdhci-msm. sdhci-msm min/max clocks may be different hence implement these callbacks.Signed-off-by Sahitya Tummala <[email protected]>Signed-off-by Ritesh Harjani <[email protected]>Acked-by Adrian Hunter <[email protected]>Quoted 8 lines
This patch needs to be picked up for stable as 4.9 is currently broken w.r.t. MMC on Qualcomm platforms.
Fixes d84be51d1c1d ("mmc: sdhci-msm: Enable few quirks")Regards,
Andy Gross
I did a quick investigation around this.
So for some reason Greg decided to pick up the original commit,
a0e3142869d2("mmc: sdhci-msm: Enable few quirks"), for 4.9 stable [1], even if that patch wasn't sent or tagged for stable. It was a mistake, as simple as that - and I should also have spotted it when Greg posted his stable-review series, sorry.For clarification, the original commit
a0e3142869d2("mmc: sdhci-msm:
Enable few quirks"), is present in 4.10 together with $subject patch. So the regression is present only in 4.9 stable.
Quoted 7 lines
Quoted 2 lines
Greg, can you pick up @subject patch for stable according to Andy's suggestion or you want some of us to re-post it to stable?
Sorry about this. What git commit should I take for this from Linus's tree for the 4.9-stable tree? Or if there isn't one, I'll be glad to just revert this.
Thanks Greg and Ulf,
A revert of d84be51d1c1d ("mmc: sdhci-msm: Enable few quirks") would be the best solution.
The other option is to pick 80031bdeb764 ("mmc: sdhci-msm: Add get_min_clock() and get_max_clock() callback").
BR,
Georgi
Greg Kroah-Hartman
maintainerRe: [PATCH v9 07/16] mmc: sdhci-msm: Add get_min_clock() and get_max_clock() callback
Quoted 44 lines · Georgi Djakov
Quoted 35 lines · Greg Kroah-Hartman
Quoted 34 lines · Ulf Hansson
(quoted diff) +1
-1+Greg -trimmed ccQuoted 9 lines · Andy Gross
Quoted 7 lines · Ritesh Harjani
This add
get_min_clock()andget_max_clock()callback for sdhci-msm. sdhci-msm min/max clocks may be different hence implement these callbacks.Signed-off-by Sahitya Tummala <[email protected]>Signed-off-by Ritesh Harjani <[email protected]>Acked-by Adrian Hunter <[email protected]>Quoted 8 lines
This patch needs to be picked up for stable as 4.9 is currently broken w.r.t. MMC on Qualcomm platforms.
Fixes d84be51d1c1d ("mmc: sdhci-msm: Enable few quirks")Regards,
Andy Gross
I did a quick investigation around this.
So for some reason Greg decided to pick up the original commit,
a0e3142869d2("mmc: sdhci-msm: Enable few quirks"), for 4.9 stable [1], even if that patch wasn't sent or tagged for stable. It was a mistake, as simple as that - and I should also have spotted it when Greg posted his stable-review series, sorry.For clarification, the original commit
a0e3142869d2("mmc: sdhci-msm:
Enable few quirks"), is present in 4.10 together with $subject patch. So the regression is present only in 4.9 stable.Quoted 7 lines
Quoted 2 lines
Greg, can you pick up @subject patch for stable according to Andy's suggestion or you want some of us to re-post it to stable?
Sorry about this. What git commit should I take for this from Linus's tree for the 4.9-stable tree? Or if there isn't one, I'll be glad to just revert this.
Quoted 7 lines
Thanks Greg and Ulf,
A revert of
d84be51d1c1d("mmc: sdhci-msm: Enable few quirks") would be the best solution.The other option is to pick
80031bdeb764("mmc: sdhci-msm: Addget_min_clock()andget_max_clock()callback").
I've reverted it now, thanks.
greg k-h
Re: [PATCH v9 07/16] mmc: sdhci-msm: Add get_min_clock() and get_max_clock() callback
Quoted 47 lines · Greg Kroah-Hartman
Quoted 46 lines · Georgi Djakov
Quoted 35 lines · Greg Kroah-Hartman
Quoted 34 lines · Ulf Hansson
(quoted diff) +1
-1+Greg -trimmed ccQuoted 9 lines · Andy Gross
Quoted 7 lines · Ritesh Harjani
This add
get_min_clock()andget_max_clock()callback for sdhci-msm. sdhci-msm min/max clocks may be different hence implement these callbacks.Signed-off-by Sahitya Tummala <[email protected]>Signed-off-by Ritesh Harjani <[email protected]>Acked-by Adrian Hunter <[email protected]>Quoted 8 lines
This patch needs to be picked up for stable as 4.9 is currently broken w.r.t. MMC on Qualcomm platforms.
Fixes d84be51d1c1d ("mmc: sdhci-msm: Enable few quirks")Regards,
Andy Gross
I did a quick investigation around this.
So for some reason Greg decided to pick up the original commit,
a0e3142869d2("mmc: sdhci-msm: Enable few quirks"), for 4.9 stable [1], even if that patch wasn't sent or tagged for stable. It was a mistake, as simple as that - and I should also have spotted it when Greg posted his stable-review series, sorry.For clarification, the original commit
a0e3142869d2("mmc: sdhci-msm:
Enable few quirks"), is present in 4.10 together with $subject patch. So the regression is present only in 4.9 stable.Quoted 7 lines
Quoted 2 lines
Greg, can you pick up @subject patch for stable according to Andy's suggestion or you want some of us to re-post it to stable?
Sorry about this. What git commit should I take for this from Linus's tree for the 4.9-stable tree? Or if there isn't one, I'll be glad to just revert this.
Thanks Greg and Ulf,
Quoted 7 lines
Quoted 5 lines
A revert of
d84be51d1c1d("mmc: sdhci-msm: Enable few quirks") would be the best solution.The other option is to pick
80031bdeb764("mmc: sdhci-msm: Addget_min_clock()andget_max_clock()callback").I've reverted it now, thanks.
Thanks Ulf, Greg and all.
Regards
Ritesh
Quoted 7 lines
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v9 07/16] mmc: sdhci-msm: Add get_min_clock() and get_max_clock() callback
In reply to Greg Kroah-HartmanQuoted 1 line · Greg Kroah-Hartman
I've reverted it now, thanks.
Thanks Greg!
Regards,
Andy
PATCH v9 8/16 mmc: sdhci-msm: Enable few quirks
In reply to Ritesh Harjanisdhc-msm controller needs this SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN & SDHCI_QUIRK2_PRESET_VALUE_BROKEN to be set. Hence setting it.
--- drivers/mmc/host/sdhci-msm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/mmc/host/sdhci-msm.c +3 -1
@@ -592,7 +592,9 @@ static unsigned int sdhci_msm_get_min_clock(struct sdhci_host *host)static const struct sdhci_pltfm_data sdhci_msm_pdata = { .quirks =SDHCI_QUIRK_BROKEN_CARD_DETECTION |SDHCI_QUIRK_NO_CARD_NO_RESET | -SDHCI_QUIRK_SINGLE_POWER_WRITE , +SDHCI_QUIRK_SINGLE_POWER_WRITE | +SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN , + .quirks2 =SDHCI_QUIRK2_PRESET_VALUE_BROKEN , .ops = &sdhci_msm_ops, };
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
PATCH v9 9/16 mmc: sdhci: Factor out sdhci_enable_clk
In reply to Ritesh HarjaniFactor out sdhci_enable_clk from sdhci_set_clock and make it EXPORT_SYMBOL so that it can be called.
--- drivers/mmc/host/sdhci.c | 28 +++++++++++++++++----------- drivers/mmc/host/sdhci.h | 1 + 2 files changed, 18 insertions(+), 11 deletions(-)
drivers/mmc/host/sdhci.c +17 -11
@@ -1344,20 +1344,10 @@ u16 sdhci_calc_clk(struct sdhci_host *host, unsigned int clock, }EXPORT_SYMBOL_GPL (sdhci_calc_clk); -void sdhci_set_clock (struct sdhci_host *host,unsigned int clock) +void sdhci_enable_clk (struct sdhci_host *host,u16 clk) { -u16 clk;unsigned long timeout; - host->mmc->actual_clock =0 ; - -sdhci_writew (host,0 ,SDHCI_CLOCK_CONTROL ); - -if (clock ==0 ) -return ; - - clk =sdhci_calc_clk (host, clock, &host->mmc->actual_clock); - clk |=SDHCI_CLOCK_INT_EN ;sdhci_writew (host, clk,SDHCI_CLOCK_CONTROL );
@@ -1378,6 +1368,22 @@ void sdhci_set_clock(struct sdhci_host *host, unsigned int clock) clk |=SDHCI_CLOCK_CARD_EN ;sdhci_writew (host, clk,SDHCI_CLOCK_CONTROL ); } +EXPORT_SYMBOL_GPL (sdhci_enable_clk); + +void sdhci_set_clock (struct sdhci_host *host,unsigned int clock) +{ +u16 clk; + + host->mmc->actual_clock =0 ; + +sdhci_writew (host,0 ,SDHCI_CLOCK_CONTROL ); + +if (clock ==0 ) +return ; + + clk =sdhci_calc_clk (host, clock, &host->mmc->actual_clock); +sdhci_enable_clk (host, clk); +}EXPORT_SYMBOL_GPL (sdhci_set_clock); static void sdhci_set_power_reg(struct sdhci_host *host, unsigned char mode,
drivers/mmc/host/sdhci.h +1 -0
@@ -682,6 +682,7 @@ static inline bool sdhci_sdio_irq_enabled(struct sdhci_host *host)u16 sdhci_calc_clk (struct sdhci_host *host,unsigned int clock,unsigned int *actual_clock);void sdhci_set_clock (struct sdhci_host *host,unsigned int clock); +void sdhci_enable_clk (struct sdhci_host *host,u16 clk);void sdhci_set_power (struct sdhci_host *host,unsigned char mode,unsigned short vdd); void sdhci_set_power_noreg(struct sdhci_host *host, unsigned char mode,
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
A message that is not in the archive (sent off-list or not yet received): 1479710246-26676-10-git-send-email-riteshh-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org
Adrian Hunter
Acked-byRe: [PATCH v9 09/16] mmc: sdhci: Factor out sdhci_enable_clk
Quoted 4 lines · Ritesh Harjani
Factor out
sdhci_enable_clkfromsdhci_set_clockand make itEXPORT_SYMBOLso that it can be called.Signed-off-by Ritesh Harjani <[email protected]>
Quoted 60 lines
--- drivers/mmc/host/sdhci.c | 28 +++++++++++++++++----------- drivers/mmc/host/sdhci.h | 1 + 2 files changed, 18 insertions(+), 11 deletions(-)drivers/mmc/host/sdhci.c +17
-11@@ -1344,20 +1344,10 @@ u16 sdhci_calc_clk(struct sdhci_host *host, unsigned int clock, }EXPORT_SYMBOL_GPL (sdhci_calc_clk); -void sdhci_set_clock (struct sdhci_host *host,unsigned int clock) +void sdhci_enable_clk (struct sdhci_host *host,u16 clk) { -u16 clk;unsigned long timeout; - host->mmc->actual_clock =0 ; - -sdhci_writew (host,0 ,SDHCI_CLOCK_CONTROL ); - -if (clock ==0 ) -return ; - - clk =sdhci_calc_clk (host, clock, &host->mmc->actual_clock); - clk |=SDHCI_CLOCK_INT_EN ;sdhci_writew (host, clk,SDHCI_CLOCK_CONTROL );@@ -1378,6 +1368,22 @@ void sdhci_set_clock(struct sdhci_host *host, unsigned int clock) clk |=SDHCI_CLOCK_CARD_EN ;sdhci_writew (host, clk,SDHCI_CLOCK_CONTROL ); } +EXPORT_SYMBOL_GPL (sdhci_enable_clk); + +void sdhci_set_clock (struct sdhci_host *host,unsigned int clock) +{ +u16 clk; + + host->mmc->actual_clock =0 ; + +sdhci_writew (host,0 ,SDHCI_CLOCK_CONTROL ); + +if (clock ==0 ) +return ; + + clk =sdhci_calc_clk (host, clock, &host->mmc->actual_clock); +sdhci_enable_clk (host, clk); +}EXPORT_SYMBOL_GPL (sdhci_set_clock); static void sdhci_set_power_reg(struct sdhci_host *host, unsigned char mode,drivers/mmc/host/sdhci.h +0
-0
drivers/mmc/host/sdhci.h static inline bool sdhci_sdio_irq_enabled(struct sdhci_host *host) · line 688
Quoted 7 lines
drivers/mmc/host/sdhci.h +1
-0@@ -682,6 +682,7 @@ static inline bool sdhci_sdio_irq_enabled(struct sdhci_host *host)u16 sdhci_calc_clk (struct sdhci_host *host,unsigned int clock,unsigned int *actual_clock);void sdhci_set_clock (struct sdhci_host *host,unsigned int clock); +void sdhci_enable_clk (struct sdhci_host *host,u16 clk);void sdhci_set_power (struct sdhci_host *host,unsigned char mode,unsigned short vdd); void sdhci_set_power_noreg(struct sdhci_host *host, unsigned char mode,
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): 1479710246-26676-1-git-send-email-riteshh-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org
PATCH v9 10/16 mmc: sdhci-msm: Implement set_clock callback for sdhci-msm
sdhci-msm controller may have different clk-rates for each bus speed mode. Thus implement set_clock callback for sdhci-msm driver.
--- drivers/mmc/host/sdhci-msm.c | 66 +++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 65 insertions(+), 1 deletion(-)
drivers/mmc/host/sdhci-msm.c +65 -1
@@ -84,6 +84,7 @@ struct sdhci_msm_host {struct clk *pclk;/* SDHC peripheral bus clock */ struct clk *bus_clk;/* SDHC bus voter clock */ struct clk *xo_clk;/* TCXO clk needed for FLL feature of cm_dll*/ +unsigned long clk_rate;struct mmc_host *mmc;bool use_14lpp_dll_reset; };
@@ -571,6 +572,69 @@ static unsigned int sdhci_msm_get_min_clock(struct sdhci_host *host)return SDHCI_MSM_MIN_CLOCK ; } +/** +* __sdhci_msm_set_clock - sdhci_msm clock control. +* +* Description: +* MSM controller does not use internal divider and +* instead directly control the GCC clock as per +* HW recommendation. +**/ +void __sdhci_msm_set_clock (struct sdhci_host *host,unsigned int clock) +{ +u16 clk; +/* +* Keep actual_clock as zero - +* - since there is no divider used so no need of having actual_clock. +* - MSM controller uses SDCLK for data timeout calculation. If +* actual_clock is zero, host->clock is taken for calculation. +*/ + host->mmc->actual_clock =0 ; + +sdhci_writew (host,0 ,SDHCI_CLOCK_CONTROL ); + +if (clock ==0 ) +return ; + +/* +* MSM controller do not use clock divider. +* Thus read SDHCI_CLOCK_CONTROL and only enable +* clock with no divider value programmed. +*/ + clk =sdhci_readw (host,SDHCI_CLOCK_CONTROL ); +sdhci_enable_clk (host, clk); +} + +/* sdhci_msm_set_clock - Called with (host->lock) spinlock held. */ +static void sdhci_msm_set_clock (struct sdhci_host *host,unsigned int clock) +{ +struct sdhci_pltfm_host *pltfm_host =sdhci_priv (host); +struct sdhci_msm_host *msm_host =sdhci_pltfm_priv (pltfm_host); +int rc; + +if (!clock) { + msm_host->clk_rate = clock; + goto out; + } + +spin_unlock_irq (&host->lock); + + rc =clk_set_rate (msm_host->clk, clock); +if (rc) { +pr_err ("%s: Failed to set clock at rate %u\n" , +mmc_hostname (host->mmc), clock); + goto out_lock; + } + msm_host->clk_rate = clock; +pr_debug ("%s: Setting clock at rate %lu\n" , +mmc_hostname (host->mmc),clk_get_rate (msm_host->clk)); + +out_lock: +spin_lock_irq (&host->lock); +out: +__sdhci_msm_set_clock (host, clock); +} +static const struct of_device_id sdhci_msm_dt_match[] = { { .compatible ="qcom,sdhci-msm-v4" }, {},
@@ -581,7 +645,7 @@ static unsigned int sdhci_msm_get_min_clock(struct sdhci_host *host)static const struct sdhci_ops sdhci_msm_ops = { .platform_execute_tuning = sdhci_msm_execute_tuning, .reset = sdhci_reset, - .set_clock = sdhci_set_clock, + .set_clock = sdhci_msm_set_clock, .get_min_clock = sdhci_msm_get_min_clock, .get_max_clock = sdhci_msm_get_max_clock, .set_bus_width = sdhci_set_bus_width,
Signature · 7 lines
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH v9 13/16 mmc: sdhci-msm: Add HS400 platform support
In reply to a message not in the archiveFrom: Venkat Gopalakrishnan <[email protected]>
The following msm platform specific changes are added to support HS400.
- Allow tuning for HS400 mode.
- Configure HS400 timing mode using the VENDOR_SPECIFIC_FUNC register.
--- drivers/mmc/host/sdhci-msm.c | 122 +++++++++++++++++++++++++++++++++++++++---- 1 file changed, 112 insertions(+), 10 deletions(-)
drivers/mmc/host/sdhci-msm.c +112 -10
@@ -32,6 +32,7 @@#define HC_MODE_EN 0x1#define CORE_POWER 0x0#define CORE_SW_RST BIT(7) +#define FF_CLK_SW_RST_DIS BIT(13)#define CORE_PWRCTL_STATUS 0xdc#define CORE_PWRCTL_MASK 0xe0
@@ -65,10 +66,17 @@#define CORE_VENDOR_SPEC 0x10c#define CORE_CLK_PWRSAVE BIT(1) +#define CORE_HC_MCLK_SEL_DFLT (2 << 8) +#define CORE_HC_MCLK_SEL_HS400 (3 << 8) +#define CORE_HC_MCLK_SEL_MASK (3 << 8) +#define CORE_HC_SELECT_IN_EN BIT(18) +#define CORE_HC_SELECT_IN_HS400 (6 << 19) +#define CORE_HC_SELECT_IN_MASK (7 << 19)#define CORE_VENDOR_SPEC_CAPABILITIES0 0x11c#define SDHCI_MSM_MIN_CLOCK 400000 +#define CORE_FREQ_100MHZ (100 * 1000 * 1000)#define CDR_SELEXT_SHIFT 20#define CDR_SELEXT_MASK (0xf << CDR_SELEXT_SHIFT)
@@ -87,6 +95,8 @@ struct sdhci_msm_host {unsigned long clk_rate;struct mmc_host *mmc;bool use_14lpp_dll_reset; +bool tuning_done; +bool calibration_done; };/* Platform specific tuning */
@@ -174,8 +184,8 @@ static int msm_config_cm_dll_phase(struct sdhci_host *host, u8 phase)* Find out the greatest range of consecuitive selected * DLL clock output phases that can be used as sampling * setting for SD3.0 UHS-I card read operation (in SDR104 -* timing mode) or for eMMC4.5 card read operation (in HS200 -* timing mode). +* timing mode) or for eMMC4.5 card read operation (in +* HS400/HS200 timing mode). * Select the 3/4 of the range and configure the DLL with the * selected DLL clock output phase. */
@@ -424,9 +434,10 @@ static int sdhci_msm_execute_tuning(struct sdhci_host *host, u32 opcode)* Tuning is required for SDR104, HS200 and HS400 cards and * if clock frequency is greater than 100MHz in these modes. */ -if (host->clock <=100 *1000 *1000 || - !((ios.timing ==MMC_TIMING_MMC_HS200 ) || - (ios.timing ==MMC_TIMING_UHS_SDR104 ))) +if (host->clock <=CORE_FREQ_100MHZ || + !(ios.timing ==MMC_TIMING_MMC_HS400 || + ios.timing ==MMC_TIMING_MMC_HS200 || + ios.timing ==MMC_TIMING_UHS_SDR104 ))return 0 ; retry:
@@ -477,6 +488,8 @@ static int sdhci_msm_execute_tuning(struct sdhci_host *host, u32 opcode) rc = -EIO ; } +if (!rc) + msm_host->tuning_done = true;return rc; }
@@ -484,7 +497,10 @@ static void sdhci_msm_set_uhs_signaling(struct sdhci_host *host, unsigned int uhs) {struct mmc_host *mmc = host->mmc; +struct sdhci_pltfm_host *pltfm_host =sdhci_priv (host); +struct sdhci_msm_host *msm_host =sdhci_pltfm_priv (pltfm_host);u16 ctrl_2; +u32 config; ctrl_2 =sdhci_readw (host,SDHCI_HOST_CONTROL2 );/* Select Bus Speed Mode for host */
@@ -499,6 +515,7 @@ static void sdhci_msm_set_uhs_signaling(struct sdhci_host *host,case MMC_TIMING_UHS_SDR50 : ctrl_2 |=SDHCI_CTRL_UHS_SDR50 ;break ; +case MMC_TIMING_MMC_HS400 :case MMC_TIMING_MMC_HS200 :case MMC_TIMING_UHS_SDR104 : ctrl_2 |=SDHCI_CTRL_UHS_SDR104 ;
@@ -515,11 +532,29 @@ static void sdhci_msm_set_uhs_signaling(struct sdhci_host *host,* provide feedback clock, the mode selection can be any value less * than 3'b011 in bits [2:0] of HOST CONTROL2 register. */ -if (host->clock <=100000000 && - (uhs ==MMC_TIMING_MMC_HS400 || - uhs ==MMC_TIMING_MMC_HS200 || - uhs ==MMC_TIMING_UHS_SDR104 )) - ctrl_2 &= ~SDHCI_CTRL_UHS_MASK ; +if (host->clock <=CORE_FREQ_100MHZ ) { +if (uhs ==MMC_TIMING_MMC_HS400 || + uhs ==MMC_TIMING_MMC_HS200 || + uhs ==MMC_TIMING_UHS_SDR104 ) + ctrl_2 &= ~SDHCI_CTRL_UHS_MASK ; +/* +* DLL is not required for clock <= 100MHz +* Thus, make sure DLL it is disabled when not required +*/ + config =readl_relaxed (host->ioaddr +CORE_DLL_CONFIG ); + config |=CORE_DLL_RST ; +writel_relaxed (config, host->ioaddr +CORE_DLL_CONFIG ); + + config =readl_relaxed (host->ioaddr +CORE_DLL_CONFIG ); + config |=CORE_DLL_PDN ; +writel_relaxed (config, host->ioaddr +CORE_DLL_CONFIG ); + +/* +* The DLL needs to be restored and CDCLP533 recalibrated +* when the clock frequency is set back to 400MHz. +*/ + msm_host->calibration_done = false; + }dev_dbg (mmc_dev (mmc),"%s: clock=%u uhs=%u ctrl_2=0x%x\n" ,mmc_hostname (host->mmc), host->clock, uhs, ctrl_2);
@@ -611,6 +646,7 @@ static void sdhci_msm_set_clock(struct sdhci_host *host, unsigned int clock)struct sdhci_pltfm_host *pltfm_host =sdhci_priv (host);struct sdhci_msm_host *msm_host =sdhci_pltfm_priv (pltfm_host);struct mmc_ios curr_ios = host->mmc->ios; +u32 config;int rc;if (!clock) {
@@ -629,6 +665,68 @@ static void sdhci_msm_set_clock(struct sdhci_host *host, unsigned int clock) curr_ios.timing == MMC_TIMING_MMC_DDR52 || curr_ios.timing == MMC_TIMING_MMC_HS400) clock *=2 ; +/* +* In general all timing modes are controlled via UHS mode select in +* Host Control2 register. eMMC specific HS200/HS400 doesn't have +* their respective modes defined here, hence we use these values. +* +* HS200 - SDR104 (Since they both are equivalent in functionality) +* HS400 - This involves multiple configurations +* Initially SDR104 - when tuning is required as HS200 +* Then when switching to DDR @ 400MHz (HS400) we use +* the vendor specific HC_SELECT_IN to control the mode. +* +* In addition to controlling the modes we also need to select the +* correct input clock for DLL depending on the mode. +* +* HS400 - divided clock (free running MCLK/2) +* All other modes - default (free running MCLK) +*/ +if (curr_ios.timing ==MMC_TIMING_MMC_HS400 ) { +/* Select the divided clock (free running MCLK/2) */ + config =readl_relaxed (host->ioaddr +CORE_VENDOR_SPEC ); + config &= ~CORE_HC_MCLK_SEL_MASK ; + config |=CORE_HC_MCLK_SEL_HS400 ; + +writel_relaxed (config, host->ioaddr +CORE_VENDOR_SPEC ); +/* +* Select HS400 mode using the HC_SELECT_IN from VENDOR SPEC +* register +*/ +if (msm_host->tuning_done && !msm_host->calibration_done) { +/* +* Write 0x6 to HC_SELECT_IN and 1 to HC_SELECT_IN_EN +* field in VENDOR_SPEC_FUNC +*/ + config =readl_relaxed (host->ioaddr +CORE_VENDOR_SPEC ); + config |=CORE_HC_SELECT_IN_HS400 ; + config |=CORE_HC_SELECT_IN_EN ; +writel_relaxed (config, host->ioaddr +CORE_VENDOR_SPEC ); + } + }else { + config =readl_relaxed (host->ioaddr +CORE_VENDOR_SPEC ); + config &= ~CORE_HC_MCLK_SEL_MASK ; + config |=CORE_HC_MCLK_SEL_DFLT ; +writel_relaxed (config, host->ioaddr +CORE_VENDOR_SPEC ); + +/* +* Disable HC_SELECT_IN to be able to use the UHS mode select +* configuration from Host Control2 register for all other +* modes. +* Write 0 to HC_SELECT_IN and HC_SELECT_IN_EN field +* in VENDOR_SPEC_FUNC +*/ + config =readl_relaxed (host->ioaddr +CORE_VENDOR_SPEC ); + config &= ~CORE_HC_SELECT_IN_EN ; + config &= ~CORE_HC_SELECT_IN_MASK ; +writel_relaxed (config, host->ioaddr +CORE_VENDOR_SPEC ); + } + +/* +* Make sure above writes impacting free running MCLK are completed +* before changing the clk_rate at GCC. +*/ +wmb (); rc =clk_set_rate (msm_host->clk, clock);if (rc) {
@@ -776,6 +874,10 @@ static int sdhci_msm_probe(struct platform_device *pdev)/* Set HC_MODE_EN bit in HC_MODE register */ writel_relaxed (HC_MODE_EN , (msm_host->core_mem +CORE_HC_MODE )); + config =readl_relaxed (msm_host->core_mem +CORE_HC_MODE ); + config |=FF_CLK_SW_RST_DIS ; +writel_relaxed (config, msm_host->core_mem +CORE_HC_MODE ); + host_version =readw_relaxed ((host->ioaddr +SDHCI_HOST_VERSION )); dev_dbg(&pdev->dev, "Host Version: 0x%x Vendor Version 0x%x\n", host_version, ((host_version & SDHCI_VENDOR_VER_MASK) >>
Signature · 7 lines
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH v9 16/16 sdhci: sdhci-msm: update dll configuration
In reply to a message not in the archiveThe newer msm sdhci's cores use a different DLL hardware for HS400. Update the configuration and calibration of the newer DLL block.
The HS400 DLL block used previously is CDC LP 533 and requires programming multiple registers and waiting for configuration to complete and then enable it. It has about 18 register writes and two register reads.
The newer HS400 DLL block is SDC4 DLL and requires two register writes for configuration and one register read to confirm that it is initialized. There is an additional register write to enable the power save mode for SDC4 DLL block.
--- drivers/mmc/host/sdhci-msm.c | 125 ++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 123 insertions(+), 2 deletions(-)
drivers/mmc/host/sdhci-msm.c +123 -2
@@ -52,6 +52,7 @@#define INT_MASK 0xf#define MAX_PHASES 16#define CORE_DLL_LOCK BIT(7) +#define CORE_DDR_DLL_LOCK BIT(11)#define CORE_DLL_EN BIT(16)#define CORE_CDR_EN BIT(17)#define CORE_CK_OUT_EN BIT(18)
@@ -63,6 +64,7 @@#define CORE_DLL_STATUS 0x108#define CORE_DLL_CONFIG_2 0x1b4 +#define CORE_DDR_CAL_EN BIT(0)#define CORE_FLL_CYCLE_CNT BIT(18)#define CORE_DLL_CLOCK_DISABLE BIT(21)
@@ -101,6 +103,11 @@#define CORE_DDR_200_CFG 0x184#define CORE_CDC_T4_DLY_SEL BIT(0)#define CORE_START_CDC_TRAFFIC BIT(6) +#define CORE_VENDOR_SPEC3 0x1b0 +#define CORE_PWRSAVE_DLL BIT(3) + +#define CORE_DDR_CONFIG 0x1b8 +#define DDR_CONFIG_POR_VAL 0x80040853#define CORE_VENDOR_SPEC_CAPABILITIES0 0x11c
@@ -128,6 +135,7 @@ struct sdhci_msm_host {bool tuning_done;bool calibration_done;u8 saved_tuning_phase; +bool use_cdclp533; };/* Platform specific tuning */
@@ -569,6 +577,87 @@ static int sdhci_msm_cdclp533_calibration(struct sdhci_host *host)return ret; } +static int sdhci_msm_cm_dll_sdc4_calibration (struct sdhci_host *host) +{ +u32 dll_status, config; +int ret; + +pr_debug ("%s: %s: Enter\n" ,mmc_hostname (host->mmc), __func__); + +/* +* Currently the CORE_DDR_CONFIG register defaults to desired +* configuration on reset. Currently reprogramming the power on +* reset (POR) value in case it might have been modified by +* bootloaders. In the future, if this changes, then the desired +* values will need to be programmed appropriately. +*/ +writel_relaxed (DDR_CONFIG_POR_VAL , host->ioaddr +CORE_DDR_CONFIG ); + + config =readl_relaxed (host->ioaddr +CORE_DLL_CONFIG_2 ); + config |=CORE_DDR_CAL_EN ; +writel_relaxed (config, host->ioaddr +CORE_DLL_CONFIG_2 ); + + ret =readl_relaxed_poll_timeout (host->ioaddr +CORE_DLL_STATUS , + dll_status, + (dll_status &CORE_DDR_DLL_LOCK ), +10 ,1000 ); + +if (ret == -ETIMEDOUT ) { +pr_err ("%s: %s: CM_DLL_SDC4 calibration was not completed\n" , +mmc_hostname (host->mmc), __func__); + goto out; + } + + config =readl_relaxed (host->ioaddr +CORE_VENDOR_SPEC3 ); + config |=CORE_PWRSAVE_DLL ; +writel_relaxed (config, host->ioaddr +CORE_VENDOR_SPEC3 ); + +/* +* Drain writebuffer to ensure above DLL calibration +* and PWRSAVE DLL is enabled. +*/ +wmb (); +out: +pr_debug ("%s: %s: Exit, ret %d\n" ,mmc_hostname (host->mmc), + __func__, ret); +return ret; +} + +static int sdhci_msm_hs400_dll_calibration (struct sdhci_host *host) +{ +struct sdhci_pltfm_host *pltfm_host =sdhci_priv (host); +struct sdhci_msm_host *msm_host =sdhci_pltfm_priv (pltfm_host); +int ret; +u32 config; + +pr_debug ("%s: %s: Enter\n" ,mmc_hostname (host->mmc), __func__); + +/* +* Retuning in HS400 (DDR mode) will fail, just reset the +* tuning block and restore the saved tuning phase. +*/ + ret =msm_init_cm_dll (host); +if (ret) + goto out; + +/* Set the selected phase in delay line hw block */ + ret =msm_config_cm_dll_phase (host, msm_host->saved_tuning_phase); +if (ret) + goto out; + + config =readl_relaxed (host->ioaddr +CORE_DLL_CONFIG ); + config |=CORE_CMD_DAT_TRACK_SEL ; +writel_relaxed (config, host->ioaddr +CORE_DLL_CONFIG ); +if (msm_host->use_cdclp533) + ret =sdhci_msm_cdclp533_calibration (host); +else + ret =sdhci_msm_cm_dll_sdc4_calibration (host); +out: +pr_debug ("%s: %s: Exit, ret %d\n" ,mmc_hostname (host->mmc), + __func__, ret); +return ret; +} +static int sdhci_msm_execute_tuning (struct sdhci_host *host,u32 opcode) {int tuning_seq_cnt =3 ;
@@ -715,7 +804,7 @@ static void sdhci_msm_set_uhs_signaling(struct sdhci_host *host,if (host->clock >CORE_FREQ_100MHZ && msm_host->tuning_done && !msm_host->calibration_done && mmc->ios.timing ==MMC_TIMING_MMC_HS400 ) -if (!sdhci_msm_cdclp533_calibration (host)) +if (!sdhci_msm_hs400_dll_calibration (host)) msm_host->calibration_done = true;spin_lock_irq (&host->lock); }
@@ -805,7 +894,7 @@ static void sdhci_msm_set_clock(struct sdhci_host *host, unsigned int clock)struct sdhci_pltfm_host *pltfm_host =sdhci_priv (host);struct sdhci_msm_host *msm_host =sdhci_pltfm_priv (pltfm_host);struct mmc_ios curr_ios = host->mmc->ios; -u32 config; +u32 config, dll_lock;int rc;if (!clock) {
@@ -862,7 +951,32 @@ static void sdhci_msm_set_clock(struct sdhci_host *host, unsigned int clock) config |=CORE_HC_SELECT_IN_EN ;writel_relaxed (config, host->ioaddr +CORE_VENDOR_SPEC ); } +if (!msm_host->clk_rate && !msm_host->use_cdclp533) { +/* +* Poll on DLL_LOCK or DDR_DLL_LOCK bits in +* CORE_DLL_STATUS to be set. This should get set +* within 15 us at 200 MHz. +*/ + rc =readl_relaxed_poll_timeout (host->ioaddr + +CORE_DLL_STATUS , + dll_lock, + (dll_lock & + (CORE_DLL_LOCK | +CORE_DDR_DLL_LOCK )),10 , +1000 ); +if (rc == -ETIMEDOUT ) +pr_err ("%s: Unable to get DLL_LOCK/DDR_DLL_LOCK, dll_status: 0x%08x\n" , +mmc_hostname (host->mmc), dll_lock); + } }else { +if (!msm_host->use_cdclp533) { + config =readl_relaxed (host->ioaddr + +CORE_VENDOR_SPEC3 ); + config &= ~CORE_PWRSAVE_DLL ; +writel_relaxed (config, host->ioaddr + +CORE_VENDOR_SPEC3 ); + } + config =readl_relaxed (host->ioaddr +CORE_VENDOR_SPEC ); config &= ~CORE_HC_MCLK_SEL_MASK ; config |=CORE_HC_MCLK_SEL_DFLT ;
@@ -1055,6 +1169,13 @@ static int sdhci_msm_probe(struct platform_device *pdev) msm_host->use_14lpp_dll_reset = true;/* +* SDCC 5 controller with major version 1, minor version 0x34 and later +* with HS 400 mode support will use CM DLL instead of CDC LP 533 DLL. +*/ +if (core_major ==1 && core_minor <0x34 ) + msm_host->use_cdclp533 = true; + +/* * Support for some capabilities is not advertised by newer * controller versions and must be explicitly enabled. */
Signature · 7 lines
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 8 lines · Ritesh Harjani
Hi,
This is v9 version of the patch series which adds support for MSM8996. Adds HS400 driver support as well.
These are tested on internal msm8996 & db410c HW.The patch series is ready. Do we think we can apply these patches for next now?
I guess the DTS changes can be picked up by Andy, so they can go via arm-soc?
Then, does the mmc changes depend on the clock changes? If so, I can pick them as well, but then I need an ack from Stephen....
Kind regards
Uffe
Quoted 173 lines
There are only minor changes in v9.
1. From <&xo_board0> -> <&xo_board>.
2. Addressed Adrian minor comments on 009.
3. Other minor changes.Older history:-
Changes from v7 -> v8 :-
1. Added patch 005 to add dt bindings forxo_clock.
2. Added patch 009 to factor outsdhci_enable_clockas discussed on v7 series. 2.a. Modified patch 010 by making use ofsdhci_enable_clock.
2.b. Addressed Stephen's comment on patch 010 to callclk_set_rateunconditionally.
3. Addressed Stephen comments to remove unncessary one line comments, braces and other minor comments.
4. Added changes from Jeremy in patch 002 for gcc-msm8994 as well for sdccclk_rcg2_floor_ops. minor comments.v7 was verified on my Nexus 5X (msm8992).
Older history :-
Below are the changes in v7.Changes from v6 -> v7 :-
1. Removed patch "clk: Addclk_hw_get_clk()helper API to be used by clk providers" in v7 as it was not required.
2. Addressed Stephen review comments on -
"clk: qcom: Add rcg ops to return floor value closest to the requested rate"
3. Addressed comments from Stephen to addxo_clockentry in the sdhc clock node. Using the samexo_clockentry from DT to get theclk_rateofxo_clockused in sdhci-msm driver. Patch 04 adds this entry into DT.
Patch 05 adds the driver support forxo_clockmentioned above.
Hence there is a minor change in Patch05, which can be reviewed and taken into the tree.IMHO, almost all patches are almost done and are ready to be accepted. Will below process work out?
Patches 001 & 002 :- (clock changes) - Can go via Stephen's Boyd Tree. Patches 004 & 010 :- (DTS changes) - Can go via Andy Gross. Patches 003, 005-009 & 011-014 :- (sdhci-msm changes) - Adrian's tree.Please let me know in case if anything else is required on above.
Changes from v5 -> v6 :-
1. Earlier in v5 series DT node was added to get the clk-rates table needed for sdhci-msm driver. But this is removed in this(v6) patch series and instead the clk changes are done in the clk driver as per Rob H comment.2. Added clk driver changes(patch 1-3) to provide floor rate values of requested clock for sdhc client.
For following boards- apq8084, msm8996, msm8916, msm8974.3. Other minor patch comments were addressed.
Changes from v4 -> v5 :-
1. Added HS400 sdhci-msm controller specific changes:- (Patch 10, 11, 12)
2. Addressed comment from Adrian on Patch 07 @[3].
3. Addressed comment from Arnd on Patch 03, to directly addclk_tableintosdhci_msm_host. [4]
4. Addressed comment from Bjorn to not enforce having clk-rates property in DT for older targets based on discussion at [5]
5. Retained Acks from Adrian on patches (01 & 02 & 06) where there were no changes made while addressing above comments.Older history:-
This is v4 version of the patch series.
Patches 01, 02, 05 & 06 were Acked-by Adrian.Changes from v3 -> v4 :-
1. Addressed comments from Adrian on Patch 03, 07, 08.
2. Addressed comments from Bjorn on Patch 03.
3. Added clk-rate support for sdhc DT nodes to all MSM platforms. in Pacth 04.
4. Rebased on next branch of Ulf.Changes from v2 -> v3 :-
1. Addded Patch 01 based on Bjorn comment[2] -
This fixes/unrolls the poor coding style of read/writes of registers from base sdhci-msm driver.2. Fixed/unrolled poor style of reads/writes of registers in Patch 02, based on Bjorn comment[2]. Also changed name of flag from
use_updated_dll_reset->use_14lpp_dll_reset.Changes from
v1->v2:-
1. Removed patch 06 & 08 from v1 patch series[1] (which were introducing unnecessary quirks). Instead have implemented__sdhci_msm_set_clockversion ofsdhci_set_clockinsdhci_msmdriver itself in patch 07 of this patch series.
2. Enabled extra quirk (SDHCI_QUIRK2_PRESET_VALUE_BROKEN) in patch 05 of this patch series.Description of patches :-
This patchset adds clk-rates & other required changes to upstream sdhci-msm driver from codeaurora tree.
It has been tested on a db410c Dragonboard and msm8996 based platform.Patch 0001-0003- Adds support in qcom clk driver to return floor value of requested clock rate instead of ceil rate for sdhc clients.
Patch 0004- Adds updated dll sequence for newer controllers which has
minor_version>=0x42. This is required for msm8996.MSM controller HW recommendation is to use the base MCI clock and directly control this MCI clock at GCC in order to change the clk-rate.
Patches 06-08 bring in required change for this to sdhci-msm.MSM controller would require 2x clock rate from source for DDR bus speed modes. Patch 09 adds this support.
Patch 0010- adds DDR support in DT for sdhc1 of msm8916.
Patches 0011-0014- Adds HS400 support to sdhci-msm.
[1]:- http://www.spinics.net/lists/linux-mmc/msg38467.html
[2]:- http://www.spinics.net/lists/linux-mmc/msg38578.html
[3]:- https://patchwork.kernel.org/patch/9289345/
[4]:- https://www.spinics.net/lists/linux-mmc/msg39107.html
[5]:- http://www.spinics.net/lists/linux-mmc/msg38749.html
[6]:- https://patchwork.kernel.org/patch/9297381/Rajendra Nayak (2):
clk: qcom: Add rcg ops to return floor value closest to the requested
rate
clk: qcom: Move all sdcc rcgs to useclk_rcg2_floor_opsRitesh Harjani (12):
mmc: sdhci-msm: Change poor style writel/readl of registers
ARM: dts: Add xo to sdhc clock node on qcom platforms
dt-bindings: sdhci-msm: Add xo value
mmc: sdhci-msm: Addget_min_clock()andget_max_clock()callback
mmc: sdhci-msm: Enable few quirks
mmc: sdhci: Factor outsdhci_enable_clk
mmc: sdhci-msm: Implementset_clockcallback for sdhci-msm
mmc: sdhci-msm: Add clock changes for DDR mode.
arm64: dts: qcom: msm8916: Add ddr support to sdhc1
mmc: sdhci-msm: Save the calculated tuning phase
mmc: sdhci-msm: Add calibration tuning for CDCLP533 circuit
sdhci: sdhci-msm: update dll configurationVenkat Gopalakrishnan (2):
mmc: sdhci-msm: Update DLL reset sequence
mmc: sdhci-msm: Add HS400 platform support.../devicetree/bindings/mmc/sdhci-msm.txt | 1 + arch/arm/boot/dts/qcom-apq8084.dtsi | 16 +- arch/arm/boot/dts/qcom-msm8974.dtsi | 16 +- arch/arm64/boot/dts/qcom/msm8916.dtsi | 11 +- arch/arm64/boot/dts/qcom/msm8996.dtsi | 9 +- drivers/clk/qcom/clk-rcg.h | 1 + drivers/clk/qcom/clk-rcg2.c | 76 ++- drivers/clk/qcom/common.c | 16 + drivers/clk/qcom/common.h | 2 + drivers/clk/qcom/gcc-apq8084.c | 8 +- drivers/clk/qcom/gcc-msm8916.c | 4 +- drivers/clk/qcom/gcc-msm8974.c | 8 +- drivers/clk/qcom/gcc-msm8994.c | 8 +- drivers/clk/qcom/gcc-msm8996.c | 8 +- drivers/mmc/host/sdhci-msm.c | 626 +++++++++++++++++++-- drivers/mmc/host/sdhci.c | 28 +- drivers/mmc/host/sdhci.h | 1 + 17 files changed, 739 insertions(+), 100 deletions(-)
Quoted 4 lines
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 11 lines · Ulf Hansson
Quoted 8 lines · Ritesh Harjani
Hi,
This is v9 version of the patch series which adds support for MSM8996. Adds HS400 driver support as well.
These are tested on internal msm8996 & db410c HW.The patch series is ready. Do we think we can apply these patches for next now?
I guess the DTS changes can be picked up by Andy, so they can go via arm-soc?
Yes.
Quoted 3 lines
Then, does the mmc changes depend on the clock changes? If so, I can pick them as well, but then I need an ack from Stephen....
Ideal and preferable, would be that clk & mmc changes go in together. But either ways should be fine.
Quoted 186 lines
Kind regards
UffeQuoted 173 lines
There are only minor changes in v9.
1. From <&xo_board0> -> <&xo_board>.
2. Addressed Adrian minor comments on 009.
3. Other minor changes.Older history:-
Changes from v7 -> v8 :-
1. Added patch 005 to add dt bindings forxo_clock.
2. Added patch 009 to factor outsdhci_enable_clockas discussed on v7 series. 2.a. Modified patch 010 by making use ofsdhci_enable_clock.
2.b. Addressed Stephen's comment on patch 010 to callclk_set_rateunconditionally.
3. Addressed Stephen comments to remove unncessary one line comments, braces and other minor comments.
4. Added changes from Jeremy in patch 002 for gcc-msm8994 as well for sdccclk_rcg2_floor_ops. minor comments.v7 was verified on my Nexus 5X (msm8992).
Older history :-
Below are the changes in v7.Changes from v6 -> v7 :-
1. Removed patch "clk: Addclk_hw_get_clk()helper API to be used by clk providers" in v7 as it was not required.
2. Addressed Stephen review comments on -
"clk: qcom: Add rcg ops to return floor value closest to the requested rate"
3. Addressed comments from Stephen to addxo_clockentry in the sdhc clock node. Using the samexo_clockentry from DT to get theclk_rateofxo_clockused in sdhci-msm driver. Patch 04 adds this entry into DT.
Patch 05 adds the driver support forxo_clockmentioned above.
Hence there is a minor change in Patch05, which can be reviewed and taken into the tree.IMHO, almost all patches are almost done and are ready to be accepted. Will below process work out?
Patches 001 & 002 :- (clock changes) - Can go via Stephen's Boyd Tree. Patches 004 & 010 :- (DTS changes) - Can go via Andy Gross. Patches 003, 005-009 & 011-014 :- (sdhci-msm changes) - Adrian's tree.Please let me know in case if anything else is required on above.
Changes from v5 -> v6 :-
1. Earlier in v5 series DT node was added to get the clk-rates table needed for sdhci-msm driver. But this is removed in this(v6) patch series and instead the clk changes are done in the clk driver as per Rob H comment.2. Added clk driver changes(patch 1-3) to provide floor rate values of requested clock for sdhc client.
For following boards- apq8084, msm8996, msm8916, msm8974.3. Other minor patch comments were addressed.
Changes from v4 -> v5 :-
1. Added HS400 sdhci-msm controller specific changes:- (Patch 10, 11, 12)
2. Addressed comment from Adrian on Patch 07 @[3].
3. Addressed comment from Arnd on Patch 03, to directly addclk_tableintosdhci_msm_host. [4]
4. Addressed comment from Bjorn to not enforce having clk-rates property in DT for older targets based on discussion at [5]
5. Retained Acks from Adrian on patches (01 & 02 & 06) where there were no changes made while addressing above comments.Older history:-
This is v4 version of the patch series.
Patches 01, 02, 05 & 06 were Acked-by Adrian.Changes from v3 -> v4 :-
1. Addressed comments from Adrian on Patch 03, 07, 08.
2. Addressed comments from Bjorn on Patch 03.
3. Added clk-rate support for sdhc DT nodes to all MSM platforms. in Pacth 04.
4. Rebased on next branch of Ulf.Changes from v2 -> v3 :-
1. Addded Patch 01 based on Bjorn comment[2] -
This fixes/unrolls the poor coding style of read/writes of registers from base sdhci-msm driver.2. Fixed/unrolled poor style of reads/writes of registers in Patch 02, based on Bjorn comment[2]. Also changed name of flag from
use_updated_dll_reset->use_14lpp_dll_reset.Changes from
v1->v2:-
1. Removed patch 06 & 08 from v1 patch series[1] (which were introducing unnecessary quirks). Instead have implemented__sdhci_msm_set_clockversion ofsdhci_set_clockinsdhci_msmdriver itself in patch 07 of this patch series.
2. Enabled extra quirk (SDHCI_QUIRK2_PRESET_VALUE_BROKEN) in patch 05 of this patch series.Description of patches :-
This patchset adds clk-rates & other required changes to upstream sdhci-msm driver from codeaurora tree.
It has been tested on a db410c Dragonboard and msm8996 based platform.Patch 0001-0003- Adds support in qcom clk driver to return floor value of requested clock rate instead of ceil rate for sdhc clients.
Patch 0004- Adds updated dll sequence for newer controllers which has
minor_version>=0x42. This is required for msm8996.MSM controller HW recommendation is to use the base MCI clock and directly control this MCI clock at GCC in order to change the clk-rate.
Patches 06-08 bring in required change for this to sdhci-msm.MSM controller would require 2x clock rate from source for DDR bus speed modes. Patch 09 adds this support.
Patch 0010- adds DDR support in DT for sdhc1 of msm8916.
Patches 0011-0014- Adds HS400 support to sdhci-msm.
[1]:- http://www.spinics.net/lists/linux-mmc/msg38467.html
[2]:- http://www.spinics.net/lists/linux-mmc/msg38578.html
[3]:- https://patchwork.kernel.org/patch/9289345/
[4]:- https://www.spinics.net/lists/linux-mmc/msg39107.html
[5]:- http://www.spinics.net/lists/linux-mmc/msg38749.html
[6]:- https://patchwork.kernel.org/patch/9297381/Rajendra Nayak (2):
clk: qcom: Add rcg ops to return floor value closest to the requested
rate
clk: qcom: Move all sdcc rcgs to useclk_rcg2_floor_opsRitesh Harjani (12):
mmc: sdhci-msm: Change poor style writel/readl of registers
ARM: dts: Add xo to sdhc clock node on qcom platforms
dt-bindings: sdhci-msm: Add xo value
mmc: sdhci-msm: Addget_min_clock()andget_max_clock()callback
mmc: sdhci-msm: Enable few quirks
mmc: sdhci: Factor outsdhci_enable_clk
mmc: sdhci-msm: Implementset_clockcallback for sdhci-msm
mmc: sdhci-msm: Add clock changes for DDR mode.
arm64: dts: qcom: msm8916: Add ddr support to sdhc1
mmc: sdhci-msm: Save the calculated tuning phase
mmc: sdhci-msm: Add calibration tuning for CDCLP533 circuit
sdhci: sdhci-msm: update dll configurationVenkat Gopalakrishnan (2):
mmc: sdhci-msm: Update DLL reset sequence
mmc: sdhci-msm: Add HS400 platform support.../devicetree/bindings/mmc/sdhci-msm.txt | 1 + arch/arm/boot/dts/qcom-apq8084.dtsi | 16 +- arch/arm/boot/dts/qcom-msm8974.dtsi | 16 +- arch/arm64/boot/dts/qcom/msm8916.dtsi | 11 +- arch/arm64/boot/dts/qcom/msm8996.dtsi | 9 +- drivers/clk/qcom/clk-rcg.h | 1 + drivers/clk/qcom/clk-rcg2.c | 76 ++- drivers/clk/qcom/common.c | 16 + drivers/clk/qcom/common.h | 2 + drivers/clk/qcom/gcc-apq8084.c | 8 +- drivers/clk/qcom/gcc-msm8916.c | 4 +- drivers/clk/qcom/gcc-msm8974.c | 8 +- drivers/clk/qcom/gcc-msm8994.c | 8 +- drivers/clk/qcom/gcc-msm8996.c | 8 +- drivers/mmc/host/sdhci-msm.c | 626 +++++++++++++++++++-- drivers/mmc/host/sdhci.c | 28 +- drivers/mmc/host/sdhci.h | 1 + 17 files changed, 739 insertions(+), 100 deletions(-)Quoted 4 lines
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
A message that is not in the archive (sent off-list or not yet received): d4d05fb9-8a9e-6cf2-dc63-0edbd27a9e55-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org
Quoted 13 lines · Ritesh Harjani
Quoted 10 lines · Ulf Hansson
Quoted 8 lines · Ritesh Harjani
Hi,
This is v9 version of the patch series which adds support for MSM8996. Adds HS400 driver support as well.
These are tested on internal msm8996 & db410c HW.The patch series is ready. Do we think we can apply these patches for next now?
Quoted 9 lines
Quoted 1 line
I guess the DTS changes can be picked up by Andy, so they can go via arm-soc?
Yes.
Quoted 3 lines
Then, does the mmc changes depend on the clock changes? If so, I can pick them as well, but then I need an ack from Stephen....
Ideal and preferable, would be that clk & mmc changes go in together. But either ways should be fine.
There's only a runtime dependency where the clk rates will be wrong if clk tree isn't merged. I'd rather just apply the clk ones directly to clk tree and let all three trees come together in linux-next and work.
Signature · 6 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 20 lines · Stephen Boyd
Quoted 19 lines · Ritesh Harjani
Quoted 11 lines · Ulf Hansson
Quoted 8 lines · Ritesh Harjani
Hi,
This is v9 version of the patch series which adds support for MSM8996. Adds HS400 driver support as well.
These are tested on internal msm8996 & db410c HW.The patch series is ready. Do we think we can apply these patches for next now?
I guess the DTS changes can be picked up by Andy, so they can go via arm-soc?
Yes.
Quoted 3 lines
Then, does the mmc changes depend on the clock changes? If so, I can pick them as well, but then I need an ack from Stephen....
Quoted 8 lines
Quoted 3 lines
Ideal and preferable, would be that clk & mmc changes go in together. But either ways should be fine.
There's only a runtime dependency where the clk rates will be wrong if clk tree isn't merged. I'd rather just apply the clk ones directly to clk tree and let all three trees come together in linux-next and work.
Ok great! So can we queue this patch series to next?
Quoted 1 line
Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
A message that is not in the archive (sent off-list or not yet received): 6dd874b4-8f60-471b-d1e7-089b4b035ad2-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org
Quoted 36 lines · Ritesh Harjani
Quoted 33 lines · Stephen Boyd
Quoted 30 lines · Ritesh Harjani
Quoted 10 lines · Ulf Hansson
Quoted 7 lines · Ritesh Harjani
Hi,
This is v9 version of the patch series which adds support for MSM8996. Adds HS400 driver support as well.
These are tested on internal msm8996 & db410c HW.Quoted 6 lines
Quoted 2 lines
The patch series is ready. Do we think we can apply these patches for next now?
I guess the DTS changes can be picked up by Andy, so they can go via arm-soc?
Yes.
Quoted 3 lines
Then, does the mmc changes depend on the clock changes? If so, I can pick them as well, but then I need an ack from Stephen....
Ideal and preferable, would be that clk & mmc changes go in together. But either ways should be fine.
Quoted 7 lines
Quoted 4 lines
There's only a runtime dependency where the clk rates will be wrong if clk tree isn't merged. I'd rather just apply the clk ones directly to clk tree and let all three trees come together in linux-next and work.
Ok great! So can we queue this patch series to next?
Yes. I have picked up all the mmc patches, including the DT documentation patch. They are queued for next!
The rest is for Andy and Stephen to pick.
Thanks and kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 11 lines · Ulf Hansson
Quoted 8 lines · Ritesh Harjani
Hi,
This is v9 version of the patch series which adds support for MSM8996. Adds HS400 driver support as well.
These are tested on internal msm8996 & db410c HW.The patch series is ready. Do we think we can apply these patches for next now?
I guess the DTS changes can be picked up by Andy, so they can go via arm-soc?
Yeah I'll pick up the DTS change and the Documentation change.
Quoted 6 lines
Then, does the mmc changes depend on the clock changes? If so, I can pick them as well, but then I need an ack from Stephen....
Kind regards
Uffe
Andy
Quoted 8 lines · Andy Gross
Quoted 7 lines · Ulf Hansson
Quoted 6 lines · Ritesh Harjani
Hi,
This is v9 version of the patch series which adds support for MSM8996. Adds HS400 driver support as well.
These are tested on internal msm8996 & db410c HW.
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
The patch series is ready. Do we think we can apply these patches for next now?
I guess the DTS changes can be picked up by Andy, so they can go via arm-soc?
Yeah I'll pick up the DTS change and the Documentation change.
Andy, I would rather like to pick the DT Documentation change via my mmc tree. Just because I normally do that.
This one:
[PATCH v9 05/16] dt-bindings: sdhci-msm: Add xo value
Kind regards
Uffe
PATCH v9 11/16 mmc: sdhci-msm: Add clock changes for DDR mode.
In reply to Ritesh HarjaniSDHC MSM controller need 2x clock for MCLK at GCC. Hence make required changes to have 2x clock for DDR timing modes.
--- drivers/mmc/host/sdhci-msm.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-)
drivers/mmc/host/sdhci-msm.c +17 -4
@@ -610,6 +610,7 @@ static void sdhci_msm_set_clock(struct sdhci_host *host, unsigned int clock) {struct sdhci_pltfm_host *pltfm_host =sdhci_priv (host);struct sdhci_msm_host *msm_host =sdhci_pltfm_priv (pltfm_host); +struct mmc_ios curr_ios = host->mmc->ios;int rc;if (!clock) {
@@ -618,16 +619,28 @@ static void sdhci_msm_set_clock(struct sdhci_host *host, unsigned int clock) }spin_unlock_irq (&host->lock); +/* +* The SDHC requires internal clock frequency to be double the +* actual clock that will be set for DDR mode. The controller +* uses the faster clock(100/400MHz) for some of its parts and +* send the actual required clock (50/200MHz) to the card. +*/ +if (curr_ios.timing ==MMC_TIMING_UHS_DDR50 || + curr_ios.timing ==MMC_TIMING_MMC_DDR52 || + curr_ios.timing ==MMC_TIMING_MMC_HS400 ) + clock *=2 ; rc =clk_set_rate (msm_host->clk, clock);if (rc) { -pr_err ("%s: Failed to set clock at rate %u\n" , -mmc_hostname (host->mmc), clock); +pr_err ("%s: Failed to set clock at rate %u at timing %d\n" , +mmc_hostname (host->mmc), clock, + curr_ios.timing); goto out_lock; } msm_host->clk_rate = clock; -pr_debug ("%s: Setting clock at rate %lu\n" , -mmc_hostname (host->mmc),clk_get_rate (msm_host->clk)); +pr_debug ("%s: Setting clock at rate %lu at timing %d\n" , +mmc_hostname (host->mmc),clk_get_rate (msm_host->clk), + curr_ios.timing); out_lock:spin_lock_irq (&host->lock);
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
PATCH v9 12/16 arm64: dts: qcom: msm8916: Add ddr support to sdhc1
In reply to Ritesh HarjaniThis adds mmc-ddr-1_8v support to DT for sdhc1 of msm8916.
--- arch/arm64/boot/dts/qcom/msm8916.dtsi | 1 + 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/qcom/msm8916.dtsi +1 -0
@@ -515,6 +515,7 @@ <&gcc GCC_SDCC1_AHB_CLK>, <&xo_board>; clock-names = "core", "iface", "xo"; + mmc-ddr-1_8v; bus-width = <8>; non-removable; status = "disabled";
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
PATCH v9 14/16 mmc: sdhci-msm: Save the calculated tuning phase
In reply to Ritesh HarjaniSave the tuning phase once the tuning is performed. This phase value will be used while calibrating DLL for HS400 mode.
--- drivers/mmc/host/sdhci-msm.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
drivers/mmc/host/sdhci-msm.c +10 -0
@@ -75,6 +75,7 @@#define CORE_VENDOR_SPEC_CAPABILITIES0 0x11c +#define INVALID_TUNING_PHASE -1#define SDHCI_MSM_MIN_CLOCK 400000#define CORE_FREQ_100MHZ (100 * 1000 * 1000)
@@ -97,6 +98,7 @@ struct sdhci_msm_host {bool use_14lpp_dll_reset;bool tuning_done;bool calibration_done; +u8 saved_tuning_phase; };/* Platform specific tuning */
@@ -136,6 +138,9 @@ static int msm_config_cm_dll_phase(struct sdhci_host *host, u8 phase)u32 config;struct mmc_host *mmc = host->mmc; +if (phase >0xf ) +return -EINVAL ; +spin_lock_irqsave (&host->lock, flags); config =readl_relaxed (host->ioaddr +CORE_DLL_CONFIG );
@@ -429,6 +434,8 @@ static int sdhci_msm_execute_tuning(struct sdhci_host *host, u32 opcode)int rc;struct mmc_host *mmc = host->mmc;struct mmc_ios ios = host->mmc->ios; +struct sdhci_pltfm_host *pltfm_host =sdhci_priv (host); +struct sdhci_msm_host *msm_host =sdhci_pltfm_priv (pltfm_host);/* * Tuning is required for SDR104, HS200 and HS400 cards and
@@ -453,6 +460,7 @@ static int sdhci_msm_execute_tuning(struct sdhci_host *host, u32 opcode)if (rc)return rc; + msm_host->saved_tuning_phase = phase; rc =mmc_send_tuning (mmc, opcode,NULL );if (!rc) {/* Tuning is successful at this tuning point */
@@ -799,6 +807,8 @@ static int sdhci_msm_probe(struct platform_device *pdev)sdhci_get_of_property (pdev); + msm_host->saved_tuning_phase =INVALID_TUNING_PHASE ; +/* Setup SDCC bus voter clock. */ msm_host->bus_clk =devm_clk_get (&pdev->dev,"bus" );if (!IS_ERR (msm_host->bus_clk)) {
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
PATCH v9 15/16 mmc: sdhci-msm: Add calibration tuning for CDCLP533 circuit
In reply to Ritesh HarjaniIn HS400 mode a new RCLK is introduced on the interface for read data transfers. The eMMC5.0 device transmits the read data to the host with respect to rising and falling edges of RCLK. In order to ensure correct operation of read data transfers in HS400 mode, the incoming RX data needs to be sampled by delayed version of RCLK.
The CDCLP533 delay circuit shifts the RCLK by T/4. It needs to be initialized, configured and enabled once during HS400 mode switch and when operational voltage/clock is changed.
--- drivers/mmc/host/sdhci-msm.c | 151 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 151 insertions(+)
drivers/mmc/host/sdhci-msm.c +151 -0
@@ -20,6 +20,7 @@#include <linux/mmc/mmc.h> #include <linux/pm_runtime.h> #include <linux/slab.h> +#include <linux/iopoll.h> #include "sdhci-pltfm.h"
@@ -58,6 +59,7 @@#define CORE_DLL_PDN BIT(29)#define CORE_DLL_RST BIT(30)#define CORE_DLL_CONFIG 0x100 +#define CORE_CMD_DAT_TRACK_SEL BIT(0)#define CORE_DLL_STATUS 0x108#define CORE_DLL_CONFIG_2 0x1b4
@@ -73,6 +75,33 @@#define CORE_HC_SELECT_IN_HS400 (6 << 19)#define CORE_HC_SELECT_IN_MASK (7 << 19) +#define CORE_CSR_CDC_CTLR_CFG0 0x130 +#define CORE_SW_TRIG_FULL_CALIB BIT(16) +#define CORE_HW_AUTOCAL_ENA BIT(17) + +#define CORE_CSR_CDC_CTLR_CFG1 0x134 +#define CORE_CSR_CDC_CAL_TIMER_CFG0 0x138 +#define CORE_TIMER_ENA BIT(16) + +#define CORE_CSR_CDC_CAL_TIMER_CFG1 0x13C +#define CORE_CSR_CDC_REFCOUNT_CFG 0x140 +#define CORE_CSR_CDC_COARSE_CAL_CFG 0x144 +#define CORE_CDC_OFFSET_CFG 0x14C +#define CORE_CSR_CDC_DELAY_CFG 0x150 +#define CORE_CDC_SLAVE_DDA_CFG 0x160 +#define CORE_CSR_CDC_STATUS0 0x164 +#define CORE_CALIBRATION_DONE BIT(0) + +#define CORE_CDC_ERROR_CODE_MASK 0x7000000 + +#define CORE_CSR_CDC_GEN_CFG 0x178 +#define CORE_CDC_SWITCH_BYPASS_OFF BIT(0) +#define CORE_CDC_SWITCH_RC_EN BIT(1) + +#define CORE_DDR_200_CFG 0x184 +#define CORE_CDC_T4_DLY_SEL BIT(0) +#define CORE_START_CDC_TRAFFIC BIT(6) +#define CORE_VENDOR_SPEC_CAPABILITIES0 0x11c#define INVALID_TUNING_PHASE -1
@@ -427,6 +456,119 @@ static int msm_init_cm_dll(struct sdhci_host *host)return 0 ; } +static int sdhci_msm_cdclp533_calibration (struct sdhci_host *host) +{ +struct sdhci_pltfm_host *pltfm_host =sdhci_priv (host); +struct sdhci_msm_host *msm_host =sdhci_pltfm_priv (pltfm_host); +u32 config, calib_done; +int ret; + +pr_debug ("%s: %s: Enter\n" ,mmc_hostname (host->mmc), __func__); + +/* +* Retuning in HS400 (DDR mode) will fail, just reset the +* tuning block and restore the saved tuning phase. +*/ + ret =msm_init_cm_dll (host); +if (ret) + goto out; + +/* Set the selected phase in delay line hw block */ + ret =msm_config_cm_dll_phase (host, msm_host->saved_tuning_phase); +if (ret) + goto out; + + config =readl_relaxed (host->ioaddr +CORE_DLL_CONFIG ); + config |=CORE_CMD_DAT_TRACK_SEL ; +writel_relaxed (config, host->ioaddr +CORE_DLL_CONFIG ); + + config =readl_relaxed (host->ioaddr +CORE_DDR_200_CFG ); + config &= ~CORE_CDC_T4_DLY_SEL ; +writel_relaxed (config, host->ioaddr +CORE_DDR_200_CFG ); + + config =readl_relaxed (host->ioaddr +CORE_CSR_CDC_GEN_CFG ); + config &= ~CORE_CDC_SWITCH_BYPASS_OFF ; +writel_relaxed (config, host->ioaddr +CORE_CSR_CDC_GEN_CFG ); + + config =readl_relaxed (host->ioaddr +CORE_CSR_CDC_GEN_CFG ); + config |=CORE_CDC_SWITCH_RC_EN ; +writel_relaxed (config, host->ioaddr +CORE_CSR_CDC_GEN_CFG ); + + config =readl_relaxed (host->ioaddr +CORE_DDR_200_CFG ); + config &= ~CORE_START_CDC_TRAFFIC ; +writel_relaxed (config, host->ioaddr +CORE_DDR_200_CFG ); + +/* +* Perform CDC Register Initialization Sequence +* +* CORE_CSR_CDC_CTLR_CFG0 0x11800EC +* CORE_CSR_CDC_CTLR_CFG1 0x3011111 +* CORE_CSR_CDC_CAL_TIMER_CFG0 0x1201000 +* CORE_CSR_CDC_CAL_TIMER_CFG1 0x4 +* CORE_CSR_CDC_REFCOUNT_CFG 0xCB732020 +* CORE_CSR_CDC_COARSE_CAL_CFG 0xB19 +* CORE_CSR_CDC_DELAY_CFG 0x3AC +* CORE_CDC_OFFSET_CFG 0x0 +* CORE_CDC_SLAVE_DDA_CFG 0x16334 +*/ + +writel_relaxed (0x11800EC , host->ioaddr +CORE_CSR_CDC_CTLR_CFG0 ); +writel_relaxed (0x3011111 , host->ioaddr +CORE_CSR_CDC_CTLR_CFG1 ); +writel_relaxed (0x1201000 , host->ioaddr +CORE_CSR_CDC_CAL_TIMER_CFG0 ); +writel_relaxed (0x4 , host->ioaddr +CORE_CSR_CDC_CAL_TIMER_CFG1 ); +writel_relaxed (0xCB732020 , host->ioaddr +CORE_CSR_CDC_REFCOUNT_CFG ); +writel_relaxed (0xB19 , host->ioaddr +CORE_CSR_CDC_COARSE_CAL_CFG ); +writel_relaxed (0x3AC , host->ioaddr +CORE_CSR_CDC_DELAY_CFG ); +writel_relaxed (0x0 , host->ioaddr +CORE_CDC_OFFSET_CFG ); +writel_relaxed (0x16334 , host->ioaddr +CORE_CDC_SLAVE_DDA_CFG ); + +/* CDC HW Calibration */ + + config =readl_relaxed (host->ioaddr +CORE_CSR_CDC_CTLR_CFG0 ); + config |=CORE_SW_TRIG_FULL_CALIB ; +writel_relaxed (config, host->ioaddr +CORE_CSR_CDC_CTLR_CFG0 ); + + config =readl_relaxed (host->ioaddr +CORE_CSR_CDC_CTLR_CFG0 ); + config &= ~CORE_SW_TRIG_FULL_CALIB ; +writel_relaxed (config, host->ioaddr +CORE_CSR_CDC_CTLR_CFG0 ); + + config =readl_relaxed (host->ioaddr +CORE_CSR_CDC_CTLR_CFG0 ); + config |=CORE_HW_AUTOCAL_ENA ; +writel_relaxed (config, host->ioaddr +CORE_CSR_CDC_CTLR_CFG0 ); + + config =readl_relaxed (host->ioaddr +CORE_CSR_CDC_CAL_TIMER_CFG0 ); + config |=CORE_TIMER_ENA ; +writel_relaxed (config, host->ioaddr +CORE_CSR_CDC_CAL_TIMER_CFG0 ); + + ret =readl_relaxed_poll_timeout (host->ioaddr +CORE_CSR_CDC_STATUS0 , + calib_done, + (calib_done &CORE_CALIBRATION_DONE ), +1 ,50 ); + +if (ret == -ETIMEDOUT ) { +pr_err ("%s: %s: CDC calibration was not completed\n" , +mmc_hostname (host->mmc), __func__); + goto out; + } + + ret =readl_relaxed (host->ioaddr +CORE_CSR_CDC_STATUS0 ) + &CORE_CDC_ERROR_CODE_MASK ; +if (ret) { +pr_err ("%s: %s: CDC error code %d\n" , +mmc_hostname (host->mmc), __func__, ret); + ret = -EINVAL ; + goto out; + } + + config =readl_relaxed (host->ioaddr +CORE_DDR_200_CFG ); + config |=CORE_START_CDC_TRAFFIC ; +writel_relaxed (config, host->ioaddr +CORE_DDR_200_CFG ); +out: +pr_debug ("%s: %s: Exit, ret %d\n" ,mmc_hostname (host->mmc), + __func__, ret); +return ret; +} +static int sdhci_msm_execute_tuning (struct sdhci_host *host,u32 opcode) {int tuning_seq_cnt =3 ;
@@ -567,6 +709,15 @@ static void sdhci_msm_set_uhs_signaling(struct sdhci_host *host,dev_dbg (mmc_dev (mmc),"%s: clock=%u uhs=%u ctrl_2=0x%x\n" ,mmc_hostname (host->mmc), host->clock, uhs, ctrl_2);sdhci_writew (host, ctrl_2,SDHCI_HOST_CONTROL2 ); + +spin_unlock_irq (&host->lock); +/* CDCLP533 HW calibration is only required for HS400 mode*/ +if (host->clock >CORE_FREQ_100MHZ && + msm_host->tuning_done && !msm_host->calibration_done && + mmc->ios.timing ==MMC_TIMING_MMC_HS400 ) +if (!sdhci_msm_cdclp533_calibration (host)) + msm_host->calibration_done = true; +spin_lock_irq (&host->lock); }static void sdhci_msm_voltage_switch (struct sdhci_host *host)
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.