Skip to contentSkip to conversation

ASoC: sunxi: Uninitialized variable in probe()

PATCH In review Dan Carpenter 4 participants 4 messages Nov 23, 2016 – Nov 25, 2016

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: sunxi: Uninitialized variable in probe()

Oddly enough, my version of GCC misses this uninitialized variable.

Fixes ba2ff3027b5a ("ASoC: sunxi: Add support for A23/A33/H3 codec's analog path controls")
sound/soc/sunxi/sun8i-codec-analog.c +1 -1
index 222bbd4..af02290 100644
@@ -589,7 +589,7 @@ static int sun8i_codec_analog_cmpnt_probe(struct snd_soc_component *cmpnt)
 	}
 
 	if (quirks->has_hmic) {
-		sun8i_codec_add_hmic(cmpnt);
+		ret = sun8i_codec_add_hmic(cmpnt);
 		if (ret)
 			return ret;
 	}
Acked-by on v1 1/1
#2 lore raw
In reply to Dan Carpenter
Quoted 4 lines · Dan Carpenter

Oddly enough, my version of GCC misses this uninitialized variable.

Fixes ba2ff3027b5a ("ASoC: sunxi: Add support for A23/A33/H3 codec's analog path controls")

Thanks!
Maxime

Signature · 3 lines
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
maintainer
#3 lore raw

Applied "ASoC: sunxi: Uninitialized variable in probe()" to the asoc tree

In reply to Dan Carpenter

The patch

ASoC: sunxi: Uninitialized variable in probe()

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 999982ef7c7f8aa131d32ef551897804443a40a1 Mon Sep 17 00:00:00 2001

From: Dan Carpenter <[email protected]>
Date: Thu, 24 Nov 2016 01:29:06 +0300
Subject: [PATCH] ASoC: sunxi: Uninitialized variable in probe()

Oddly enough, my version of GCC misses this uninitialized variable.

Fixes ba2ff3027b5a ("ASoC: sunxi: Add support for A23/A33/H3 codec's analog path controls")
---
 sound/soc/sunxi/sun8i-codec-analog.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/sunxi/sun8i-codec-analog.c +1 -1
index 222bbd440b1e..af02290ebe49 100644
@@ -589,7 +589,7 @@ static int sun8i_codec_analog_cmpnt_probe(struct snd_soc_component *cmpnt)
 	}
 
 	if (quirks->has_hmic) {
-		sun8i_codec_add_hmic(cmpnt);
+		ret = sun8i_codec_add_hmic(cmpnt);
 		if (ret)
 			return ret;
 	}
Signature · 1 line
2.10.2