Skip to contentSkip to conversation

char/pcmcia: add some error checking in scr24x_read()

PATCH In review Dan Carpenter 2 participants 2 messages Nov 24, 2016

Subsystems (2)
Kernel janitors Char and misc drivers
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 char/pcmcia: add some error checking in scr24x_read()

The "ret = " assignment seems to have accidentally been left off.

Fixes f2ed287bcc90 ("char/pcmcia: add scr24x_cs chip card interface driver")
Signed-off-by Dan Carpenter <[email protected]>
drivers/char/pcmcia/scr24x_cs.c +1 -1
index 4f215ce..8523ec5 100644
@@ -157,7 +157,7 @@ static ssize_t scr24x_read(struct file *filp, char __user *buf, size_t count,
 		ret = -EIO;
 		goto out;
 	}
-	read_chunk(dev, CCID_HEADER_SIZE, len);
+	ret = read_chunk(dev, CCID_HEADER_SIZE, len);
 	if (ret < 0)
 		goto out;
Acked-by on v1 1/1
#1 lore raw
Quoted 12 lines · Dan Carpenter

The "ret = " assignment seems to have accidentally been left off.

Fixes f2ed287bcc90 ("char/pcmcia: add scr24x_cs chip card interface

driver")

Signed-off-by Dan Carpenter <[email protected]>
drivers/char/pcmcia/scr24x_cs.c +0 -0
index 4f215ce..8523ec5 100644

drivers/char/pcmcia/scr24x_cs.c static ssize_t scr24x_read(struct file *filp, · line 163

Quoted 8 lines
drivers/char/pcmcia/scr24x_cs.c +1 -1
@@ -157,7 +157,7 @@ static ssize_t scr24x_read(struct file *filp,
 char __user *buf, size_t count,
  		ret = -EIO;
  		goto out;
  	}
-	read_chunk(dev, CCID_HEADER_SIZE, len);
+	ret = read_chunk(dev, CCID_HEADER_SIZE, len);
  	if (ret < 0)
  		goto out;
Acked-by Lubomir Rintel <[email protected]>

Thank you,
Lubo