iommu/amd: Missing error code in amd_iommu_init_device()

PATCH Applied Dan Carpenter 2 participants 2 messages Nov 24, 2016 – Nov 29, 2016

Subsystems (2)

Kernel janitors IOMMU

lore

Share & tools

lore

Dan Carpenter

author

2016-11-24 11:05 UTC #0 lore raw

PATCH 1/1 iommu/amd: Missing error code in amd_iommu_init_device()

We should set "ret" to -EINVAL if iommu_group_get() fails.

Fixes 55c99a4dc50f ("iommu/amd: Use iommu_attach_group()")

Signed-off-by Dan Carpenter <[email protected]>

drivers/iommu/amd_iommu_v2.c +3 -1

index 594849a..f8ed8c9 100644
@@ -805,8 +805,10 @@ int amd_iommu_init_device(struct pci_dev *pdev, int pasids)
 		goto out_free_domain;
 
 	group = iommu_group_get(&pdev->dev);
-	if (!group)
+	if (!group) {
+		ret = -EINVAL;
 		goto out_free_domain;
+	}
 
 	ret = iommu_attach_group(dev_state->domain, group);
 	if (ret != 0)

Joerg Roedel

maintainer Applied

2016-11-29 16:40 UTC #1 lore raw

Quoted 4 lines · Dan Carpenter

We should set "ret" to -EINVAL if iommu_group_get() fails.
Fixes 55c99a4dc50f ("iommu/amd: Use iommu_attach_group()")
Signed-off-by Dan Carpenter <[email protected]>

Applied, thanks.