package/qemu: fixup enable host QEMU for powerpc64/powerpc64le
PATCH 1/1 package/qemu: fixup enable host QEMU for powerpc64/powerpc64le
Fixes next commit d634d9dda7f3c328d63469cb628c79da49a09e89.
---
Baruch,
I've rebased the patch onto next, I'm not sure what other changes to make. Does it look OK now? (Will it get squashed in next?)
Cheers,
Sam.
package/qemu/qemu.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
package/qemu/qemu.mk +2 -2
@@ -35,7 +35,7 @@ HOST_QEMU_DEPENDENCIES = host-pkgconf host-python host-zlib host-libglib2 host-p # mips64el mips64el # powerpc ppc # powerpc64 ppc64 -# powerpc64le ppc64 (ppc64 supports little-endian) +# powerpc64le ppc64le # sh2a not supported # sh4 sh4 # sh4eb sh4eb
@@ -61,7 +61,7 @@ ifeq ($(HOST_QEMU_ARCH),powerpc64) HOST_QEMU_ARCH = ppc64 endif ifeq ($(HOST_QEMU_ARCH),powerpc64le) -HOST_QEMU_ARCH = ppc64 +HOST_QEMU_ARCH = ppc64le endif ifeq ($(HOST_QEMU_ARCH),sh4a) HOST_QEMU_ARCH = sh4
Signature · 1 line
2.10.0.297.gf6727b0
PATCH 1/1 package/qemu: fixup enable host QEMU for powerpc64/powerpc64le
Hi Sam,
Quoted 8 lines · Sam Bobroff
Fixes next commit
d634d9dda7f3c328d63469cb628c79da49a09e89.Signed-off-by Sam Bobroff <[email protected]>---
Baruch,I've rebased the patch onto next, I'm not sure what other changes to make. Does it look OK now? (Will it get squashed in next?)
The Buildroot maintainers do not rebase/amend next. When there is an issue with an applied commit, either in next or master, post a but fix patch. Hence the commit log should be more detailed. Also, you may mention the commit the introduced the bug as you did, but not 'next'. The next branch will soon merge into master, but the commit log will not change.
baruch
Quoted 25 lines
package/qemu/qemu.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)package/qemu/qemu.mk +2
-2@@ -35,7 +35,7 @@ HOST_QEMU_DEPENDENCIES = host-pkgconf host-python host-zlib host-libglib2 host-p # mips64el mips64el # powerpc ppc # powerpc64 ppc64 -# powerpc64le ppc64 (ppc64 supports little-endian) +# powerpc64le ppc64le # sh2a not supported # sh4 sh4 # sh4eb sh4eb@@ -61,7 +61,7 @@ ifeq ($(HOST_QEMU_ARCH),powerpc64) HOST_QEMU_ARCH = ppc64 endif ifeq ($(HOST_QEMU_ARCH),powerpc64le) -HOST_QEMU_ARCH = ppc64 +HOST_QEMU_ARCH = ppc64le endif ifeq ($(HOST_QEMU_ARCH),sh4a) HOST_QEMU_ARCH = sh4
Signature · 3 lines
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -PATCH 1/1 package/qemu: fixup enable host QEMU for powerpc64/powerpc64le
Hello,
Quoted 7 lines · Baruch Siach
Quoted 6 lines · Sam Bobroff
Fixes next commit
d634d9dda7f3c328d63469cb628c79da49a09e89.Signed-off-by Sam Bobroff <[email protected]>---
Baruch,
Quoted 8 lines
Quoted 2 lines
I've rebased the patch onto next, I'm not sure what other changes to make. Does it look OK now? (Will it get squashed in next?)
The Buildroot maintainers do not rebase/amend next. When there is an issue with an applied commit, either in next or master, post a but fix patch. Hence the commit log should be more detailed. Also, you may mention the commit the introduced the bug as you did, but not 'next'. The next branch will soon merge into master, but the commit log will not change.
Sam: I thought your initial patch was not a bug fix, but a feature addition, which is why I applied it to the "next" branch. However, I see in the autobuilders failures of the host-qemu package for powerpc64, and I believe those would be fixed by your patch. Could you confirm it's the case? If it is, then I'll cherry-pick the original patch (+ this additional fix) into the master branch.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH 1/1 package/qemu: fixup enable host QEMU for powerpc64/powerpc64le
Quoted 20 lines · Thomas Petazzoni
Hello,
Quoted 7 lines · Baruch Siach
Quoted 6 lines · Sam Bobroff
Fixes next commit
d634d9dda7f3c328d63469cb628c79da49a09e89.Signed-off-by Sam Bobroff <[email protected]>---
Baruch,Quoted 8 lines
Quoted 2 lines
I've rebased the patch onto next, I'm not sure what other changes to make. Does it look OK now? (Will it get squashed in next?)
The Buildroot maintainers do not rebase/amend next. When there is an issue with an applied commit, either in next or master, post a but fix patch. Hence the commit log should be more detailed. Also, you may mention the commit the introduced the bug as you did, but not 'next'. The next branch will soon merge into master, but the commit log will not change.
Quoted 6 lines
Sam: I thought your initial patch was not a bug fix, but a feature addition, which is why I applied it to the "next" branch. However, I see in the autobuilders failures of the host-qemu package for powerpc64, and I believe those would be fixed by your patch. Could you confirm it's the case? If it is, then I'll cherry-pick the original patch (+ this additional fix) into the master branch.
Yes, that's the case.
My fixup patch isn't in next yet and I'm going to post a v2 with the right sort of changelog shortly; that should be the one you want (unless it needs a v3!).
Cheers,
Sam.
Thomas Petazzoni
AppliedPATCH 1/1 package/qemu: fixup enable host QEMU for powerpc64/powerpc64le
In reply to Sam BobroffHello,
Quoted 5 lines · Sam Bobroff
Fixes next commit
d634d9dda7f3c328d63469cb628c79da49a09e89.Signed-off-by Sam Bobroff <[email protected]>---
Baruch,
Applied to next.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com