align to generic ib_event logging helper
Subsystems (2)
v2 cover align to generic ib_event logging helper
Changes since V1:
- updated debug level to pr_debug
Max Gurtovoy (2):
nvmet-rdma: align to generic ib_event logging helper
nvme-rdma: align to generic ib_event logging helper
drivers/nvme/host/rdma.c | 4 +++- drivers/nvme/target/rdma.c | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-)
PATCH v2 1/2 nvmet-rdma: align to generic ib_event logging helper
--- drivers/nvme/target/rdma.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
drivers/nvme/target/rdma.c +3 -1
@@ -1124,12 +1124,14 @@ static void nvmet_rdma_qp_event(struct ib_event *event, void *priv) {struct nvmet_rdma_queue *queue = priv; +pr_debug ("received IB QP event: %s (%d)\n" , +ib_event_msg (event->event), event->event); +switch (event->event) {case IB_EVENT_COMM_EST :rdma_notify (queue->cm_id, event->event);break ;default : -pr_err ("received unrecognized IB QP event %d\n" , event->event);break ; } }
Signature · 1 line
1.7.1
PATCH v2 1/2 nvmet-rdma: align to generic ib_event logging helper
Looks fine,
PATCH v2 2/2 nvme-rdma: align to generic ib_event logging helper
In reply to Max Gurtovoy--- drivers/nvme/host/rdma.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
drivers/nvme/host/rdma.c +3 -1
@@ -241,7 +241,9 @@ static void nvme_rdma_free_ring(struct ib_device *ibdev,static void nvme_rdma_qp_event (struct ib_event *event,void *context) { -pr_debug ("QP event %d\n" , event->event); +pr_debug ("QP event %s (%d)\n" , +ib_event_msg (event->event), event->event); + }static int nvme_rdma_wait_for_cm (struct nvme_rdma_queue *queue)
Signature · 1 line
1.7.1
PATCH v2 2/2 nvme-rdma: align to generic ib_event logging helper
sorry, but I don't know why it send the patch-set twice.
Quoted 21 lines · Max Gurtovoy
Signed-off-by Max Gurtovoy <maxg at mellanox.com>--- drivers/nvme/host/rdma.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)drivers/nvme/host/rdma.c +3
-1@@ -241,7 +241,9 @@ static void nvme_rdma_free_ring(struct ib_device *ibdev,static void nvme_rdma_qp_event (struct ib_event *event,void *context) { -pr_debug ("QP event %d\n" , event->event); +pr_debug ("QP event %s (%d)\n" , +ib_event_msg (event->event), event->event); + }static int nvme_rdma_wait_for_cm (struct nvme_rdma_queue *queue)
PATCH v2 2/2 nvme-rdma: align to generic ib_event logging helper
In reply to Max GurtovoyLooks fine,
v2 cover align to generic ib_event logging helper
In reply to Max GurtovoyQuoted 10 lines · Max Gurtovoy
Changes since V1:
? - updated debug level topr_debugMax Gurtovoy (2):
? nvmet-rdma: align to genericib_eventlogging helper ? nvme-rdma: align to genericib_eventlogging helper?drivers/nvme/host/rdma.c???|????4 +++-
?drivers/nvme/target/rdma.c |????4 +++-
?2 files changed, 6 insertions(+), 2 deletions(-)
Seems fine but I'm curious why the extra debugging is needed to the point it warrants a change to the Linux kernel? ?Why does the default print case need to be moved such that there will be a debug message printed for each event instead of the unmatched default event?
Quoted 6 lines
_______________________________________________
Linux-nvme mailing list
Linux-nvme at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
v2 cover align to generic ib_event logging helper
Quoted 8 lines · J Freyensee
Quoted 7 lines · Max Gurtovoy
Changes since V1:
- updated debug level topr_debugMax Gurtovoy (2):
nvmet-rdma: align to genericib_eventlogging helper
nvme-rdma: align to genericib_eventlogging helper
Quoted 8 lines
Quoted 3 lines
drivers/nvme/host/rdma.c | 4 +++- drivers/nvme/target/rdma.c | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-)Seems fine but I'm curious why the extra debugging is needed to the point it warrants a change to the Linux kernel? Why does the default print case need to be moved such that there will be a debug message printed for each event instead of the unmatched default event?
The reason for this commit is to use generic ib_event_msg (that is used in iser/srp/isert etc...). I'll add a new version that will keep it inside the default case in the target side.
Quoted 7 lines
Quoted 7 lines
_______________________________________________
Linux-nvme mailing list
Linux-nvme at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme