sparc64: make string buffers large enough

PATCH New Dan Carpenter 1 participant 1 message Nov 25, 2016

Subsystems (2)

Kernel janitors SPARC + UltraSPARC (sparc/sparc64)

lore

Share & tools

lore

Dan Carpenter

author

2016-11-25 11:03 UTC #0 lore raw

PATCH 1/1 sparc64: make string buffers large enough

My static checker complains that if "lvl" is ULONG_MAX (this is 64 bit) then some of the strings will overflow. I don't know if that's possible but it seems simple enough to make the buffers slightly larger.

Signed-off-by Dan Carpenter <[email protected]>

arch/sparc/kernel/traps_64.c +2 -2

index 4094a51..496fa92 100644
@@ -85,7 +85,7 @@ static void dump_tl1_traplog(struct tl1_traplog *p)
 
 void bad_trap(struct pt_regs *regs, long lvl)
 {
-	char buffer[32];
+	char buffer[36];
 	siginfo_t info;
 
 	if (notify_die(DIE_TRAP, "bad trap", regs,

@@ -116,7 +116,7 @@ void bad_trap(struct pt_regs *regs, long lvl)
 
 void bad_trap_tl1(struct pt_regs *regs, long lvl)
 {
-	char buffer[32];
+	char buffer[36];
 	
 	if (notify_die(DIE_TRAP_TL1, "bad trap tl1", regs,
 		       0, lvl, SIGTRAP) = NOTIFY_STOP)