Skip to contentSkip to conversation

bq24190_charger: Fix PM runtime use for bq24190_battery_set_property

PATCH In review Tony Lindgren 3 participants 4 messages Nov 15, 2016 – Nov 25, 2016 Power supply

lore
Share & tools
lore

Tony Lindgren

author
#0 lore raw

PATCH 1/1 bq24190_charger: Fix PM runtime use for bq24190_battery_set_property

There's a typo, it should do pm_runtime_get_sync, not put.

Cc Mark A. Greer <[email protected]>
Signed-off-by Tony Lindgren <[email protected]>
---
 drivers/power/supply/bq24190_charger.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/power/supply/bq24190_charger.c +1 -1
@@ -1141,7 +1141,7 @@ static int bq24190_battery_set_property(struct power_supply *psy,
 
 	dev_dbg(bdi->dev, "prop: %d\n", psp);
 
-	pm_runtime_put_sync(bdi->dev);
+	pm_runtime_get_sync(bdi->dev);
 
 	switch (psp) {
 	case POWER_SUPPLY_PROP_ONLINE:
Signature · 1 line
2.10.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 22 lines · Tony Lindgren

There's a typo, it should do pm_runtime_get_sync, not put.

Cc Mark A. Greer <[email protected]>
Signed-off-by Tony Lindgren <[email protected]>
---
 drivers/power/supply/bq24190_charger.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/power/supply/bq24190_charger.c +1 -1
@@ -1141,7 +1141,7 @@ static int bq24190_battery_set_property(struct power_supply *psy,
 
 	dev_dbg(bdi->dev, "prop: %d\n", psp);
 
-	pm_runtime_put_sync(bdi->dev);
+	pm_runtime_get_sync(bdi->dev);
 
 	switch (psp) {
 	case POWER_SUPPLY_PROP_ONLINE:
Signature · 1 line
2.10.2

Oops, sorry about that.

Reviewed-by Mark Greer <[email protected]>
maintainer
#2 lore raw
In reply to Tony Lindgren

Hi,

Quoted 12 lines · Tony Lindgren

There's a typo, it should do pm_runtime_get_sync, not put.

Cc Mark A. Greer <[email protected]>
Signed-off-by Tony Lindgren <[email protected]>
---
 drivers/power/supply/bq24190_charger.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/power/supply/bq24190_charger.c static int bq24190_battery_set_property(struct power_supply *psy, · line 1147

Quoted 8 lines
drivers/power/supply/bq24190_charger.c +1 -1
@@ -1141,7 +1141,7 @@ static int bq24190_battery_set_property(struct power_supply *psy,
 
 	dev_dbg(bdi->dev, "prop: %d\n", psp);
 
-	pm_runtime_put_sync(bdi->dev);
+	pm_runtime_get_sync(bdi->dev);
 
 	switch (psp) {
 	case POWER_SUPPLY_PROP_ONLINE:

Thanks, queued to power-supply's for-next branch. I added

Fixes d7bf353fd0aa3

-- Sebastian

author
#3 lore raw
Quoted 21 lines · Sebastian Reichel

Hi,

Quoted 18 lines · Tony Lindgren

There's a typo, it should do pm_runtime_get_sync, not put.

Cc Mark A. Greer <[email protected]>
Signed-off-by Tony Lindgren <[email protected]>
---
 drivers/power/supply/bq24190_charger.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/power/supply/bq24190_charger.c +1 -1
@@ -1141,7 +1141,7 @@ static int bq24190_battery_set_property(struct power_supply *psy,
 
 	dev_dbg(bdi->dev, "prop: %d\n", psp);
 
-	pm_runtime_put_sync(bdi->dev);
+	pm_runtime_get_sync(bdi->dev);
Quoted 6 lines

drivers/power/supply/bq24190_charger.c static int bq24190_battery_set_property(struct power_supply *psy, · line 1147

Quoted 2 lines
drivers/power/supply/bq24190_charger.c +0 -0
 	switch (psp) {
 	case POWER_SUPPLY_PROP_ONLINE:

Thanks, queued to power-supply's for-next branch. I added

Fixes d7bf353fd0aa3

Thanks!

Tony